You are viewing a plain text version of this content. The canonical link for it is here.
- Re: Review Request 56139: Removed redundant 'Times(1)' from master validation tests. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/01 00:00:56 UTC, 4 replies.
- Re: Review Request 56116: Implemented new http::Headers abstraction for WWW-Authenticate. - posted by Jie Yu <yu...@gmail.com> on 2017/02/01 00:15:13 UTC, 4 replies.
- Re: Review Request 56117: Fixed mesos test helper createBasicAuthHeaders() on http header. - posted by Jie Yu <yu...@gmail.com> on 2017/02/01 00:15:20 UTC, 0 replies.
- Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable. - posted by Guangya Liu <gy...@gmail.com> on 2017/02/01 00:36:02 UTC, 4 replies.
- Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights. - posted by Guangya Liu <gy...@gmail.com> on 2017/02/01 01:06:30 UTC, 9 replies.
- Re: Review Request 56144: Added unit test for http::Headers abstraction. - posted by Mesos Reviewbot <re...@mesos.apache.org> on 2017/02/01 01:09:37 UTC, 5 replies.
- Re: Review Request 52349: Add protobuf messages for OCI image spec. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:11:55 UTC, 0 replies.
- Re: Review Request 55139: Implemented parse methods for OCI image spec. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:13:31 UTC, 6 replies.
- Re: Review Request 55140: Added tests for parsing OCI image spec. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:14:25 UTC, 4 replies.
- Re: Review Request 52379: Added agent flag '--oci_store_dir'. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:15:17 UTC, 1 replies.
- Re: Review Request 54638: Added agent flags '--oci_discovery' and '--oci_discovery_prefix'. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:16:11 UTC, 2 replies.
- Re: Review Request 52382: Added stubs for OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:17:15 UTC, 2 replies.
- Re: Review Request 54639: Implemented the 'create()' method of OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:17:51 UTC, 6 replies.
- Re: Review Request 55331: Added 'OCI' message into 'Image' message. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:18:27 UTC, 0 replies.
- Re: Review Request 55332: Added 'message.proto' for OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:20:35 UTC, 0 replies.
- Review Request 56147: Implemented metadata manager for OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:22:24 UTC, 0 replies.
- Re: Review Request 55333: Implemented the 'get()' and '__get()' methods of OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:24:37 UTC, 0 replies.
- Review Request 56148: Implemented the '_get()' method of OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:25:46 UTC, 1 replies.
- Review Request 56149: Implemented the 'fetchImage()' method of OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:26:43 UTC, 0 replies.
- Re: Review Request 55868: Cleanups to the allocator tests. - posted by Jiang Yan Xu <xu...@apple.com> on 2017/02/01 01:27:27 UTC, 3 replies.
- Review Request 56150: Implemented the 'fetchRef()' method of OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:27:38 UTC, 0 replies.
- Review Request 56151: Implemented 'os::architecture()'. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:28:16 UTC, 0 replies.
- Review Request 56152: Implemented the 'fetchManifest()' method of OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:29:06 UTC, 0 replies.
- Review Request 56153: Implemented the 'fetchConfig()' method of OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:29:50 UTC, 0 replies.
- Review Request 56154: Implemented the 'fetchLayers()' method of OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:30:46 UTC, 0 replies.
- Review Request 56155: Implemented the 'moveImage()' method of OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:31:43 UTC, 0 replies.
- Review Request 56156: Implemented the 'recover()' method of OCI store. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:32:23 UTC, 0 replies.
- Review Request 56157: Enabled OCI store in Mesos agent. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/01 01:33:07 UTC, 1 replies.
- Re: Review Request 55321: Introduced process::after. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/01 02:44:47 UTC, 7 replies.
- Re: Review Request 55322: Used process::after instead of process::RateLimiter. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/01 02:48:05 UTC, 2 replies.
- Re: Review Request 55453: Updated comments in `HealthCheck` protobuf for clarity. - posted by Jiang Yan Xu <xu...@apple.com> on 2017/02/01 10:18:10 UTC, 0 replies.
- Re: Review Request 55901: Added support for command health checks to the default executor. - posted by Gastón Kleiman <ga...@mesosphere.com> on 2017/02/01 11:30:35 UTC, 33 replies.
- Review Request 56174: Added skipping already stored layers to local Docker puller. - posted by Ilya Pronin <ip...@twopensource.com> on 2017/02/01 15:17:01 UTC, 7 replies.
- Review Request 56178: Enabled the authorizer to work with MULTI_ROLE frameworks. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/02/01 16:48:55 UTC, 38 replies.
- Review Request 56177: Updated reconciliation comment in "scheduler.proto". - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/01 16:49:45 UTC, 1 replies.
- Re: Review Request 54537: Support 'Basic' auth docker registry on Unified Containerizer. - posted by Jie Yu <yu...@gmail.com> on 2017/02/01 17:51:15 UTC, 7 replies.
- Re: Review Request 55876: Avoided shadowing in `Slave::run()`. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/01 18:14:05 UTC, 0 replies.
- Re: Review Request 51028: Fix tests with rapidly triggered allocations. - posted by Jacob Janco <jj...@gmail.com> on 2017/02/01 18:36:46 UTC, 0 replies.
- Re: Review Request 56086: Simplified AppC provisioner cache keys comparison. - posted by Gilbert Song <so...@gmail.com> on 2017/02/01 18:40:10 UTC, 2 replies.
- Re: Review Request 55732: Added `--3way` option to apply-reviews.py. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/01 18:45:28 UTC, 5 replies.
- Re: Review Request 56087: Simplified AppC provisioner cache keys hashing. - posted by Gilbert Song <so...@gmail.com> on 2017/02/01 18:45:56 UTC, 3 replies.
- Re: Review Request 55971: Updated the agent to be MULTI_ROLE capable. - posted by Michael Park <mp...@apache.org> on 2017/02/01 21:01:04 UTC, 5 replies.
- Re: Review Request 56006: Added CHECK logging to the allocator. - posted by Michael Park <mp...@apache.org> on 2017/02/01 21:03:26 UTC, 0 replies.
- Review Request 56187: Removed all instances of '.Times(1)' from Mesos tests. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/01 21:26:11 UTC, 2 replies.
- Review Request 56188: Removed all instances of '.Times(1)' from libprocess tests. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/01 21:26:58 UTC, 3 replies.
- Re: Review Request 56055: Added validation for 'LAUNCH_NESTED_CONTAINER_SESSION'. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/01 21:28:46 UTC, 1 replies.
- Re: Review Request 55972: Updated master to handle non-MULTI_ROLE agents. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/01 21:32:14 UTC, 3 replies.
- Re: Review Request 56053: Added a 'SECRET' type to the 'Environment' protobuf message. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/01 22:08:46 UTC, 12 replies.
- Re: Review Request 55828: Updated Resources::apply to handle Resource.AllocationInfo. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/01 22:24:04 UTC, 4 replies.
- Review Request 56193: Use Docker cpus instead of cpu_share if possible. - posted by Tomasz Janiszewski <ja...@gmail.com> on 2017/02/01 22:31:50 UTC, 1 replies.
- Re: Review Request 53096: Fix handling in shared count in total resources in the sorter. - posted by Anindya Sinha <an...@apple.com> on 2017/02/01 22:45:29 UTC, 2 replies.
- Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes. - posted by Anindya Sinha <an...@apple.com> on 2017/02/01 22:45:33 UTC, 1 replies.
- Re: Review Request 55359: Consolidate update of allocations in `updateAllocation()`. - posted by Anindya Sinha <an...@apple.com> on 2017/02/01 22:45:35 UTC, 4 replies.
- Re: Review Request 49571: Added a benchmark test for allocations. - posted by Anindya Sinha <an...@apple.com> on 2017/02/01 22:45:39 UTC, 3 replies.
- Re: Review Request 55995: Restored quota correctly during allocator recovery. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/01 22:54:02 UTC, 0 replies.
- Re: Review Request 56004: Fixed MULTI_ROLE related bugs when updating framework info. - posted by Michael Park <mp...@apache.org> on 2017/02/01 23:38:05 UTC, 3 replies.
- Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files. - posted by James Peach <jp...@apache.org> on 2017/02/01 23:51:38 UTC, 9 replies.
- Re: Review Request 54878: Add some simple ldd() tests. - posted by James Peach <jp...@apache.org> on 2017/02/01 23:52:08 UTC, 2 replies.
- Review Request 56195: Updated containerizer->launch path to close IOSwitchboard FDs on error. - posted by Kevin Klues <kl...@gmail.com> on 2017/02/02 00:04:02 UTC, 5 replies.
- Re: Review Request 54712: Use the stout ELF parser to implement ldd. - posted by Jiang Yan Xu <xu...@apple.com> on 2017/02/02 00:04:52 UTC, 3 replies.
- Re: Review Request 55973: Update the tests to handle MULTI_ROLE support. - posted by Michael Park <mp...@apache.org> on 2017/02/02 06:01:02 UTC, 3 replies.
- Review Request 56208: Updated checks library with general check support. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/02 09:56:28 UTC, 17 replies.
- Review Request 56209: Hashed unacknowledged updates by UUID string in command executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/02 09:56:51 UTC, 8 replies.
- Review Request 56210: Reused previous task status to generate a new one in command executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/02 09:57:03 UTC, 9 replies.
- Review Request 56211: Renamed health checker in command executor for clarity. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/02 09:57:11 UTC, 6 replies.
- Review Request 56212: Added support for general checks to command executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/02 09:57:35 UTC, 9 replies.
- Review Request 56213: Added check tests for command executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/02 09:57:52 UTC, 9 replies.
- Review Request 56214: Hashed unacknowledged updates by UUID string in default executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/02 09:57:58 UTC, 4 replies.
- Review Request 56215: Reused previous task status to generate a new one in default executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/02 09:58:08 UTC, 5 replies.
- Review Request 56216: Renamed health checker collection in default executor for clarity. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/02 09:58:18 UTC, 1 replies.
- Review Request 56217: Added support for general checks to default executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/02 09:58:21 UTC, 3 replies.
- Review Request 56218: Added some check tests for default executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/02 09:58:30 UTC, 7 replies.
- Re: Review Request 56052: Added the 'Secret' protobuf message. - posted by Jan Schlicht <ja...@mesosphere.io> on 2017/02/02 10:11:39 UTC, 18 replies.
- Re: Review Request 55900: Improved style in `HealthChecker`. - posted by Gastón Kleiman <ga...@mesosphere.com> on 2017/02/02 16:54:53 UTC, 1 replies.
- Re: Review Request 54602: Replaced `int` with `int_fd` in libprocess. - posted by Alex Clemmer <cl...@gmail.com> on 2017/02/02 19:46:57 UTC, 2 replies.
- Re: Review Request 54601: Replaced `int` with `int_fd` in stout. - posted by Alex Clemmer <cl...@gmail.com> on 2017/02/02 19:47:01 UTC, 3 replies.
- Review Request 56236: Add `syntax = "proto2"` to some files automatically. - posted by Anthony Sottile <as...@yelp.com> on 2017/02/02 20:12:54 UTC, 1 replies.
- Review Request 56237: Add `syntax = "proto2"; ` to the rest of the files. - posted by Anthony Sottile <as...@yelp.com> on 2017/02/02 20:12:57 UTC, 0 replies.
- Review Request 56238: Allow a newer version of google protobuf. - posted by Anthony Sottile <as...@yelp.com> on 2017/02/02 20:13:00 UTC, 1 replies.
- Review Request 56245: Fixed typos in name of test suite. - posted by Neil Conway <ne...@gmail.com> on 2017/02/02 22:58:52 UTC, 1 replies.
- Review Request 56246: Fixed typos. - posted by Neil Conway <ne...@gmail.com> on 2017/02/02 22:59:02 UTC, 1 replies.
- Review Request 56247: Switched to implicit roles in master quota tests. - posted by Neil Conway <ne...@gmail.com> on 2017/02/02 22:59:09 UTC, 3 replies.
- Review Request 56248: Replaced use of ".get()" in master quota tests with "->". - posted by Neil Conway <ne...@gmail.com> on 2017/02/02 22:59:19 UTC, 1 replies.
- Review Request 56249: Cleaned up code style slightly in DRF sorter. - posted by Neil Conway <ne...@gmail.com> on 2017/02/02 22:59:27 UTC, 2 replies.
- Review Request 56250: Cleaned up headers in DRF sorter. - posted by Neil Conway <ne...@gmail.com> on 2017/02/02 22:59:35 UTC, 1 replies.
- Review Request 56251: Tightened assertions in sorter and allocator. - posted by Neil Conway <ne...@gmail.com> on 2017/02/02 22:59:43 UTC, 5 replies.
- Re: Review Request 55863: Introduce a helper for injecting AllocationInfo into offer operations. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/02 23:05:16 UTC, 2 replies.
- Re: Review Request 55910: Prevent unintended mutation in the allocator. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/03 00:17:33 UTC, 3 replies.
- Review Request 56267: Made `kill` not use pipelining in the default executor. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/03 04:45:45 UTC, 1 replies.
- Review Request 56268: Made `kill()` not invoke `shutdown()` in the default executor. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/03 04:45:49 UTC, 4 replies.
- Review Request 56269: Introduced a `Container` struct on the default executor. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/03 04:45:53 UTC, 4 replies.
- Review Request 56270: Made the default executor launch multiple task groups. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/03 04:45:58 UTC, 5 replies.
- Re: Review Request 51027: Track allocation candidates to bound allocator. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/02/03 10:45:35 UTC, 5 replies.
- Review Request 56284: Added ProvisionerDockerLocalStoreTest.SkippedLayers test. - posted by Ilya Pronin <ip...@twopensource.com> on 2017/02/03 18:08:51 UTC, 5 replies.
- Re: Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/03 18:55:57 UTC, 11 replies.
- Re: Review Request 51052: Made mesos-docker-execute understand cgroups_enable_cfs. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/03 18:56:18 UTC, 5 replies.
- Re: Review Request 55160: Added test for DockerContainerizer when `cgroups_enable_cfs` is set. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/03 18:56:34 UTC, 8 replies.
- Review Request 56288: Improved the wording of what's logged on command health check timeouts. - posted by Gastón Kleiman <ga...@mesosphere.com> on 2017/02/03 19:50:51 UTC, 5 replies.
- Re: Review Request 56250: Cleaned up headers in sorter and allocator metrics. - posted by Neil Conway <ne...@gmail.com> on 2017/02/03 20:21:57 UTC, 1 replies.
- Review Request 56291: Removed unnecessary mkdirs in ProvisionerDockerLocalStoreTest.*. - posted by Ilya Pronin <ip...@twopensource.com> on 2017/02/03 20:43:19 UTC, 1 replies.
- Review Request 56293: Added '--runtime_dir' flag to the agent configuration docs. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/03 23:05:53 UTC, 2 replies.
- Review Request 56292: Updated isolator module docs with checkpointing information. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/03 23:06:19 UTC, 2 replies.
- Review Request 56296: Fix to potential dangling pointer in `batch()`. - posted by Jacob Janco <jj...@gmail.com> on 2017/02/03 23:47:42 UTC, 2 replies.
- Re: Review Request 55870: Update the allocator to handle frameworks with multiple roles. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/04 03:02:15 UTC, 5 replies.
- Re: Review Request 55967: Update the allocator unit tests to reflect MULTI_ROLE support. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/04 03:02:24 UTC, 1 replies.
- Re: Review Request 55970: Updated the master's HTTP operations to handle MULTI_ROLE changes. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/04 03:02:31 UTC, 1 replies.
- Re: Review Request 55541: Replaced (another) recursive implementation with process::loop. - posted by Benjamin Hindman <be...@berkeley.edu> on 2017/02/04 08:02:00 UTC, 0 replies.
- Review Request 56308: Modified active containers key to be `TaskID` in the default executor. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/04 17:49:06 UTC, 1 replies.
- Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX. - posted by Michael Park <mp...@apache.org> on 2017/02/05 01:36:57 UTC, 9 replies.
- Re: Review Request 54595: Introduced an `os::dup` abstraction in stout. - posted by Michael Park <mp...@apache.org> on 2017/02/05 01:38:01 UTC, 4 replies.
- Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout. - posted by Michael Park <mp...@apache.org> on 2017/02/05 01:38:34 UTC, 3 replies.
- Re: Review Request 54762: Introduced an `os::pipe` abstraction to stout. - posted by Michael Park <mp...@apache.org> on 2017/02/05 01:38:38 UTC, 2 replies.
- Re: Review Request 54603: Replaced `int` with `int_fd` in mesos. - posted by Michael Park <mp...@apache.org> on 2017/02/05 01:39:58 UTC, 0 replies.
- Review Request 56314: Fix the OS X build. - posted by James Peach <jp...@apache.org> on 2017/02/05 03:46:54 UTC, 5 replies.
- Re: Review Request 55625: Prevented certain kinds of gaming the quota system. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/06 01:41:12 UTC, 0 replies.
- Re: Review Request 53741: Show maintainance schedule info in the WebUI. - posted by Tomasz Janiszewski <ja...@gmail.com> on 2017/02/06 09:29:36 UTC, 2 replies.
- Review Request 56326: Size of the favicon optimized. - posted by Armand Grillet <ag...@mesosphere.com> on 2017/02/06 13:00:26 UTC, 1 replies.
- Re: Review Request 55887: Check task user before allowing a task to be launched on the agent. - posted by Alexander Rojas <al...@mesosphere.io> on 2017/02/06 15:12:40 UTC, 9 replies.
- Review Request 56327: Updated Suppress and Revive proto to support per role. - posted by Guangya Liu <gy...@apache.org> on 2017/02/06 15:13:06 UTC, 3 replies.
- Review Request 56328: Augmented master `Suppress` API to accept `Call::Suppress`. - posted by Guangya Liu <gy...@apache.org> on 2017/02/06 15:13:12 UTC, 1 replies.
- Review Request 56330: Enabled suppress offer per role. - posted by Guangya Liu <gy...@apache.org> on 2017/02/06 15:13:13 UTC, 9 replies.
- Re: Review Request 55543: Fail the build if %PreferredToolArchitecture% is not set to `x64`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/02/06 18:21:38 UTC, 2 replies.
- Re: Review Request 55749: Added CMake to standard documentation. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/02/06 18:33:58 UTC, 2 replies.
- Re: Review Request 55162: Stout: Added style fixes and some useful error messages. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/02/06 18:34:44 UTC, 0 replies.
- Re: Review Request 54650: Added validation for roles in ACCEPT call. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/06 19:29:42 UTC, 4 replies.
- Review Request 56338: Removed an unnecessary copy of operations in the allocator. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/06 19:47:38 UTC, 1 replies.
- Re: Review Request 56284: Added ProvisionerDockerLocalStoreTest.MissingLayer test. - posted by Ilya Pronin <ip...@twopensource.com> on 2017/02/06 20:40:39 UTC, 5 replies.
- Re: Review Request 55461: Made resource reservation validation multi-role aware. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/06 21:28:41 UTC, 4 replies.
- Review Request 56339: Changed test DockerArchive to include environment variables. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/02/06 22:04:48 UTC, 6 replies.
- Review Request 56340: Disabled ability to launch default executor with ContainerInfo. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/02/06 22:04:49 UTC, 2 replies.
- Review Request 56341: Added special case for command executor's environment. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/02/06 22:04:50 UTC, 0 replies.
- Review Request 56347: Stout: Explicitly delete `SharedHandle` default constructor. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/02/06 22:55:43 UTC, 3 replies.
- Review Request 56349: Clarified comments in sorter. - posted by Neil Conway <ne...@gmail.com> on 2017/02/06 23:10:58 UTC, 1 replies.
- Review Request 56350: Const-ified several methods in the sorter interface. - posted by Neil Conway <ne...@gmail.com> on 2017/02/06 23:13:42 UTC, 3 replies.
- Review Request 56351: Renamed a private member function in DRFSorter. - posted by Neil Conway <ne...@gmail.com> on 2017/02/06 23:14:39 UTC, 1 replies.
- Review Request 56352: Optimized and simplified `DRFSorter::allocated()`. - posted by Neil Conway <ne...@gmail.com> on 2017/02/06 23:16:36 UTC, 1 replies.
- Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents. - posted by Anindya Sinha <an...@apple.com> on 2017/02/06 23:17:53 UTC, 10 replies.
- Re: Review Request 56341: Changed docker/runtime isolator's handling of Environment. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/02/06 23:19:11 UTC, 4 replies.
- Review Request 56354: Fixed incorrect `CHECK_EQ`s in `WindowsFD`. - posted by Michael Park <mp...@apache.org> on 2017/02/06 23:22:40 UTC, 4 replies.
- Review Request 56360: Fixed consistency in error messages. - posted by Jay Guo <gu...@gmail.com> on 2017/02/07 02:10:58 UTC, 4 replies.
- Review Request 56359: Add framework principal to the slave state endpoint - posted by Jeff Malnick <ma...@gmail.com> on 2017/02/07 02:14:02 UTC, 2 replies.
- Review Request 56362: Windows: Create the `WindowsLauncher`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/02/07 02:30:59 UTC, 6 replies.
- Review Request 56363: Stout: Add predicate `find` semantics to `hashmap`. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/02/07 02:31:03 UTC, 3 replies.
- Review Request 56364: Windows: Stout: Rewrite Job Object wrappers. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/02/07 02:31:09 UTC, 8 replies.
- Review Request 56365: Windows: Refactor `WindowsLauncher` to use Job Objects. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/02/07 02:31:14 UTC, 0 replies.
- Review Request 56366: Windows: Refactor executor to use `SharedHandle` semantics. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/02/07 02:31:21 UTC, 3 replies.
- Review Request 56367: Stout: Windows: patch `os::killtree` to terminate job objects. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/02/07 02:31:27 UTC, 4 replies.
- Review Request 56368: Libprocess: Windows: Remove `CREATE_JOB` parent hook. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/02/07 02:31:31 UTC, 7 replies.
- Review Request 56370: Added a test to ensure multi-role framework receiving offers. - posted by Jay Guo <gu...@gmail.com> on 2017/02/07 03:16:49 UTC, 6 replies.
- Re: Review Request 52284: Implemented more quota validation tests. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/07 07:10:49 UTC, 1 replies.
- Re: Review Request 53679: Implemented capacity heuristic check related tests. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/07 07:11:11 UTC, 5 replies.
- Re: Review Request 53691: Implemented some quota functionality tests. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/07 07:13:46 UTC, 1 replies.
- Re: Review Request 52103: Implemented quota update through `PUT` method. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/07 07:14:33 UTC, 1 replies.
- Re: Review Request 53991: Added master API call for `UPDATE_QUOTA`. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/07 07:14:50 UTC, 1 replies.
- Re: Review Request 54135: Added test for offer rescind in quota update. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/07 07:15:03 UTC, 2 replies.
- Re: Review Request 53993: Updated quota doc to support quota update. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/07 07:15:17 UTC, 8 replies.
- Review Request 56375: Added a test to ensure offers with different roles cannot be combined. - posted by Jay Guo <gu...@gmail.com> on 2017/02/07 07:16:35 UTC, 10 replies.
- Re: Review Request 55710: Added agent capabilities to /state endpoint of master. - posted by Jay Guo <gu...@gmail.com> on 2017/02/07 09:59:27 UTC, 12 replies.
- Review Request 56371: Enabled `ReviveOffersMessage` support revive per role. - posted by Guangya Liu <gy...@apache.org> on 2017/02/07 10:10:15 UTC, 3 replies.
- Review Request 56373: Augmented master `Revive` API to accept `Call::Revive`. - posted by Guangya Liu <gy...@apache.org> on 2017/02/07 10:10:18 UTC, 1 replies.
- Review Request 56374: Enabled revive offer per role. - posted by Guangya Liu <gy...@apache.org> on 2017/02/07 10:10:20 UTC, 2 replies.
- Review Request 56376: Updated allocator test to support create multi role framework. - posted by Guangya Liu <gy...@apache.org> on 2017/02/07 10:10:22 UTC, 10 replies.
- Review Request 56378: Added test case for suppress and revive with multi role framework. - posted by Guangya Liu <gy...@apache.org> on 2017/02/07 10:10:23 UTC, 5 replies.
- Re: Review Request 51942: Removed scalars() API. - posted by Guangya Liu <gy...@apache.org> on 2017/02/07 15:14:44 UTC, 0 replies.
- Re: Review Request 55462: Validate resource reservation against allocated role. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/02/07 16:43:33 UTC, 15 replies.
- Review Request 56391: Set AllocationInfo in some reservation-related tests. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/02/07 16:43:34 UTC, 4 replies.
- Review Request 56392: Tightened test expecations in reservation-related tests. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/02/07 16:43:38 UTC, 13 replies.
- Re: Review Request 55771: Rejected optimizing if we are working with a libcxx with UB. - posted by Till Toenshoff <to...@me.com> on 2017/02/07 17:32:42 UTC, 5 replies.
- Re: Review Request 55773: Rejected optimizing if we are working with a libcxx with UB. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/02/07 19:49:20 UTC, 1 replies.
- Re: Review Request 55772: Rejected optimizing if we are working with a libcxx with UB. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/02/07 19:49:21 UTC, 1 replies.
- Review Request 56408: Fixed a regression in the execute CLI command. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/07 22:13:00 UTC, 3 replies.
- Review Request 56409: Enabled flag parsing of the 'Environment' protobuf. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/02/07 22:16:15 UTC, 1 replies.
- Review Request 56410: Increased granularity of environment handling in command executor. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/02/07 22:18:45 UTC, 3 replies.
- Re: Review Request 56341: Updated AppC & Docker runtime isolators' handling of Environment. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/02/07 22:26:45 UTC, 1 replies.
- Re: Review Request 54783: Added tests for authorization of launching container sessions. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/08 00:12:47 UTC, 1 replies.
- Re: Review Request 54784: Adds tests for authorization when attaching to a container input. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/08 00:57:42 UTC, 0 replies.
- Review Request 56421: Added TODOs to make the agent code safer. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/08 02:38:06 UTC, 1 replies.
- Review Request 56422: Inject resource allocation info in agent for received tasks. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/08 02:53:40 UTC, 1 replies.
- Review Request 56423: Added CHECKs to the agent to ensure allocation info is set. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/08 02:54:14 UTC, 1 replies.
- Review Request 56424: Removed a stale TODO in the agent code. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/08 02:54:30 UTC, 2 replies.
- Review Request 56427: Added another sorter test case. - posted by Neil Conway <ne...@gmail.com> on 2017/02/08 03:40:16 UTC, 4 replies.
- Re: Review Request 54846: Removed `docker exec` when perform health checks in docker executor. - posted by James DeFelice <ja...@gmail.com> on 2017/02/08 14:18:34 UTC, 2 replies.
- Review Request 56447: Added a helper function for creating valid empty `CheckStatusInfo`s. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/08 15:12:13 UTC, 3 replies.
- Review Request 56448: Augmented continuation name in default executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/08 15:18:37 UTC, 0 replies.
- Review Request 56449: Moved health checker closer to container in default executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/08 15:20:31 UTC, 4 replies.
- Re: Review Request 56448: Shortened continuation name in default executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/08 15:29:48 UTC, 4 replies.
- Re: Review Request 56362: Windows: Create the Windows container launcher. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/02/08 21:11:26 UTC, 14 replies.
- Review Request 56466: Use the stout ELF parser to collect Linux rootfs files. - posted by James Peach <jp...@apache.org> on 2017/02/08 23:34:55 UTC, 0 replies.
- Review Request 56465: Add support for the ELF .interp section. - posted by James Peach <jp...@apache.org> on 2017/02/08 23:35:44 UTC, 4 replies.
- Re: Review Request 56466: Capture ELF interpreters in the ldd utility. - posted by James Peach <jp...@apache.org> on 2017/02/08 23:50:40 UTC, 6 replies.
- Review Request 56472: Revert "Revert "Use the stout ELF parser to collect rootfs files."". - posted by James Peach <jp...@apache.org> on 2017/02/08 23:51:39 UTC, 3 replies.
- Review Request 56474: Added support for multiple authenticators to libprocess. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/09 00:58:06 UTC, 5 replies.
- Review Request 56475: Added libprocess tests for multiple authenticators. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/09 01:03:06 UTC, 2 replies.
- Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/09 01:06:04 UTC, 5 replies.
- Review Request 56478: Renamed 'unsetAuthenticator' to 'unsetAuthenticators' in libprocess. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/09 06:10:22 UTC, 2 replies.
- Review Request 56479: Renamed 'unsetAuthenticator' to 'unsetAuthenticators' in Mesos. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/09 06:11:04 UTC, 2 replies.
- Review Request 56493: Port_mapping isolator: do not depend on interface speed. - posted by Pierre Cheynier <me...@pierre-cheynier.net> on 2017/02/09 13:00:06 UTC, 12 replies.
- Review Request 56499: Added roles field to framework. - posted by Guangya Liu <gy...@apache.org> on 2017/02/09 15:50:23 UTC, 6 replies.
- Review Request 56504: Stout: Made `os::mktemp` fully cross-platform. - posted by Alex Clemmer <cl...@gmail.com> on 2017/02/09 17:57:32 UTC, 4 replies.
- Review Request 56505: Added Windows support for Docker executor. - posted by Alex Clemmer <cl...@gmail.com> on 2017/02/09 17:57:36 UTC, 8 replies.
- Re: Review Request 52284: Implemented more quota validation tests and validate duplicate name. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/09 21:40:10 UTC, 5 replies.
- Review Request 56525: Fixed a crash on the agent when handling the SIGUSR1 signal. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/10 01:36:30 UTC, 3 replies.
- Review Request 56524: Added `drop` for overload to avoid custom logging. - posted by Guangya Liu <gy...@apache.org> on 2017/02/10 01:42:21 UTC, 5 replies.
- Review Request 56530: Prevent offers for old agents being sent to MULTI_ROLE frameworks. - posted by Jay Guo <gu...@gmail.com> on 2017/02/10 06:10:48 UTC, 7 replies.
- Review Request 56526: Added stout constants for special path components. - posted by Jiang Yan Xu <ya...@jxu.me> on 2017/02/10 07:03:56 UTC, 1 replies.
- Review Request 56527: Disallowed special path components in IDs. - posted by Jiang Yan Xu <ya...@jxu.me> on 2017/02/10 07:05:08 UTC, 5 replies.
- Review Request 56533: Fix the shell script to not use deprecated [..] in increment operation. - posted by Anindya Sinha <an...@apple.com> on 2017/02/10 07:26:59 UTC, 2 replies.
- Review Request 56537: Added a test to ensure framework can upgrade to support MULTI_ROLE. - posted by Jay Guo <gu...@gmail.com> on 2017/02/10 09:32:41 UTC, 10 replies.
- Review Request 56551: Updated CHANGELOG with still experimental features from 1.1.0. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/10 16:48:40 UTC, 1 replies.
- Review Request 56568: Modified the executor driver to always relink on agent failover. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/11 00:45:21 UTC, 3 replies.
- Review Request 56569: Updated `drop` log message from `ERROR` to `WARNING`. - posted by Guangya Liu <gy...@apache.org> on 2017/02/11 01:07:36 UTC, 1 replies.
- Re: Review Request 56569: Made ignoring logging use WARNING in master. - posted by Guangya Liu <gy...@apache.org> on 2017/02/11 01:52:19 UTC, 0 replies.
- Review Request 56587: Fixed a crash on the master upon receiving an invalid inverse offer. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/13 05:44:11 UTC, 8 replies.
- Review Request 56591: Stout: Removed MSVC compiler warnings. - posted by Alex Clemmer <cl...@gmail.com> on 2017/02/13 10:21:33 UTC, 5 replies.
- Review Request 56592: Libprocess: Removed MSVC compiler warnings. - posted by Alex Clemmer <cl...@gmail.com> on 2017/02/13 10:21:36 UTC, 2 replies.
- Review Request 56593: Explicitly marked protobuf files as using v2 syntax. - posted by Alex Clemmer <cl...@gmail.com> on 2017/02/13 10:34:20 UTC, 2 replies.
- Review Request 56594: Explicitly marked protobuf files as using v2 syntax. - posted by Alex Clemmer <cl...@gmail.com> on 2017/02/13 10:34:26 UTC, 3 replies.
- Review Request 56601: Used single quotes instead of backticks in error message. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/02/13 15:38:03 UTC, 10 replies.
- Review Request 56611: Relax perf version check for Arch Linux. - posted by James Peach <jp...@apache.org> on 2017/02/13 20:11:50 UTC, 12 replies.
- Re: Review Request 53877: Added temporary file environment passing towards docker. - posted by James DeFelice <ja...@gmail.com> on 2017/02/13 22:10:50 UTC, 0 replies.
- Re: Review Request 51257: Add external process container logger. - posted by Will Rouesnel <w....@gmail.com> on 2017/02/13 22:41:27 UTC, 1 replies.
- Re: Review Request 51258: Add documentation for the ExternalContainerLogger module. - posted by Will Rouesnel <w....@gmail.com> on 2017/02/13 22:42:18 UTC, 1 replies.
- Re: Review Request 55030: CMake: Added source groups for libprocess build. - posted by Alex Clemmer <cl...@gmail.com> on 2017/02/13 23:04:20 UTC, 0 replies.
- Review Request 56623: Implemented 'AuthenticationContext' in libprocess. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/13 23:23:34 UTC, 18 replies.
- Review Request 56617: Updated libprocess handlers to use 'AuthenticationContext'. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/13 23:24:08 UTC, 5 replies.
- Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/13 23:46:36 UTC, 13 replies.
- Review Request 56619: Updated Mesos handlers to use 'AuthenticationContext'. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/14 00:14:54 UTC, 6 replies.
- Review Request 56624: Updated libprocess tests to use 'AuthenticationContext'. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/14 00:15:09 UTC, 1 replies.
- Review Request 56621: Updated Mesos tests to use 'AuthenticationContext'. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/14 00:15:23 UTC, 3 replies.
- Review Request 56644: Added a member variable in Slave to store slave capabilities. - posted by Jay Guo <gu...@gmail.com> on 2017/02/14 07:13:21 UTC, 1 replies.
- Review Request 56645: Added agent capabilities to `/state`(v0) endpoint of agent. - posted by Jay Guo <gu...@gmail.com> on 2017/02/14 07:13:51 UTC, 6 replies.
- Review Request 56646: Fixed indentations in master/http.cpp. - posted by Jay Guo <gu...@gmail.com> on 2017/02/14 07:14:08 UTC, 1 replies.
- Review Request 56652: Windows: Change ZK patch to fix macro redefinition warnings on MSVC. - posted by Alex Clemmer <cl...@gmail.com> on 2017/02/14 11:01:35 UTC, 1 replies.
- Review Request 56657: Add support for local resolution of Docker images. - posted by Santhosh Kumar Shanmugham <sa...@gmail.com> on 2017/02/14 17:51:43 UTC, 6 replies.
- Review Request 56675: Silence MSVC compiler warnings in libmesos. - posted by Alex Clemmer <cl...@gmail.com> on 2017/02/14 18:40:58 UTC, 5 replies.
- Re: Review Request 55547: Windows: Standardize on win32 environment, transition away from CRT. - posted by Alex Clemmer <cl...@gmail.com> on 2017/02/14 18:47:32 UTC, 3 replies.
- Review Request 56681: Use glog to log EXIT() messages. - posted by James Peach <jp...@apache.org> on 2017/02/14 21:04:38 UTC, 1 replies.
- Review Request 56680: Apply glog to agent exit messages. - posted by James Peach <jp...@apache.org> on 2017/02/14 21:05:06 UTC, 0 replies.
- Review Request 56689: Windows: Prevented crash if sandbox `stdout` file already exists. - posted by Alex Clemmer <cl...@gmail.com> on 2017/02/14 23:40:53 UTC, 1 replies.
- Review Request 56692: Silenced a GMock warning in a test. - posted by Neil Conway <ne...@gmail.com> on 2017/02/15 00:05:33 UTC, 4 replies.
- Re: Review Request 51624: Implemented 'GetAgent' call in v1 agent API. - posted by Vinod Kone <vi...@gmail.com> on 2017/02/15 02:08:26 UTC, 1 replies.
- Review Request 56702: Windows: Handle environment variable inheritance uniformly in Mesos. - posted by Alex Clemmer <cl...@gmail.com> on 2017/02/15 10:58:59 UTC, 2 replies.
- Re: Review Request 54783: Adds authorization tests of launching container sessions API. - posted by Alexander Rojas <al...@mesosphere.io> on 2017/02/15 13:01:15 UTC, 2 replies.
- Re: Review Request 54784: Adds authorization tests when trying to attach to a container input. - posted by Alexander Rojas <al...@mesosphere.io> on 2017/02/15 14:31:35 UTC, 0 replies.
- Re: Review Request 54784: Added authorization tests when trying to attach to a container input. - posted by Alexander Rojas <al...@mesosphere.io> on 2017/02/15 14:31:56 UTC, 2 replies.
- Review Request 56711: Fixed fetcher to not pick up environment variables it should not see. - posted by Till Toenshoff <to...@me.com> on 2017/02/15 15:35:53 UTC, 15 replies.
- Review Request 56716: Fixed a crash on the default executor due to a failed invariant check. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/15 18:28:26 UTC, 2 replies.
- Re: Review Request 51053: Update leveldb to 1.19. - posted by Tomasz Janiszewski <ja...@gmail.com> on 2017/02/15 20:44:31 UTC, 5 replies.
- Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/15 21:14:07 UTC, 0 replies.
- Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/15 21:14:31 UTC, 0 replies.
- Re: Review Request 53105: Added an hourly timer for `slave/docker_containerizer/pull`. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/15 21:14:53 UTC, 0 replies.
- Re: Review Request 55727: Checkpoint and track docker image layer sizes. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/15 21:15:13 UTC, 0 replies.
- Review Request 56721: Implemented pruneImages with a mark and sweep in docker store. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/15 21:17:11 UTC, 0 replies.
- Review Request 56722: Add a new operator API for `PRUNE_IMAGES`. - posted by Zhitao Li <zh...@gmail.com> on 2017/02/15 21:18:56 UTC, 1 replies.
- Review Request 56730: Kill stray tasks when tearing down test cgroups. - posted by James Peach <jp...@apache.org> on 2017/02/15 23:20:47 UTC, 0 replies.
- Review Request 56733: Mount all supported subsystems in the containerizer tests. - posted by James Peach <jp...@apache.org> on 2017/02/15 23:21:42 UTC, 1 replies.
- Review Request 56732: Remove unnecessary perf version checks. - posted by James Peach <jp...@apache.org> on 2017/02/15 23:22:21 UTC, 0 replies.
- Review Request 56731: Fix perf-stat parsing for recent perf releases. - posted by James Peach <jp...@apache.org> on 2017/02/15 23:24:19 UTC, 0 replies.
- Review Request 56740: Update Allegro url on Powered By page. - posted by Kamil Wargu?a <kw...@gmail.com> on 2017/02/16 07:23:41 UTC, 2 replies.
- Re: Review Request 56665: Added a URL-safe base64 implementation. - posted by Jan Schlicht <ja...@mesosphere.io> on 2017/02/16 09:33:12 UTC, 3 replies.
- Re: Review Request 56666: Added a HMAC SHA256 generator. - posted by Jan Schlicht <ja...@mesosphere.io> on 2017/02/16 09:34:09 UTC, 3 replies.
- Re: Review Request 56667: Added support for JSON Web Tokens. - posted by Jan Schlicht <ja...@mesosphere.io> on 2017/02/16 09:35:21 UTC, 7 replies.
- Review Request 56742: Updated CHANGELOG for Mesos 1.2.0 release. - posted by Adam B <ad...@mesosphere.io> on 2017/02/16 09:49:13 UTC, 13 replies.
- Review Request 56753: Implemented the JWT authenticator. - posted by Jan Schlicht <ja...@mesosphere.io> on 2017/02/16 14:07:03 UTC, 8 replies.
- Review Request 56754: Implemented a JWT secret generator. - posted by Jan Schlicht <ja...@mesosphere.io> on 2017/02/16 14:11:51 UTC, 4 replies.
- Review Request 56757: Added the SecretGenerator module interface. - posted by Jan Schlicht <ja...@mesosphere.io> on 2017/02/16 14:53:50 UTC, 2 replies.
- Review Request 56413: WIP Support pausing/resuming health checks. - posted by Gastón Kleiman <ga...@mesosphere.io> on 2017/02/16 15:37:41 UTC, 3 replies.
- Review Request 56778: Fixed a bug around executor not able to use reserved resources. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/17 05:23:34 UTC, 6 replies.
- Review Request 56781: Fixed compilation on VS 2017. - posted by Michael Park <mp...@apache.org> on 2017/02/17 08:12:13 UTC, 3 replies.
- Re: Review Request 55576: Fixes FutureTest.After3 flakiness. - posted by Alexander Rojas <al...@mesosphere.io> on 2017/02/17 09:51:20 UTC, 4 replies.
- Re: Review Request 50974: Documented all the API calls for Operator HTTP API. - posted by Vinod Kone <vi...@gmail.com> on 2017/02/17 20:17:06 UTC, 0 replies.
- Review Request 56804: Cleaned up weights handling code. - posted by Neil Conway <ne...@gmail.com> on 2017/02/18 00:14:01 UTC, 1 replies.
- Review Request 56805: Simplified interface for setting weights in allocator. - posted by Neil Conway <ne...@gmail.com> on 2017/02/18 00:14:18 UTC, 2 replies.
- Review Request 56806: Fixed some clang-tidy warnings. - posted by Neil Conway <ne...@gmail.com> on 2017/02/18 00:18:07 UTC, 4 replies.
- Review Request 56808: Fixed nested container agent flapping issue after reboot. - posted by Gilbert Song <so...@gmail.com> on 2017/02/18 01:54:36 UTC, 4 replies.
- Review Request 56809: Added test for nested container machine reboot case. - posted by Gilbert Song <so...@gmail.com> on 2017/02/18 01:55:07 UTC, 7 replies.
- Re: Review Request 56238: Allowed using protobuf 3 in python bindings. - posted by Anthony Sottile <as...@yelp.com> on 2017/02/18 02:23:08 UTC, 2 replies.
- Re: Review Request 56619: Updated 'Files' handlers to use 'AuthenticationContext'. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/18 03:00:41 UTC, 5 replies.
- Review Request 56812: Updated agent handlers to use 'AuthenticationContext'. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/18 03:02:32 UTC, 7 replies.
- Review Request 56813: Updated master handlers to use 'AuthenticationContext'. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/18 03:03:55 UTC, 10 replies.
- Re: Review Request 56195: Fixed ContainerLogger / IOSwitchboard FD leaks. - posted by Kevin Klues <kl...@gmail.com> on 2017/02/18 18:39:44 UTC, 11 replies.
- Review Request 56814: Wrapped IOSwitchboard.connect() in a dispatch. - posted by Kevin Klues <kl...@gmail.com> on 2017/02/18 18:40:36 UTC, 3 replies.
- Review Request 56837: Added slave capabilities to HierarchicalAllocatorProcess. - posted by Jay Guo <gu...@gmail.com> on 2017/02/20 04:46:50 UTC, 3 replies.
- Re: Review Request 56530: Prevent resource of old agents being allocated to MULTI_ROLE frameworks. - posted by Jay Guo <gu...@gmail.com> on 2017/02/20 04:46:56 UTC, 10 replies.
- Review Request 56830: Introduced `TaskInfo::OnTerminationPolicy` protobuf. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/20 05:00:30 UTC, 5 replies.
- Review Request 56831: Minor fix to a comment. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/20 05:00:42 UTC, 1 replies.
- Review Request 56832: Added output operator for `OnTerminationPolicy` enum. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/20 05:00:55 UTC, 1 replies.
- Review Request 56833: Added validation for on termination policy to the master. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/20 05:01:10 UTC, 1 replies.
- Review Request 56834: Send a TASK_ERROR update if a task specifies `OnTerminationPolicy`. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/20 05:01:23 UTC, 2 replies.
- Review Request 56835: Made the default executor handle on termination policy for a task. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/20 05:01:38 UTC, 0 replies.
- Review Request 56836: Added test for a task specifying on termination policy. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/20 05:01:49 UTC, 1 replies.
- Re: Review Request 56644: Added a constant to store agent capabilities. - posted by Jay Guo <gu...@gmail.com> on 2017/02/20 07:18:53 UTC, 1 replies.
- Review Request 56847: Remove unecessary leveldb build rule. - posted by Tomasz Janiszewski <ja...@gmail.com> on 2017/02/20 11:00:26 UTC, 3 replies.
- Review Request 56851: Updated OCI protobuf messages with latest OCI image spec. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/20 12:53:38 UTC, 1 replies.
- Review Request 56852: Updated OCI spec parsing & validation code with latest OCI image spec. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/20 12:57:49 UTC, 1 replies.
- Review Request 56853: Update OCI tests with the latest OCI image spec. - posted by Qian Zhang <zh...@gmail.com> on 2017/02/20 12:59:09 UTC, 3 replies.
- Re: Review Request 56847: Removed unnecessary leveldb build rules. - posted by Tomasz Janiszewski <ja...@gmail.com> on 2017/02/20 16:33:33 UTC, 3 replies.
- Review Request 56867: WIP: Added upgrade guide for 1.2.x. - posted by Adam B <ad...@mesosphere.io> on 2017/02/21 07:57:08 UTC, 5 replies.
- Review Request 56889: Added setting volume mode and ownership in LinuxFilesystemIsolator. - posted by Ilya Pronin <ip...@twopensource.com> on 2017/02/21 15:42:06 UTC, 3 replies.
- Review Request 56771: Added regression test against fetcher SSL spillover. - posted by Till Toenshoff <to...@me.com> on 2017/02/21 15:56:20 UTC, 6 replies.
- Review Request 56895: Allow agents to recover slave state post a reboot. - posted by Megha Sharma <ms...@apple.com> on 2017/02/21 18:33:30 UTC, 4 replies.
- Review Request 56904: Documented provisioner auto backend semantic. - posted by Gilbert Song <so...@gmail.com> on 2017/02/21 23:28:54 UTC, 6 replies.
- Review Request 56906: WIP: Dealt with a corner case in the ReadFile API. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/02/22 00:20:04 UTC, 0 replies.
- Review Request 56901: Updated master validation code to use 'AuthenticationContext'. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/22 01:20:36 UTC, 5 replies.
- Review Request 56941: Add a test for a MULTI_ROLE master re-registering an old agent. - posted by Jay Guo <gu...@gmail.com> on 2017/02/22 17:43:08 UTC, 7 replies.
- Review Request 56939: Validate that Resource.allocation_info.roles are not mixed. - posted by Jay Guo <gu...@gmail.com> on 2017/02/22 17:43:51 UTC, 1 replies.
- Review Request 56938: Added allocation role to tasks/executors in v0 /state API. - posted by Jay Guo <gu...@gmail.com> on 2017/02/22 17:49:44 UTC, 3 replies.
- Re: Review Request 56830: Introduced `TaskInfo::TerminationPolicy` protobuf. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/22 18:16:45 UTC, 1 replies.
- Re: Review Request 56831: Minor fix to a comment + docs. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/22 18:16:55 UTC, 1 replies.
- Re: Review Request 56832: Added output operator for `TerminationPolicy::Type` enum. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/22 18:17:10 UTC, 0 replies.
- Re: Review Request 56833: Added validation for termination policy to the master. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/22 18:17:17 UTC, 0 replies.
- Re: Review Request 56834: Send a TASK_ERROR update if a task specifies `TerminationPolicy`. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/22 18:17:50 UTC, 1 replies.
- Re: Review Request 56835: Made the default executor handle termination policy for a task. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/22 18:18:11 UTC, 0 replies.
- Review Request 56937: Renamed `killingTaskGroup` to `killingGroup` on the default executor. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/22 18:18:26 UTC, 0 replies.
- Re: Review Request 56836: Added test for a task specifying termination policy. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/22 18:18:40 UTC, 0 replies.
- Review Request 56945: Removed inconsistent use of override. - posted by Benjamin Bannier <be...@mesosphere.io> on 2017/02/22 18:50:39 UTC, 4 replies.
- Re: Review Request 56809: Added test for nested container agent reboot case. - posted by Gilbert Song <so...@gmail.com> on 2017/02/22 19:17:05 UTC, 4 replies.
- Re: Review Request 56830: [WIP] Introduced `TaskInfo::TerminationPolicy` protobuf. - posted by Anand Mazumdar <an...@apache.org> on 2017/02/23 00:09:15 UTC, 0 replies.
- Review Request 56962: Windows: Undefined `ACL` macro defined in Zookeeper headers. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/02/23 01:24:01 UTC, 3 replies.
- Review Request 56967: Exposed agent capabilities via SlaveInfo::Capability directly. - posted by Jay Guo <gu...@gmail.com> on 2017/02/23 04:29:52 UTC, 1 replies.
- Re: Review Request 56837: Added agent capabilities to HierarchicalAllocatorProcess. - posted by Jay Guo <gu...@gmail.com> on 2017/02/23 04:31:12 UTC, 2 replies.
- Re: Review Request 56527: Disallowed some special path components in IDs. - posted by Jiang Yan Xu <ya...@jxu.me> on 2017/02/23 19:30:26 UTC, 1 replies.
- Review Request 57005: Updated configuration.md for --http_heartbeat_interval. - posted by Adam B <ad...@mesosphere.io> on 2017/02/23 23:52:48 UTC, 1 replies.
- Re: Review Request 56867: Added upgrade guide for 1.2.x. - posted by Adam B <ad...@mesosphere.io> on 2017/02/24 00:31:55 UTC, 3 replies.
- Review Request 57010: Added protobuf changes for `SHARE` and `UNSHARE` offer operations. - posted by Anindya Sinha <an...@apple.com> on 2017/02/24 01:15:13 UTC, 1 replies.
- Review Request 57011: Add support for SHARE and UNSHARE operations. - posted by Anindya Sinha <an...@apple.com> on 2017/02/24 01:15:13 UTC, 1 replies.
- Review Request 57012: Added unit tests for SHARE and UNSHARE offer operations. - posted by Anindya Sinha <an...@apple.com> on 2017/02/24 01:15:16 UTC, 2 replies.
- Review Request 57013: Expose offer allocation info within the master /state endpoint. - posted by Benjamin Mahler <bm...@apache.org> on 2017/02/24 01:27:08 UTC, 1 replies.
- Review Request 57014: Renamed 'Headers' class templete method to 'get()'. - posted by Gilbert Song <so...@gmail.com> on 2017/02/24 01:57:30 UTC, 0 replies.
- Review Request 57016: Updated docker fetcher pluggin corresponding to the former commit. - posted by Gilbert Song <so...@gmail.com> on 2017/02/24 01:57:59 UTC, 0 replies.
- Review Request 57021: Added agent capabilities to `updateSlave` method. - posted by Jay Guo <gu...@gmail.com> on 2017/02/24 08:50:12 UTC, 1 replies.
- Review Request 57023: Added a test to ensure agent could be upgrade to MULTI_ROLE capable. - posted by Jay Guo <gu...@gmail.com> on 2017/02/24 08:51:09 UTC, 2 replies.
- Re: Review Request 56939: Added allocation role validation for ExecutorInfo. - posted by Jay Guo <gu...@gmail.com> on 2017/02/24 10:48:04 UTC, 3 replies.
- Review Request 57030: Added allocation role validation for TaskInfo. - posted by Jay Guo <gu...@gmail.com> on 2017/02/24 10:52:47 UTC, 1 replies.
- Review Request 57031: Added allocation role validation for Reserve operation. - posted by Jay Guo <gu...@gmail.com> on 2017/02/24 10:53:15 UTC, 1 replies.
- Review Request 57032: Added allocation role validation for Create operation. - posted by Jay Guo <gu...@gmail.com> on 2017/02/24 10:53:40 UTC, 3 replies.
- Review Request 57054: Fixed a bug in master and agent handler authorization logic. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/24 23:06:05 UTC, 3 replies.
- Review Request 57052: CMake: Add `config.hpp.in` for `BUILD_TIME` variables. - posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/02/25 00:31:38 UTC, 3 replies.
- Review Request 57058: Updated default executor tests to exclusively use v1 protos. - posted by Vinod Kone <vi...@gmail.com> on 2017/02/25 02:01:26 UTC, 1 replies.
- Review Request 57059: Updated default executor tests. - posted by Vinod Kone <vi...@gmail.com> on 2017/02/25 02:02:10 UTC, 2 replies.
- Re: Review Request 48291: Use varint comparator in replica log. - posted by Tomasz Janiszewski <ja...@gmail.com> on 2017/02/26 05:12:30 UTC, 1 replies.
- Review Request 57093: Clears timedout timers before marking the clock as settle. - posted by Alexander Rojas <al...@mesosphere.io> on 2017/02/27 14:28:13 UTC, 1 replies.
- Re: Review Request 55576: Speeds up FutureTest.After3 using clock manipulation utilities. - posted by Alexander Rojas <al...@mesosphere.io> on 2017/02/27 14:35:45 UTC, 2 replies.
- Re: Review Request 55790: Support the full CNI DNS specification. - posted by Avinash sridharan <av...@mesosphere.io> on 2017/02/27 17:18:20 UTC, 0 replies.
- Re: Review Request 53369: Agent cgroup assignment should precede agent initialization. - posted by Anindya Sinha <an...@apple.com> on 2017/02/27 17:47:34 UTC, 1 replies.
- Re: Review Request 53839: Added a metric in the master to track sending of previous offer. - posted by Anindya Sinha <an...@apple.com> on 2017/02/27 20:18:03 UTC, 0 replies.
- Re: Review Request 53840: Added a metric in the allocator to track previous allocation cycle. - posted by Anindya Sinha <an...@apple.com> on 2017/02/27 20:18:05 UTC, 0 replies.
- Re: Review Request 53841: Added metrics for sorting of the sorters in the allocator. - posted by Anindya Sinha <an...@apple.com> on 2017/02/27 20:18:08 UTC, 0 replies.
- Re: Review Request 53842: Add role specific metrics for sorting runs. - posted by Anindya Sinha <an...@apple.com> on 2017/02/27 20:18:10 UTC, 1 replies.
- Review Request 57104: Updated a few functions in the agent to be declared `const`. - posted by Michael Park <mp...@apache.org> on 2017/02/27 21:57:43 UTC, 1 replies.
- Review Request 57105: Updated a few functions in the master to be declared `const`. - posted by Michael Park <mp...@apache.org> on 2017/02/27 21:57:45 UTC, 1 replies.
- Review Request 57106: Added `FrameworkInfo` to `UpdateFrameworkMessage`. - posted by Michael Park <mp...@apache.org> on 2017/02/27 22:11:15 UTC, 3 replies.
- Review Request 57108: Handled the `FrameworkInfo` field added to the `UpdateFrameworkMessage`. - posted by Michael Park <mp...@apache.org> on 2017/02/27 22:12:57 UTC, 2 replies.
- Re: Review Request 53264: Added test for CNI port-mapper plugin. - posted by Avinash sridharan <av...@mesosphere.io> on 2017/02/27 22:13:17 UTC, 1 replies.
- Review Request 57109: Re-checkpointed the `Executor`s and `Task`s during agent recovery. - posted by Michael Park <mp...@apache.org> on 2017/02/27 22:18:53 UTC, 1 replies.
- Review Request 57110: Updated the master to handle frameworks that changes its roles. - posted by Michael Park <mp...@apache.org> on 2017/02/27 22:19:52 UTC, 1 replies.
- Review Request 57111: Updated the allocator to handle frameworks that change its roles. - posted by Michael Park <mp...@apache.org> on 2017/02/27 22:20:36 UTC, 1 replies.
- Review Request 57112: Updated existing test cases to allow for frameworks to change its roles. - posted by Michael Park <mp...@apache.org> on 2017/02/27 22:20:39 UTC, 1 replies.
- Re: Review Request 56906: Dealt with a corner case in the ReadFile API. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/02/28 00:46:35 UTC, 1 replies.
- Review Request 57117: Added nested container launch/wait/kill APIs to agent API docs. - posted by Kevin Klues <kl...@gmail.com> on 2017/02/28 01:35:03 UTC, 3 replies.
- Review Request 57118: Added debugging APIs to agent API docs. - posted by Kevin Klues <kl...@gmail.com> on 2017/02/28 01:35:06 UTC, 4 replies.
- Review Request 57121: Renamed 'ContainerLogger::SubprocessInfo' to 'ContainerIO'. - posted by Kevin Klues <kl...@gmail.com> on 2017/02/28 05:09:44 UTC, 1 replies.
- Review Request 57122: Added STDIN IO to 'ContainerLogger::ContainerIO' class. - posted by Kevin Klues <kl...@gmail.com> on 2017/02/28 05:09:45 UTC, 1 replies.
- Re: Review Request 56617: Updated libprocess handlers to use the 'Principal' type. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/28 06:21:04 UTC, 0 replies.
- Re: Review Request 56901: Updated master validation code to use the 'Principal' type. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/28 06:30:51 UTC, 0 replies.
- Re: Review Request 56618: Updated common Mesos code to use the 'Principal' type. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/28 06:31:24 UTC, 0 replies.
- Re: Review Request 56619: Updated 'Files' handlers to use the 'Principal' type. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/28 06:34:56 UTC, 1 replies.
- Re: Review Request 56812: Updated agent handlers to use the 'Principal' type. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/28 06:37:04 UTC, 3 replies.
- Re: Review Request 56624: Updated libprocess tests to use the 'Principal' type. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/28 06:59:28 UTC, 1 replies.
- Re: Review Request 56621: Updated Mesos tests to use the 'Principal' type. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/28 07:07:37 UTC, 1 replies.
- Re: Review Request 55576: Fixes `FutureTest.After3` flakiness. - posted by Alexander Rojas <al...@mesosphere.io> on 2017/02/28 10:09:08 UTC, 0 replies.
- Re: Review Request 56016: Added a note about task status updates in scheduler and internal API. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/28 15:46:04 UTC, 0 replies.
- Re: Review Request 56017: Added a helper for building a task status from an existing one. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/28 15:48:23 UTC, 0 replies.
- Review Request 57149: Added a warning if command executor gets an unknown acknowledgement. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/28 15:51:15 UTC, 0 replies.
- Re: Review Request 56210: Reused previous task status for health updates in command executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/28 15:52:19 UTC, 0 replies.
- Review Request 57150: Simplified task id procurement in command executor. - posted by Alexander Rukletsov <ru...@gmail.com> on 2017/02/28 15:56:22 UTC, 0 replies.
- Review Request 57132: Updated WebUI to display roles. - posted by Jay Guo <gu...@gmail.com> on 2017/02/28 17:25:06 UTC, 1 replies.
- Re: Review Request 56623: Implemented the 'Principal' type in libprocess. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/28 18:28:48 UTC, 1 replies.
- Review Request 57153: Removed unnecessary 'using' statement in master HTTP code. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/28 18:31:52 UTC, 0 replies.
- Re: Review Request 56813: Updated master handlers to use the 'Principal' type. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/28 18:34:45 UTC, 3 replies.
- Review Request 57157: Cleaned up `using` statements. - posted by Neil Conway <ne...@gmail.com> on 2017/02/28 19:14:02 UTC, 2 replies.
- Review Request 57158: Added default parameter value to master validation function. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/28 19:28:40 UTC, 0 replies.
- Review Request 57160: Added 'override' to function declarations in 'LibeventSSLSocketImpl'. - posted by Greg Mann <gr...@mesosphere.io> on 2017/02/28 19:55:33 UTC, 5 replies.
- Review Request 57161: Cleaned up header includes. - posted by Neil Conway <ne...@gmail.com> on 2017/02/28 20:07:27 UTC, 0 replies.
- Review Request 57162: Minor cleanup for slave tests. - posted by Neil Conway <ne...@gmail.com> on 2017/02/28 20:14:08 UTC, 0 replies.
- Review Request 57163: Cleaned up sorter test cases. - posted by Neil Conway <ne...@gmail.com> on 2017/02/28 20:17:39 UTC, 0 replies.
- Review Request 57164: Cleaned up header includes. - posted by Neil Conway <ne...@gmail.com> on 2017/02/28 20:18:04 UTC, 0 replies.
- Review Request 57165: Minor cleanup for quota validation code. - posted by Neil Conway <ne...@gmail.com> on 2017/02/28 20:18:16 UTC, 0 replies.
- Review Request 57166: Updated role validation for hierarchical roles. - posted by Neil Conway <ne...@gmail.com> on 2017/02/28 20:23:07 UTC, 0 replies.
- Review Request 57167: Updated quota handler logic for hierarchical roles. - posted by Neil Conway <ne...@gmail.com> on 2017/02/28 20:23:24 UTC, 0 replies.
- Re: Review Request 55686: Added custom target for 'make distcheck'. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/02/28 21:39:04 UTC, 0 replies.
- Re: Review Request 55657: Added cpack to create source package. - posted by Joseph Wu <jo...@mesosphere.io> on 2017/02/28 22:28:54 UTC, 0 replies.
- Re: Review Request 53666: Refactor cgroups cleanup to allow cleanup to continue on an error. - posted by Anindya Sinha <an...@apple.com> on 2017/02/28 23:16:42 UTC, 0 replies.