You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/02/18 00:14:01 UTC
Review Request 56804: Cleaned up weights handling code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56804/
-----------------------------------------------------------
Review request for mesos, Adam B and Yongqiao Wang.
Repository: mesos
Description
-------
Removed a redundant statement, fixed log message style, cleaned up
comments.
Diffs
-----
src/master/master.cpp 5534674fa2740b0a6e37fc1df34b582f1e691133
src/master/weights_handler.cpp da0b995e1866e7eb57b8ef885864c6c6d66405d6
src/tests/dynamic_weights_tests.cpp ce577ce6c71bbfffba7db7c72523a9fd2d68141b
Diff: https://reviews.apache.org/r/56804/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 56804: Cleaned up weights handling code.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56804/#review166122
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Feb. 17, 2017, 4:14 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56804/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2017, 4:14 p.m.)
>
>
> Review request for mesos, Adam B and Yongqiao Wang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed a redundant statement, fixed log message style, cleaned up
> comments.
>
>
> Diffs
> -----
>
> src/master/master.cpp 5534674fa2740b0a6e37fc1df34b582f1e691133
> src/master/weights_handler.cpp da0b995e1866e7eb57b8ef885864c6c6d66405d6
> src/tests/dynamic_weights_tests.cpp ce577ce6c71bbfffba7db7c72523a9fd2d68141b
>
> Diff: https://reviews.apache.org/r/56804/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>