You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2017/02/25 02:01:26 UTC
Review Request 57058: Updated default executor tests to exclusively
use v1 protos.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57058/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Gilbert Song.
Repository: mesos
Description
-------
Now all the tests in this file use v1 protos.
Diffs
-----
src/tests/default_executor_tests.cpp eaf639467aaaa35b28b21bfb7e16aca5924a5a82
Diff: https://reviews.apache.org/r/57058/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 57058: Updated default executor tests to
exclusively use v1 protos.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57058/#review168215
-----------------------------------------------------------
Ship it!
src/tests/default_executor_tests.cpp
Lines 215-217 (original), 215-217 (patched)
<https://reviews.apache.org/r/57058/#comment240412>
Seems like these are the `devolve`s that we cannot avoid. :(
- Gilbert Song
On March 6, 2017, 5:15 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57058/
> -----------------------------------------------------------
>
> (Updated March 6, 2017, 5:15 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Now all the tests in this file use v1 protos.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp e4d43c8ad447577a9c5c7951207596bda1070856
>
>
> Diff: https://reviews.apache.org/r/57058/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 57058: Updated default executor tests to
exclusively use v1 protos.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57058/
-----------------------------------------------------------
(Updated March 7, 2017, 1:15 a.m.)
Review request for mesos, Anand Mazumdar and Gilbert Song.
Changes
-------
anand's. NNFR.
Repository: mesos
Description
-------
Now all the tests in this file use v1 protos.
Diffs (updated)
-----
src/tests/default_executor_tests.cpp e4d43c8ad447577a9c5c7951207596bda1070856
Diff: https://reviews.apache.org/r/57058/diff/2/
Changes: https://reviews.apache.org/r/57058/diff/1-2/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 57058: Updated default executor tests to
exclusively use v1 protos.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57058/#review166799
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/default_executor_tests.cpp (line 620)
<https://reviews.apache.org/r/57058/#comment238872>
Nit: Would fit in one line?
src/tests/default_executor_tests.cpp (line 1038)
<https://reviews.apache.org/r/57058/#comment238873>
Nit: Would fit in one line?
src/tests/default_executor_tests.cpp (line 1189)
<https://reviews.apache.org/r/57058/#comment238874>
Nit: Would fit in one line?
- Anand Mazumdar
On Feb. 25, 2017, 2:01 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57058/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2017, 2:01 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Now all the tests in this file use v1 protos.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp eaf639467aaaa35b28b21bfb7e16aca5924a5a82
>
> Diff: https://reviews.apache.org/r/57058/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>