You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2017/02/28 01:35:06 UTC

Review Request 57118: Added debugging APIs to agent API docs.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57118/
-----------------------------------------------------------

Review request for mesos, Adam B and Vinod Kone.


Bugs: MESOS-7188
    https://issues.apache.org/jira/browse/MESOS-7188


Repository: mesos


Description
-------

Added debugging APIs to agent API docs.


Diffs
-----

  docs/operator-http-api.md 94a5477af60de0f9e8e79366fe93adb5299e470c 

Diff: https://reviews.apache.org/r/57118/diff/


Testing
-------


Thanks,

Kevin Klues

Re: Review Request 57118: Added debugging APIs to agent API docs.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57118/#review167038
-----------------------------------------------------------



Patch looks great!

Reviews applied: [57117, 57118]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 28, 2017, 1:35 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57118/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 1:35 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-7188
>     https://issues.apache.org/jira/browse/MESOS-7188
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added debugging APIs to agent API docs.
> 
> 
> Diffs
> -----
> 
>   docs/operator-http-api.md 94a5477af60de0f9e8e79366fe93adb5299e470c 
> 
> Diff: https://reviews.apache.org/r/57118/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 57118: Added debugging APIs to agent API docs.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57118/#review167106
-----------------------------------------------------------


Fix it, then Ship it!





docs/operator-http-api.md (line 3429)
<https://reviews.apache.org/r/57118/#comment239235>

    s/STDOUT/STDERR/ maybe?



docs/operator-http-api.md (line 3570)
<https://reviews.apache.org/r/57118/#comment239239>

    s/STDOUT/STDERR/ maybe?


- Vinod Kone


On Feb. 28, 2017, 1:35 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57118/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 1:35 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-7188
>     https://issues.apache.org/jira/browse/MESOS-7188
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added debugging APIs to agent API docs.
> 
> 
> Diffs
> -----
> 
>   docs/operator-http-api.md 94a5477af60de0f9e8e79366fe93adb5299e470c 
> 
> Diff: https://reviews.apache.org/r/57118/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 57118: Added debugging APIs to agent API docs.

Posted by Kevin Klues <kl...@gmail.com>.


> On Feb. 28, 2017, 11:34 a.m., Gast�n Kleiman wrote:
> > docs/operator-http-api.md, line 3441
> > <https://reviews.apache.org/r/57118/diff/1/?file=1650907#file1650907line3441>
> >
> >     Not a native English speaker, but isn't "i.e." usually followed by a comma?

I tend to follow the rule where I put a comma after it if it's part of the sentence itself, but not if it's part of a paranthetical (i.e. something enclosed in parantheses). Apparently, the rules are a bit iffy anyway though: https://jakubmarian.com/comma-after-i-e-and-e-g/


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57118/#review167045
-----------------------------------------------------------


On Feb. 28, 2017, 1:35 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57118/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 1:35 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-7188
>     https://issues.apache.org/jira/browse/MESOS-7188
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added debugging APIs to agent API docs.
> 
> 
> Diffs
> -----
> 
>   docs/operator-http-api.md 94a5477af60de0f9e8e79366fe93adb5299e470c 
> 
> Diff: https://reviews.apache.org/r/57118/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 57118: Added debugging APIs to agent API docs.

Posted by Gastón Kleiman <ga...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57118/#review167045
-----------------------------------------------------------


Ship it!





docs/operator-http-api.md (line 3441)
<https://reviews.apache.org/r/57118/#comment239176>

    Not a native English speaker, but isn't "i.e." usually followed by a comma?


- Gast�n Kleiman


On Feb. 28, 2017, 1:35 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57118/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 1:35 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-7188
>     https://issues.apache.org/jira/browse/MESOS-7188
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added debugging APIs to agent API docs.
> 
> 
> Diffs
> -----
> 
>   docs/operator-http-api.md 94a5477af60de0f9e8e79366fe93adb5299e470c 
> 
> Diff: https://reviews.apache.org/r/57118/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>