You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/02/01 22:45:29 UTC
Re: Review Request 53096: Fix handling in shared count in total
resources in the sorter.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53096/
-----------------------------------------------------------
(Updated Feb. 1, 2017, 10:45 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Rebased after batch allocation patch was merged.
Bugs: MESOS-6444
https://issues.apache.org/jira/browse/MESOS-6444
Repository: mesos
Description
-------
We maintain a single copy of shared resource in the role and quota
sorter's total resources. So, when we update these resources, we
remove the previous resources at this agent and add the new resources
at this agent.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 339b3d2bada526fd66d812df30e9615a96883769
src/master/allocator/mesos/hierarchical.cpp ffa07087f9ed8d28b99cc4cde7c739cfd7edb1e1
src/tests/persistent_volume_tests.cpp 468a85b4a6ce09592341afd07ce12a03f5fc4f73
Diff: https://reviews.apache.org/r/53096/diff/
Testing
-------
Tests passed.
Thanks,
Anindya Sinha
Re: Review Request 53096: Fix handling in shared count in total
resources in the sorter.
Posted by Jiang Yan Xu <xu...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53096/#review164180
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (line 2056)
<https://reviews.apache.org/r/53096/#comment235803>
Did
s/slaves[slaveId].total/slave.total/
when committing.
- Jiang Yan Xu
On Feb. 3, 2017, 2:01 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53096/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2017, 2:01 p.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-6444
> https://issues.apache.org/jira/browse/MESOS-6444
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We maintain a single copy of shared resource in the role and quota
> sorter's total resources. So, when we update these resources, we
> remove the previous resources at this agent and add the new resources
> at this agent.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp a99ed35169c0a4a1db3ac3b9b09f510f8fcddbfb
> src/master/allocator/mesos/hierarchical.cpp 5f540569043df9d2bb75416c8c36bb4dd7bd68a1
> src/tests/persistent_volume_tests.cpp 468a85b4a6ce09592341afd07ce12a03f5fc4f73
>
> Diff: https://reviews.apache.org/r/53096/diff/
>
>
> Testing
> -------
>
> Tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 53096: Fix handling in shared count in total
resources in the sorter.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53096/
-----------------------------------------------------------
(Updated Feb. 3, 2017, 10:01 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Refactor.
Bugs: MESOS-6444
https://issues.apache.org/jira/browse/MESOS-6444
Repository: mesos
Description
-------
We maintain a single copy of shared resource in the role and quota
sorter's total resources. So, when we update these resources, we
remove the previous resources at this agent and add the new resources
at this agent.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp a99ed35169c0a4a1db3ac3b9b09f510f8fcddbfb
src/master/allocator/mesos/hierarchical.cpp 5f540569043df9d2bb75416c8c36bb4dd7bd68a1
src/tests/persistent_volume_tests.cpp 468a85b4a6ce09592341afd07ce12a03f5fc4f73
Diff: https://reviews.apache.org/r/53096/diff/
Testing
-------
Tests passed.
Thanks,
Anindya Sinha