You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/02/03 04:45:49 UTC
Review Request 56268: Made `kill()` not invoke `shutdown()` in the
default executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56268/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-6296
https://issues.apache.org/jira/browse/MESOS-6296
Repository: mesos
Description
-------
This ensures that when we add support for the default executor
launch multiple task groups, kill for a particular task should
_only_ result in the killing of a task group and not the entire
executor as was the case currently.
Diffs
-----
src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
src/tests/default_executor_tests.cpp e8e0aa2f0d2508de6db03685c70d1ed9c1da3659
Diff: https://reviews.apache.org/r/56268/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 56268: Made `kill()` not invoke `shutdown()` in the
default executor.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56268/#review164421
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 4, 2017, 5:52 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56268/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2017, 5:52 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6296
> https://issues.apache.org/jira/browse/MESOS-6296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This ensures that when we add support for the default executor
> launch multiple task groups, kill for a particular task should
> _only_ result in the killing of a task group and not the entire
> executor as was the case currently.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
> src/tests/default_executor_tests.cpp e8e0aa2f0d2508de6db03685c70d1ed9c1da3659
>
> Diff: https://reviews.apache.org/r/56268/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 56268: Made `kill()` not invoke `shutdown()` in the
default executor.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56268/
-----------------------------------------------------------
(Updated Feb. 4, 2017, 5:52 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comments.
Bugs: MESOS-6296
https://issues.apache.org/jira/browse/MESOS-6296
Repository: mesos
Description
-------
This ensures that when we add support for the default executor
launch multiple task groups, kill for a particular task should
_only_ result in the killing of a task group and not the entire
executor as was the case currently.
Diffs (updated)
-----
src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
src/tests/default_executor_tests.cpp e8e0aa2f0d2508de6db03685c70d1ed9c1da3659
Diff: https://reviews.apache.org/r/56268/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 56268: Made `kill()` not invoke `shutdown()` in the
default executor.
Posted by Anand Mazumdar <an...@apache.org>.
> On Feb. 3, 2017, 10:32 p.m., Vinod Kone wrote:
> > src/launcher/default_executor.cpp, lines 674-677
> > <https://reviews.apache.org/r/56268/diff/1/?file=1622926#file1622926line674>
> >
> > not new in this patch chain, but:
> >
> > do we care about non-zero exit code if the task was killed by the framework? the `taskState == TASK_KILLED` suggests that we don't (which is reasonable) but the code above in #637 ignores kill intent if exit status is zero ?
hmm, this code looks copy-pasted from the command executor. Might be an issue there too and would clean them together.
Marking the issue as fixed for now.
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56268/#review164178
-----------------------------------------------------------
On Feb. 4, 2017, 5:52 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56268/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2017, 5:52 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6296
> https://issues.apache.org/jira/browse/MESOS-6296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This ensures that when we add support for the default executor
> launch multiple task groups, kill for a particular task should
> _only_ result in the killing of a task group and not the entire
> executor as was the case currently.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
> src/tests/default_executor_tests.cpp e8e0aa2f0d2508de6db03685c70d1ed9c1da3659
>
> Diff: https://reviews.apache.org/r/56268/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 56268: Made `kill()` not invoke `shutdown()` in the
default executor.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56268/#review164178
-----------------------------------------------------------
src/launcher/default_executor.cpp (lines 674 - 677)
<https://reviews.apache.org/r/56268/#comment235795>
not new in this patch chain, but:
do we care about non-zero exit code if the task was killed by the framework? the `taskState == TASK_KILLED` suggests that we don't (which is reasonable) but the code above in #637 ignores kill intent if exit status is zero ?
src/launcher/default_executor.cpp (lines 720 - 729)
<https://reviews.apache.org/r/56268/#comment235800>
I would rename
s/killing/kill/
and
s/killed/killing/
see below.
src/launcher/default_executor.cpp (line 820)
<https://reviews.apache.org/r/56268/#comment235798>
s/it has already been killed/it is in the process of getting killed/
src/launcher/default_executor.cpp (line 1022)
<https://reviews.apache.org/r/56268/#comment235797>
s/killed/killing/ sounds more appropriate.
- Vinod Kone
On Feb. 3, 2017, 4:45 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56268/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2017, 4:45 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6296
> https://issues.apache.org/jira/browse/MESOS-6296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This ensures that when we add support for the default executor
> launch multiple task groups, kill for a particular task should
> _only_ result in the killing of a task group and not the entire
> executor as was the case currently.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
> src/tests/default_executor_tests.cpp e8e0aa2f0d2508de6db03685c70d1ed9c1da3659
>
> Diff: https://reviews.apache.org/r/56268/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>