You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/02/15 23:24:19 UTC
Review Request 56731: Fix perf-stat parsing for recent perf releases.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56731/
-----------------------------------------------------------
Review request for mesos, Mesos Reviewbot and Jiang Yan Xu.
Bugs: MESOS-7049
https://issues.apache.org/jira/browse/MESOS-7049
Repository: mesos
Description
-------
perf-stat(1) emits additional metric aggregation and value fields since
Linux 4.6 (see kernel tree commit 92a61f6). Since these fields are not
needed for the Sample interface, it is ok to ignore them.
Diffs
-----
src/linux/perf.cpp 3141e5ee9eee78e974625791f362dc345c682ebb
src/tests/containerizer/perf_tests.cpp d536ecc5cb24787bc3487efb146573cd4f3ded43
Diff: https://reviews.apache.org/r/56731/diff/
Testing
-------
sudo make check (Fedora 25)
Thanks,
James Peach
Re: Review Request 56731: Fix perf-stat parsing for recent perf
releases.
Posted by haosdent huang <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56731/#review168233
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Feb. 15, 2017, 11:24 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56731/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 11:24 p.m.)
>
>
> Review request for mesos, Mesos Reviewbot and Jiang Yan Xu.
>
>
> Bugs: MESOS-7049
> https://issues.apache.org/jira/browse/MESOS-7049
>
>
> Repository: mesos
>
>
> Description
> -------
>
> perf-stat(1) emits additional metric aggregation and value fields since
> Linux 4.6 (see kernel tree commit 92a61f6). Since these fields are not
> needed for the Sample interface, it is ok to ignore them.
>
>
> Diffs
> -----
>
> src/linux/perf.cpp 3141e5ee9eee78e974625791f362dc345c682ebb
> src/tests/containerizer/perf_tests.cpp d536ecc5cb24787bc3487efb146573cd4f3ded43
>
>
> Diff: https://reviews.apache.org/r/56731/diff/1/
>
>
> Testing
> -------
>
> sudo make check (Fedora 25)
>
>
> Thanks,
>
> James Peach
>
>