You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/02/27 22:20:39 UTC
Review Request 57112: Updated existing test cases to allow for
frameworks to change its roles.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57112/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-6627
https://issues.apache.org/jira/browse/MESOS-6627
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/master_validation_tests.cpp 5a84c8d03cacd150ac61213a7c2d8613fd1780e7
Diff: https://reviews.apache.org/r/57112/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 57112: Updated existing test cases to allow for
frameworks to change its roles.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57112/#review167923
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/master_validation_tests.cpp
Lines 3519-3521 (original), 3519-3521 (patched)
<https://reviews.apache.org/r/57112/#comment239913>
This needs updating as well.
src/tests/master_validation_tests.cpp
Lines 3710-3713 (original), 3705-3708 (patched)
<https://reviews.apache.org/r/57112/#comment239914>
This needs to be updated as well.
- Benjamin Mahler
On Feb. 27, 2017, 10:20 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57112/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2017, 10:20 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6627
> https://issues.apache.org/jira/browse/MESOS-6627
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 5a84c8d03cacd150ac61213a7c2d8613fd1780e7
>
>
> Diff: https://reviews.apache.org/r/57112/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 57112: Updated existing test cases to allow for
frameworks to change its roles.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57112/#review167974
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57319, 57329, 57330, 57331, 57110, 57111, 57112]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 6, 2017, 12:01 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57112/
> -----------------------------------------------------------
>
> (Updated March 6, 2017, 12:01 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6627
> https://issues.apache.org/jira/browse/MESOS-6627
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 5a84c8d03cacd150ac61213a7c2d8613fd1780e7
>
>
> Diff: https://reviews.apache.org/r/57112/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 57112: Updated existing test cases to allow for
frameworks to change its roles.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57112/
-----------------------------------------------------------
(Updated March 6, 2017, 4:01 a.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-6627
https://issues.apache.org/jira/browse/MESOS-6627
Repository: mesos
Description (updated)
-------
See summary.
Diffs
-----
src/tests/master_validation_tests.cpp 5a84c8d03cacd150ac61213a7c2d8613fd1780e7
Diff: https://reviews.apache.org/r/57112/diff/2/
Testing
-------
Thanks,
Michael Park
Re: Review Request 57112: Updated existing test cases to allow for
frameworks to change its roles.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57112/
-----------------------------------------------------------
(Updated March 6, 2017, 3:59 a.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Addressed bmahler's comments.
Bugs: MESOS-6627
https://issues.apache.org/jira/browse/MESOS-6627
Repository: mesos
Description (updated)
-------
Updated existing test cases to allow for frameworks to change its roles.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp 5a84c8d03cacd150ac61213a7c2d8613fd1780e7
Diff: https://reviews.apache.org/r/57112/diff/2/
Changes: https://reviews.apache.org/r/57112/diff/1-2/
Testing
-------
Thanks,
Michael Park
Re: Review Request 57112: Updated existing test cases to allow for
frameworks to change its roles.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57112/#review166982
-----------------------------------------------------------
Bad patch!
Reviews applied: [57112, 57111, 57110, 57109, 57108]
Failed command: python support/apply-reviews.py -n -r 57110
Error:
2017-02-28 01:44:33 URL:https://reviews.apache.org/r/57110/diff/raw/ [18645/18645] -> "57110.patch" [1]
error: patch failed: src/master/master.cpp:3308
error: src/master/master.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/17240/console
- Mesos Reviewbot
On Feb. 27, 2017, 10:20 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57112/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2017, 10:20 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6627
> https://issues.apache.org/jira/browse/MESOS-6627
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 5a84c8d03cacd150ac61213a7c2d8613fd1780e7
>
> Diff: https://reviews.apache.org/r/57112/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>