You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/02/28 19:28:40 UTC
Review Request 57158: Added default parameter value to master
validation function.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57158/
-----------------------------------------------------------
Review request for mesos, Alexander Rojas and Vinod Kone.
Repository: mesos
Description
-------
The master's validation function for RESERVE operations previously
did not set a default parameter value for its final optional
parameter, requiring callsites to explicitly specify `None()`. This
patch adds the default value.
Diffs
-----
src/master/http.cpp 6e5178eeea6cc6b90ae253840da22be13444b088
src/master/validation.hpp f03b3280704083be1ca074ca07c69edbb49dae19
Diff: https://reviews.apache.org/r/57158/diff/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 57158: Added default parameter value to master
validation function.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57158/#review167184
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56623, 56617, 56618, 56901, 57054, 57153, 56619, 56812, 56813, 56624, 56621, 57158]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 28, 2017, 7:28 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57158/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 7:28 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The master's validation function for RESERVE operations previously
> did not set a default parameter value for its final optional
> parameter, requiring callsites to explicitly specify `None()`. This
> patch adds the default value.
>
>
> Diffs
> -----
>
> src/master/http.cpp 6e5178eeea6cc6b90ae253840da22be13444b088
> src/master/validation.hpp f03b3280704083be1ca074ca07c69edbb49dae19
>
> Diff: https://reviews.apache.org/r/57158/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 57158: Added default parameter value to master
validation function.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57158/#review167912
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 3, 2017, 6:52 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57158/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 6:52 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The master's validation function for RESERVE operations previously
> did not set a default parameter value for its final optional
> parameter, requiring callsites to explicitly specify `None()`. This
> patch adds the default value.
>
>
> Diffs
> -----
>
> src/master/http.cpp 37b96c07f17d3e5ba96f6eade69d86ba9e039b3d
> src/master/validation.hpp 50a3e6ec6a6d44c9ad449edfbd5d2cf8540b3a73
>
>
> Diff: https://reviews.apache.org/r/57158/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 57158: Added default parameter value to master
validation function.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57158/
-----------------------------------------------------------
(Updated March 3, 2017, 6:52 p.m.)
Review request for mesos, Alexander Rojas and Vinod Kone.
Repository: mesos
Description
-------
The master's validation function for RESERVE operations previously
did not set a default parameter value for its final optional
parameter, requiring callsites to explicitly specify `None()`. This
patch adds the default value.
Diffs (updated)
-----
src/master/http.cpp 37b96c07f17d3e5ba96f6eade69d86ba9e039b3d
src/master/validation.hpp 50a3e6ec6a6d44c9ad449edfbd5d2cf8540b3a73
Diff: https://reviews.apache.org/r/57158/diff/2/
Changes: https://reviews.apache.org/r/57158/diff/1-2/
Testing
-------
`make check`
Thanks,
Greg Mann