You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Megha Sharma <ms...@apple.com> on 2017/02/21 18:33:30 UTC
Review Request 56895: Allow agents to recover slave state post a
reboot.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56895/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
With partition awareness, the agents are now allowed to re-register
after they have been marked Unreachable. The executors are anyway
terminated on the agent when it reboots so there is no harm in
letting the agent keep its SlaveID, re-register with the master
and reconcile the lost executors. This is a pre-requisite for
supporting persistent/restartable tasks in mesos.
Diffs
-----
src/slave/slave.hpp 5049eb783b8ad7b9599f20c3701f7d3d654b4491
src/slave/slave.cpp 92564ff8fff06d1cb17192d374d355b4bb7d39d8
src/slave/state.hpp a497ce1f58fb8dc7718ee5bb10bc62dd7479efa5
src/slave/state.cpp f8e7cdd4df0a3c5d62d89edd11844527084f2baa
src/tests/slave_recovery_tests.cpp 946a7bc4b78f56244633a0b2acb59381e3dbe7e7
Diff: https://reviews.apache.org/r/56895/diff/
Testing
-------
Thanks,
Megha Sharma
Re: Review Request 56895: Allow agents to recover slave state post a
reboot.
Posted by Megha Sharma <ms...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56895/
-----------------------------------------------------------
(Updated Feb. 21, 2017, 9:42 p.m.)
Review request for mesos.
Bugs: MESOS-6223
https://issues.apache.org/jira/browse/MESOS-6223
Repository: mesos
Description
-------
With partition awareness, the agents are now allowed to re-register
after they have been marked Unreachable. The executors are anyway
terminated on the agent when it reboots so there is no harm in
letting the agent keep its SlaveID, re-register with the master
and reconcile the lost executors. This is a pre-requisite for
supporting persistent/restartable tasks in mesos.
Diffs (updated)
-----
src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2
src/slave/slave.cpp 7564e8d39530794131dbbc928fcbc59fb65ef471
src/slave/state.hpp a497ce1f58fb8dc7718ee5bb10bc62dd7479efa5
src/slave/state.cpp f8e7cdd4df0a3c5d62d89edd11844527084f2baa
src/tests/slave_recovery_tests.cpp 0e295915fea0a7314e173857249bd8726eeccd76
Diff: https://reviews.apache.org/r/56895/diff/
Testing (updated)
-------
make check
Thanks,
Megha Sharma
Re: Review Request 56895: Allow agents to recover slave state post a
reboot.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56895/#review166206
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot
On Feb. 21, 2017, 6:58 p.m., Megha Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56895/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 6:58 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-6223
> https://issues.apache.org/jira/browse/MESOS-6223
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With partition awareness, the agents are now allowed to re-register
> after they have been marked Unreachable. The executors are anyway
> terminated on the agent when it reboots so there is no harm in
> letting the agent keep its SlaveID, re-register with the master
> and reconcile the lost executors. This is a pre-requisite for
> supporting persistent/restartable tasks in mesos.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 5049eb783b8ad7b9599f20c3701f7d3d654b4491
> src/slave/slave.cpp 92564ff8fff06d1cb17192d374d355b4bb7d39d8
> src/slave/state.hpp a497ce1f58fb8dc7718ee5bb10bc62dd7479efa5
> src/slave/state.cpp f8e7cdd4df0a3c5d62d89edd11844527084f2baa
> src/tests/slave_recovery_tests.cpp 946a7bc4b78f56244633a0b2acb59381e3dbe7e7
>
> Diff: https://reviews.apache.org/r/56895/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Megha Sharma
>
>
Re: Review Request 56895: Allow agents to recover slave state post a
reboot.
Posted by Megha Sharma <ms...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56895/
-----------------------------------------------------------
(Updated Feb. 21, 2017, 6:58 p.m.)
Review request for mesos.
Bugs: MESOS-6223
https://issues.apache.org/jira/browse/MESOS-6223
Repository: mesos
Description
-------
With partition awareness, the agents are now allowed to re-register
after they have been marked Unreachable. The executors are anyway
terminated on the agent when it reboots so there is no harm in
letting the agent keep its SlaveID, re-register with the master
and reconcile the lost executors. This is a pre-requisite for
supporting persistent/restartable tasks in mesos.
Diffs
-----
src/slave/slave.hpp 5049eb783b8ad7b9599f20c3701f7d3d654b4491
src/slave/slave.cpp 92564ff8fff06d1cb17192d374d355b4bb7d39d8
src/slave/state.hpp a497ce1f58fb8dc7718ee5bb10bc62dd7479efa5
src/slave/state.cpp f8e7cdd4df0a3c5d62d89edd11844527084f2baa
src/tests/slave_recovery_tests.cpp 946a7bc4b78f56244633a0b2acb59381e3dbe7e7
Diff: https://reviews.apache.org/r/56895/diff/
Testing
-------
Thanks,
Megha Sharma