You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/02/13 23:24:08 UTC
Review Request 56617: Updated libprocess handlers to use
'AuthenticationContext'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56617/
-----------------------------------------------------------
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch updates the HTTP endpoint handlers in libprocess
to make use of the `AuthenticationContext` instead of an
`Option<string>& principal`.
Diffs
-----
3rdparty/libprocess/include/process/logging.hpp b5c2515605d5a9fab304f1425d29082f6167cea4
3rdparty/libprocess/include/process/metrics/metrics.hpp d9c64b7a4660182a5a23beed50a8e42b89d8b2aa
3rdparty/libprocess/include/process/profiler.hpp d19d647aa0d1172f09940fae1d1dfa83fd07b924
3rdparty/libprocess/src/logging.cpp cf7b43d2339df57ce899677419968d7e00ad8c38
3rdparty/libprocess/src/metrics/metrics.cpp 29c8c1da4e1424f029ccdf9fab890e8c1ec0ccb8
3rdparty/libprocess/src/profiler.cpp 2b3b6d5220aed9568f9fef51045cf322aa2934d7
Diff: https://reviews.apache.org/r/56617/diff/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56617: Updated libprocess handlers to use
'AuthenticationContext'.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56617/#review166117
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Feb. 13, 2017, 7:41 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56617/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 7:41 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in libprocess
> to make use of the `AuthenticationContext` instead of an
> `Option<string>& principal`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp b5c2515605d5a9fab304f1425d29082f6167cea4
> 3rdparty/libprocess/include/process/metrics/metrics.hpp d9c64b7a4660182a5a23beed50a8e42b89d8b2aa
> 3rdparty/libprocess/include/process/profiler.hpp d19d647aa0d1172f09940fae1d1dfa83fd07b924
> 3rdparty/libprocess/src/logging.cpp cf7b43d2339df57ce899677419968d7e00ad8c38
> 3rdparty/libprocess/src/metrics/metrics.cpp 29c8c1da4e1424f029ccdf9fab890e8c1ec0ccb8
> 3rdparty/libprocess/src/profiler.cpp 2b3b6d5220aed9568f9fef51045cf322aa2934d7
>
> Diff: https://reviews.apache.org/r/56617/diff/
>
>
> Testing
> -------
>
> Testing information can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56617: Updated libprocess handlers to use
'AuthenticationContext'.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56617/#review165824
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Feb. 14, 2017, 4:41 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56617/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 4:41 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in libprocess
> to make use of the `AuthenticationContext` instead of an
> `Option<string>& principal`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp b5c2515605d5a9fab304f1425d29082f6167cea4
> 3rdparty/libprocess/include/process/metrics/metrics.hpp d9c64b7a4660182a5a23beed50a8e42b89d8b2aa
> 3rdparty/libprocess/include/process/profiler.hpp d19d647aa0d1172f09940fae1d1dfa83fd07b924
> 3rdparty/libprocess/src/logging.cpp cf7b43d2339df57ce899677419968d7e00ad8c38
> 3rdparty/libprocess/src/metrics/metrics.cpp 29c8c1da4e1424f029ccdf9fab890e8c1ec0ccb8
> 3rdparty/libprocess/src/profiler.cpp 2b3b6d5220aed9568f9fef51045cf322aa2934d7
>
> Diff: https://reviews.apache.org/r/56617/diff/
>
>
> Testing
> -------
>
> Testing information can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56617: Updated libprocess handlers to use
'AuthenticationContext'.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56617/#review166589
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 14, 2017, 3:41 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56617/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 3:41 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in libprocess
> to make use of the `AuthenticationContext` instead of an
> `Option<string>& principal`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp b5c2515605d5a9fab304f1425d29082f6167cea4
> 3rdparty/libprocess/include/process/metrics/metrics.hpp d9c64b7a4660182a5a23beed50a8e42b89d8b2aa
> 3rdparty/libprocess/include/process/profiler.hpp d19d647aa0d1172f09940fae1d1dfa83fd07b924
> 3rdparty/libprocess/src/logging.cpp cf7b43d2339df57ce899677419968d7e00ad8c38
> 3rdparty/libprocess/src/metrics/metrics.cpp 29c8c1da4e1424f029ccdf9fab890e8c1ec0ccb8
> 3rdparty/libprocess/src/profiler.cpp 2b3b6d5220aed9568f9fef51045cf322aa2934d7
>
> Diff: https://reviews.apache.org/r/56617/diff/
>
>
> Testing
> -------
>
> Testing information can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56617: Updated libprocess handlers to use
'AuthenticationContext'.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56617/#review165700
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Feb. 14, 2017, 4:41 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56617/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 4:41 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in libprocess
> to make use of the `AuthenticationContext` instead of an
> `Option<string>& principal`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp b5c2515605d5a9fab304f1425d29082f6167cea4
> 3rdparty/libprocess/include/process/metrics/metrics.hpp d9c64b7a4660182a5a23beed50a8e42b89d8b2aa
> 3rdparty/libprocess/include/process/profiler.hpp d19d647aa0d1172f09940fae1d1dfa83fd07b924
> 3rdparty/libprocess/src/logging.cpp cf7b43d2339df57ce899677419968d7e00ad8c38
> 3rdparty/libprocess/src/metrics/metrics.cpp 29c8c1da4e1424f029ccdf9fab890e8c1ec0ccb8
> 3rdparty/libprocess/src/profiler.cpp 2b3b6d5220aed9568f9fef51045cf322aa2934d7
>
> Diff: https://reviews.apache.org/r/56617/diff/
>
>
> Testing
> -------
>
> Testing information can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56617: Updated libprocess handlers to use the
'Principal' type.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56617/#review167890
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 28, 2017, 6:21 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56617/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 6:21 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in libprocess
> to make use of the `Principal` type instead of an
> `Option<string>& principal`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp b5c2515605d5a9fab304f1425d29082f6167cea4
> 3rdparty/libprocess/include/process/metrics/metrics.hpp d9c64b7a4660182a5a23beed50a8e42b89d8b2aa
> 3rdparty/libprocess/include/process/profiler.hpp d19d647aa0d1172f09940fae1d1dfa83fd07b924
> 3rdparty/libprocess/src/logging.cpp cf7b43d2339df57ce899677419968d7e00ad8c38
> 3rdparty/libprocess/src/metrics/metrics.cpp 29c8c1da4e1424f029ccdf9fab890e8c1ec0ccb8
> 3rdparty/libprocess/src/profiler.cpp 2b3b6d5220aed9568f9fef51045cf322aa2934d7
>
>
> Diff: https://reviews.apache.org/r/56617/diff/2/
>
>
> Testing
> -------
>
> Testing information can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56617: Updated libprocess handlers to use the
'Principal' type.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56617/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 6:21 a.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Changes
-------
Changed 'AuthenticationContext' to 'Principal'.
Summary (updated)
-----------------
Updated libprocess handlers to use the 'Principal' type.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description (updated)
-------
This patch updates the HTTP endpoint handlers in libprocess
to make use of the `Principal` type instead of an
`Option<string>& principal`.
Diffs (updated)
-----
3rdparty/libprocess/include/process/logging.hpp b5c2515605d5a9fab304f1425d29082f6167cea4
3rdparty/libprocess/include/process/metrics/metrics.hpp d9c64b7a4660182a5a23beed50a8e42b89d8b2aa
3rdparty/libprocess/include/process/profiler.hpp d19d647aa0d1172f09940fae1d1dfa83fd07b924
3rdparty/libprocess/src/logging.cpp cf7b43d2339df57ce899677419968d7e00ad8c38
3rdparty/libprocess/src/metrics/metrics.cpp 29c8c1da4e1424f029ccdf9fab890e8c1ec0ccb8
3rdparty/libprocess/src/profiler.cpp 2b3b6d5220aed9568f9fef51045cf322aa2934d7
Diff: https://reviews.apache.org/r/56617/diff/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56617: Updated libprocess handlers to use
'AuthenticationContext'.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56617/
-----------------------------------------------------------
(Updated Feb. 14, 2017, 3:41 a.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch updates the HTTP endpoint handlers in libprocess
to make use of the `AuthenticationContext` instead of an
`Option<string>& principal`.
Diffs
-----
3rdparty/libprocess/include/process/logging.hpp b5c2515605d5a9fab304f1425d29082f6167cea4
3rdparty/libprocess/include/process/metrics/metrics.hpp d9c64b7a4660182a5a23beed50a8e42b89d8b2aa
3rdparty/libprocess/include/process/profiler.hpp d19d647aa0d1172f09940fae1d1dfa83fd07b924
3rdparty/libprocess/src/logging.cpp cf7b43d2339df57ce899677419968d7e00ad8c38
3rdparty/libprocess/src/metrics/metrics.cpp 29c8c1da4e1424f029ccdf9fab890e8c1ec0ccb8
3rdparty/libprocess/src/profiler.cpp 2b3b6d5220aed9568f9fef51045cf322aa2934d7
Diff: https://reviews.apache.org/r/56617/diff/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann