Re: Review Request 55576: Fixes `FutureTest.After3` flakiness.

[Alexander Rojas <al...@mesosphere.io>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55576/
-----------------------------------------------------------

(Updated Feb. 28, 2017, 11:09 a.m.)


Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler, and Joris Van Remoortere.


Summary (updated)
-----------------

Fixes `FutureTest.After3` flakiness.


Bugs: MESOS-6907
    https://issues.apache.org/jira/browse/MESOS-6907


Repository: mesos


Description (updated)
-------

Adds calls to `Clock::pause()`, `Clock::advance()` and
`Clock::settle()` to `FutureTest.After3` therefore ensuring
that data stored in timer's callbacks is destroyed by the
time `Clock::settle()` returns.

This is possible after a bug fix which caused timer's 
callbacks to not always be deleted before `Clock::settle()`
returned.


Diffs
-----

  3rdparty/libprocess/src/tests/future_tests.cpp 380755f9a2329d548969cfb2332c79aacbf7fff2 

Diff: https://reviews.apache.org/r/55576/diff/


Testing
-------

```sh
# Put the machine under stress.
$ stress -c 4 -t 2600 -d 2 -i 2 &
$ ./${MESOS_SRC_ROOT}/build/3rdparty/libprocess/libprocess-tests \
      --gtest_filter="FutureTest.After3" --gtest_repeat=1000000 --gtest_break_on_failure
$ ./${MESOS_SRC_ROOT}/build/build/src/mesos-tests
```


Thanks,

Alexander Rojas