You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/02/28 06:37:04 UTC
Re: Review Request 56812: Updated agent handlers to use the
'Principal' type.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 6:37 a.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Changes
-------
Changed 'AuthenticationContext' to 'Principal'.
Summary (updated)
-----------------
Updated agent handlers to use the 'Principal' type.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description (updated)
-------
This patch updates the HTTP endpoint handlers in the
agent process to accept the `Principal` type instead
of an `Option<string>& principal`.
Diffs (updated)
-----
src/slave/http.cpp 94731ec883c309cefb811694dc4e39de12d1ac59
src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2
src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a
Diff: https://reviews.apache.org/r/56812/diff/
Testing
-------
Testing details can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56812: Updated agent handlers to use the
'Principal' type.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/#review167902
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 3, 2017, 6:43 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56812/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 6:43 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in the
> agent process to accept the `Principal` type instead
> of an `Option<string>& principal`.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 94731ec883c309cefb811694dc4e39de12d1ac59
> src/slave/slave.hpp 449971b6b343c7714e1d1167a55bbdfe94d2cf83
> src/slave/slave.cpp 6ae9458cc81a7623a1837cd636156434a972004b
>
>
> Diff: https://reviews.apache.org/r/56812/diff/5/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56812: Updated agent handlers to use the
'Principal' type.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/
-----------------------------------------------------------
(Updated March 3, 2017, 6:43 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Changes
-------
Removed `createOptionalSubject()`.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch updates the HTTP endpoint handlers in the
agent process to accept the `Principal` type instead
of an `Option<string>& principal`.
Diffs (updated)
-----
src/slave/http.cpp 94731ec883c309cefb811694dc4e39de12d1ac59
src/slave/slave.hpp 449971b6b343c7714e1d1167a55bbdfe94d2cf83
src/slave/slave.cpp 6ae9458cc81a7623a1837cd636156434a972004b
Diff: https://reviews.apache.org/r/56812/diff/5/
Changes: https://reviews.apache.org/r/56812/diff/4-5/
Testing
-------
Testing details can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56812: Updated agent handlers to use the
'Principal' type.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/#review167058
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Feb. 28, 2017, 7:37 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56812/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 7:37 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in the
> agent process to accept the `Principal` type instead
> of an `Option<string>& principal`.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 94731ec883c309cefb811694dc4e39de12d1ac59
> src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2
> src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a
>
> Diff: https://reviews.apache.org/r/56812/diff/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>