You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/02/08 02:54:14 UTC

Review Request 56423: Added CHECKs to the agent to ensure allocation info is set.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56423/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

The agent has an invariant that all tasks and executors have an
allocation info. This adds CHECKs to ensure this is the case.


Diffs
-----

  src/slave/slave.cpp 92564ff8fff06d1cb17192d374d355b4bb7d39d8 

Diff: https://reviews.apache.org/r/56423/diff/


Testing
-------

make check


Thanks,

Benjamin Mahler


Re: Review Request 56423: Added CHECKs to the agent to ensure allocation info is set.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56423/#review164804
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Feb. 7, 2017, 6:54 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56423/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2017, 6:54 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The agent has an invariant that all tasks and executors have an
> allocation info. This adds CHECKs to ensure this is the case.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 92564ff8fff06d1cb17192d374d355b4bb7d39d8 
> 
> Diff: https://reviews.apache.org/r/56423/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>