You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/02/24 01:15:13 UTC
Review Request 57011: Add support for SHARE and UNSHARE operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57011/
-----------------------------------------------------------
Review request for mesos and Jiang Yan Xu.
Bugs: MESOS-7128
https://issues.apache.org/jira/browse/MESOS-7128
Repository: mesos
Description
-------
SHARE and UNSHARE is allowed for persistent volumes currently.
Only a non-shared resource can be SHAREd, and a shared resource can be
UNSHAREd. UNSHARE is processed only if the resources are not in use
by a running task, or has not been requested by a pending task. If
the UNSHARE is processed, the pending offers containing the resources
to be unshared are rescinded from all frameworks to which this shared
resource has been offered.
Diffs
-----
include/mesos/resources.hpp 73e44be8aa03cfd167ff47bbff5d708fb545c01b
include/mesos/v1/resources.hpp 19132298cf9f51a60f700ed5ac8c3fbe93e8c40f
src/common/protobuf_utils.cpp 442184920521f372c535426f49155cb19980bf6d
src/common/resources.cpp 388e3ef3eabea0dd8d1300e56d493b92b70c75e3
src/master/master.hpp 764adb18ddf09b62529c5c96f8e4dfaf7803483e
src/master/master.cpp 2ef836536784d5fda23c80dc2304239b176a8942
src/master/validation.hpp f03b3280704083be1ca074ca07c69edbb49dae19
src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f
src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a
src/v1/resources.cpp e47c4d49e69b915d37e40a91fef69f75dff52463
Diff: https://reviews.apache.org/r/57011/diff/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 57011: Add support for SHARE and UNSHARE
operations.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57011/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 11:58 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-7128
https://issues.apache.org/jira/browse/MESOS-7128
Repository: mesos
Description
-------
SHARE and UNSHARE is allowed for persistent volumes currently.
Only a non-shared resource can be SHAREd, and a shared resource can be
UNSHAREd. UNSHARE is processed only if the resources are not in use
by a running task, or has not been requested by a pending task. If
the UNSHARE is processed, the pending offers containing the resources
to be unshared are rescinded from all frameworks to which this shared
resource has been offered.
Diffs (updated)
-----
include/mesos/resources.hpp 73e44be8aa03cfd167ff47bbff5d708fb545c01b
include/mesos/v1/resources.hpp 19132298cf9f51a60f700ed5ac8c3fbe93e8c40f
src/common/protobuf_utils.cpp 944263bbaa87a65005fd924bccfadb7293312fa0
src/common/resources.cpp 388e3ef3eabea0dd8d1300e56d493b92b70c75e3
src/master/master.hpp 764adb18ddf09b62529c5c96f8e4dfaf7803483e
src/master/master.cpp ae36bf477851bf2fe11eb7913c580e3e0b9cbbe5
src/master/validation.hpp 50a3e6ec6a6d44c9ad449edfbd5d2cf8540b3a73
src/master/validation.cpp 41ef0d072ca53d9695c16b8dd98c319186f11f75
src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a
src/v1/resources.cpp e47c4d49e69b915d37e40a91fef69f75dff52463
Diff: https://reviews.apache.org/r/57011/diff/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha