You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.com> on 2017/02/06 13:00:26 UTC
Review Request 56326: Size of the favicon optimized.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56326/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Repository: mesos
Description
-------
The favicon keeps the same images as before but its size has been reduced (in a lossless manner) from 361 KB to 115 KB.
Diffs
-----
src/webui/master/static/ico/favicon.ico 11dd3de5f124550be141bce9a9a96a516a9c9b7b
Diff: https://reviews.apache.org/r/56326/diff/
Testing
-------
None. I took care of converting 'favicon.ico' to '.png' images using imagemagick, optimized their size using ImageOptim, and rebundled them as 'favicon.ico' using imagemagick again.
Thanks,
Armand Grillet
Re: Review Request 56326: Size of the favicon optimized.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56326/#review164346
-----------------------------------------------------------
Bad patch!
Reviews applied: [56326]
Failed command: python support/apply-reviews.py -n -r 56326
Error:
2017-02-06 13:30:40 URL:https://reviews.apache.org/r/56326/diff/raw/ [299/299] -> "56326.patch" [1]
error: missing binary patch data for 'src/webui/master/static/ico/favicon.ico'
error: binary patch does not apply to 'src/webui/master/static/ico/favicon.ico'
error: src/webui/master/static/ico/favicon.ico: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/17002/console
- Mesos Reviewbot
On Feb. 6, 2017, 1 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56326/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 1 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The favicon keeps the same images as before but its size has been reduced (in a lossless manner) from 361 KB to 115 KB.
>
>
> Diffs
> -----
>
> src/webui/master/static/ico/favicon.ico 11dd3de5f124550be141bce9a9a96a516a9c9b7b
>
> Diff: https://reviews.apache.org/r/56326/diff/
>
>
> Testing
> -------
>
> None. I took care of converting 'favicon.ico' to '.png' images using imagemagick, optimized their size using ImageOptim, and rebundled them as 'favicon.ico' using imagemagick again.
>
>
> Thanks,
>
> Armand Grillet
>
>