You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/02/02 22:59:35 UTC
Review Request 56250: Cleaned up headers in DRF sorter.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56250/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
Cleaned up headers in DRF sorter.
Diffs
-----
src/master/allocator/sorter/drf/sorter.cpp 5681a5d78a7bdde820c3a8633d742d9d6412f1c7
Diff: https://reviews.apache.org/r/56250/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 56250: Cleaned up headers in DRF sorter.
Posted by Gastón Kleiman <ga...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56250/#review164114
-----------------------------------------------------------
Fix it, then Ship it!
src/master/allocator/sorter/drf/sorter.cpp (line 32)
<https://reviews.apache.org/r/56250/#comment235694>
According to recent discussions and to our code style guide, this should be the first include in the file.
- Gast�n Kleiman
On Feb. 2, 2017, 10:59 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56250/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 10:59 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up headers in DRF sorter.
>
>
> Diffs
> -----
>
> src/master/allocator/sorter/drf/sorter.cpp 5681a5d78a7bdde820c3a8633d742d9d6412f1c7
>
> Diff: https://reviews.apache.org/r/56250/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 56250: Cleaned up headers in sorter and allocator
metrics.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56250/#review164208
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Feb. 3, 2017, 12:21 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56250/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2017, 12:21 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up headers in sorter and allocator metrics.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/metrics.hpp 753f90acc52ada84883cbbe3350e61d1e1eaff48
> src/master/allocator/mesos/metrics.cpp a36d21c297160bc1c9f43a22743fd5448d7ae5ac
> src/master/allocator/sorter/drf/sorter.cpp 5681a5d78a7bdde820c3a8633d742d9d6412f1c7
>
> Diff: https://reviews.apache.org/r/56250/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 56250: Cleaned up headers in sorter and allocator
metrics.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56250/
-----------------------------------------------------------
(Updated Feb. 3, 2017, 8:21 p.m.)
Review request for mesos and Michael Park.
Changes
-------
More header/include fixes, per review suggestion.
Summary (updated)
-----------------
Cleaned up headers in sorter and allocator metrics.
Repository: mesos
Description (updated)
-------
Cleaned up headers in sorter and allocator metrics.
Diffs (updated)
-----
src/master/allocator/mesos/metrics.hpp 753f90acc52ada84883cbbe3350e61d1e1eaff48
src/master/allocator/mesos/metrics.cpp a36d21c297160bc1c9f43a22743fd5448d7ae5ac
src/master/allocator/sorter/drf/sorter.cpp 5681a5d78a7bdde820c3a8633d742d9d6412f1c7
Diff: https://reviews.apache.org/r/56250/diff/
Testing
-------
`make check`
Thanks,
Neil Conway