You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/02/27 20:18:05 UTC
Re: Review Request 53840: Added a metric in the allocator to track
previous allocation cycle.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53840/
-----------------------------------------------------------
(Updated Feb. 27, 2017, 8:18 p.m.)
Review request for mesos and Jiang Yan Xu.
Bugs: MESOS-6579
https://issues.apache.org/jira/browse/MESOS-6579
Repository: mesos
Description
-------
Added a metric 'allocator/mesos/last_allocation_secs_since' which
indicates how long back (in seconds) did the previous allocation
cycle run. If no allocation cycle has run yet, it has a value of -1.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp d33306745a7287b750cb4a5242c7527369d58d65
src/master/allocator/mesos/hierarchical.cpp eeb44fe89d4bfd26900b11833c1182157e5c7e5c
src/master/allocator/mesos/metrics.hpp ce486eb079dc44bf0bbfad8668426c7ae87c97b3
src/master/allocator/mesos/metrics.cpp ec987fe0ce8605bf9e7c0ccbe3ac384deaf53be1
src/tests/hierarchical_allocator_tests.cpp 5441fa9d1fad1ca7819038db49c6d88e40571e4a
Diff: https://reviews.apache.org/r/53840/diff/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 53840: Metric in the allocator to track latency
between allocation cycles.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53840/
-----------------------------------------------------------
(Updated March 7, 2017, 11:41 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Changed the metric to track latency between allocation cycles, as opposed to tracking the last allocation cycle.
Summary (updated)
-----------------
Metric in the allocator to track latency between allocation cycles.
Bugs: MESOS-6579
https://issues.apache.org/jira/browse/MESOS-6579
Repository: mesos
Description (updated)
-------
Added a metric 'allocator/mesos/allocation_run_interval_ms' which
tracks the latency between consecutive allocation cycles.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp 0059ccead90f32491591990c791e7fa905a864b7
src/master/allocator/mesos/metrics.hpp ce486eb079dc44bf0bbfad8668426c7ae87c97b3
src/master/allocator/mesos/metrics.cpp ec987fe0ce8605bf9e7c0ccbe3ac384deaf53be1
src/tests/hierarchical_allocator_tests.cpp cdf1f15b7802439b28405ca8f6634ce83e886630
Diff: https://reviews.apache.org/r/53840/diff/3/
Changes: https://reviews.apache.org/r/53840/diff/2-3/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 53840: Added a metric in the allocator to track
previous allocation cycle.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53840/
-----------------------------------------------------------
(Updated March 7, 2017, 6:52 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Removed RR 53839 from this review chain.
Bugs: MESOS-6579
https://issues.apache.org/jira/browse/MESOS-6579
Repository: mesos
Description
-------
Added a metric 'allocator/mesos/last_allocation_secs_since' which
indicates how long back (in seconds) did the previous allocation
cycle run. If no allocation cycle has run yet, it has a value of -1.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp d33306745a7287b750cb4a5242c7527369d58d65
src/master/allocator/mesos/hierarchical.cpp eeb44fe89d4bfd26900b11833c1182157e5c7e5c
src/master/allocator/mesos/metrics.hpp ce486eb079dc44bf0bbfad8668426c7ae87c97b3
src/master/allocator/mesos/metrics.cpp ec987fe0ce8605bf9e7c0ccbe3ac384deaf53be1
src/tests/hierarchical_allocator_tests.cpp 5441fa9d1fad1ca7819038db49c6d88e40571e4a
Diff: https://reviews.apache.org/r/53840/diff/2/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha