You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/02/15 00:05:33 UTC
Review Request 56692: Silenced a GMock warning in a test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56692/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Michael Park.
Repository: mesos
Description
-------
Silenced a GMock warning in a test.
Diffs
-----
src/tests/master_validation_tests.cpp fd1f4a6cf0661351e265e50da1bd6ea04ed13d26
Diff: https://reviews.apache.org/r/56692/diff/
Testing
-------
Without this change, the test consistently produces this warning on my system:
```
GMOCK WARNING:
Uninteresting mock function call - returning directly.
Function call: shutdown(0x7fe1f0e7d330)
```
With this change, the warning was not observed in 500 test runs.
Thanks,
Neil Conway
Re: Review Request 56692: Silenced a GMock warning in a test.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56692/#review165840
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/master_validation_tests.cpp (line 3402)
<https://reviews.apache.org/r/56692/#comment237675>
Would it make sense to add a comment clarifying why this is needed here, but not below? Something like
// Since we launched tasks, stopping the driver will trigger
// a shutdown request to the executor.
- Benjamin Bannier
On Feb. 15, 2017, 1:05 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56692/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 1:05 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Silenced a GMock warning in a test.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp fd1f4a6cf0661351e265e50da1bd6ea04ed13d26
>
> Diff: https://reviews.apache.org/r/56692/diff/
>
>
> Testing
> -------
>
> Without this change, the test consistently produces this warning on my system:
>
> ```
> GMOCK WARNING:
> Uninteresting mock function call - returning directly.
> Function call: shutdown(0x7fe1f0e7d330)
> ```
>
> With this change, the warning was not observed in 500 test runs.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 56692: Silenced a GMock warning in a test.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56692/#review165967
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Feb. 17, 2017, 11:35 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56692/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2017, 11:35 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Silenced a GMock warning in a test.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 717673875cd468c23065766438723c3e0fa0627e
>
> Diff: https://reviews.apache.org/r/56692/diff/
>
>
> Testing
> -------
>
> Without this change, the test consistently produces this warning on my system:
>
> ```
> GMOCK WARNING:
> Uninteresting mock function call - returning directly.
> Function call: shutdown(0x7fe1f0e7d330)
> ```
>
> With this change, the warning was not observed in 500 test runs.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 56692: Silenced a GMock warning in a test.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56692/
-----------------------------------------------------------
(Updated Feb. 17, 2017, 7:35 p.m.)
Review request for mesos, Benjamin Bannier and Michael Park.
Changes
-------
Add comment, per review.
Repository: mesos
Description
-------
Silenced a GMock warning in a test.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp 717673875cd468c23065766438723c3e0fa0627e
Diff: https://reviews.apache.org/r/56692/diff/
Testing
-------
Without this change, the test consistently produces this warning on my system:
```
GMOCK WARNING:
Uninteresting mock function call - returning directly.
Function call: shutdown(0x7fe1f0e7d330)
```
With this change, the warning was not observed in 500 test runs.
Thanks,
Neil Conway
Re: Review Request 56692: Silenced a GMock warning in a test.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56692/#review165652
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56692]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 15, 2017, 12:05 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56692/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 12:05 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Silenced a GMock warning in a test.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp fd1f4a6cf0661351e265e50da1bd6ea04ed13d26
>
> Diff: https://reviews.apache.org/r/56692/diff/
>
>
> Testing
> -------
>
> Without this change, the test consistently produces this warning on my system:
>
> ```
> GMOCK WARNING:
> Uninteresting mock function call - returning directly.
> Function call: shutdown(0x7fe1f0e7d330)
> ```
>
> With this change, the warning was not observed in 500 test runs.
>
>
> Thanks,
>
> Neil Conway
>
>