You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/02/20 12:57:49 UTC
Review Request 56852: Updated OCI spec parsing & validation code with
latest OCI image spec.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56852/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description
-------
Updated OCI spec parsing & validation code with latest OCI image spec.
Diffs
-----
include/mesos/oci/spec.hpp ea4f29e3f5a552b671738d664882f08db682ad90
src/oci/spec.cpp 0a88edb404836205f11e61ba3edb771df8b618ef
Diff: https://reviews.apache.org/r/56852/diff/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 56852: Updated OCI spec parsing & validation code
with latest OCI image spec.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56852/#review170221
-----------------------------------------------------------
Ship it!
Ditto on s/ImageIndex/Index/
- Jie Yu
On March 2, 2017, 9:30 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56852/
> -----------------------------------------------------------
>
> (Updated March 2, 2017, 9:30 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated OCI spec parsing & validation code with latest OCI image spec.
>
>
> Diffs
> -----
>
> include/mesos/oci/spec.hpp ea4f29e3f5a552b671738d664882f08db682ad90
> src/oci/spec.cpp 0a88edb404836205f11e61ba3edb771df8b618ef
>
>
> Diff: https://reviews.apache.org/r/56852/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 56852: Updated OCI spec parsing & validation code
with latest OCI image spec.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56852/
-----------------------------------------------------------
(Updated March 28, 2017, 4:49 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
Removed the unnecessary media type validation, because as per the spec, an encountered mediaType that is unknown should be safely ignored.
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description
-------
Updated OCI spec parsing & validation code with latest OCI image spec.
Diffs (updated)
-----
include/mesos/oci/spec.hpp ea4f29e3f5a552b671738d664882f08db682ad90
src/oci/spec.cpp 0a88edb404836205f11e61ba3edb771df8b618ef
Diff: https://reviews.apache.org/r/56852/diff/5/
Changes: https://reviews.apache.org/r/56852/diff/4-5/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 56852: Updated OCI spec parsing & validation code
with latest OCI image spec.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56852/
-----------------------------------------------------------
(Updated March 28, 2017, 4:19 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
Addressed Jie's comments.
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description
-------
Updated OCI spec parsing & validation code with latest OCI image spec.
Diffs (updated)
-----
include/mesos/oci/spec.hpp ea4f29e3f5a552b671738d664882f08db682ad90
src/oci/spec.cpp 0a88edb404836205f11e61ba3edb771df8b618ef
Diff: https://reviews.apache.org/r/56852/diff/4/
Changes: https://reviews.apache.org/r/56852/diff/3-4/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 56852: Updated OCI spec parsing & validation code
with latest OCI image spec.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56852/
-----------------------------------------------------------
(Updated March 2, 2017, 5:30 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
Updated media type validation for image index.
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description
-------
Updated OCI spec parsing & validation code with latest OCI image spec.
Diffs (updated)
-----
include/mesos/oci/spec.hpp ea4f29e3f5a552b671738d664882f08db682ad90
src/oci/spec.cpp 0a88edb404836205f11e61ba3edb771df8b618ef
Diff: https://reviews.apache.org/r/56852/diff/3/
Changes: https://reviews.apache.org/r/56852/diff/2-3/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 56852: Updated OCI spec parsing & validation code
with latest OCI image spec.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56852/
-----------------------------------------------------------
(Updated Feb. 23, 2017, 9:26 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description
-------
Updated OCI spec parsing & validation code with latest OCI image spec.
Diffs (updated)
-----
include/mesos/oci/spec.hpp ea4f29e3f5a552b671738d664882f08db682ad90
src/oci/spec.cpp 0a88edb404836205f11e61ba3edb771df8b618ef
Diff: https://reviews.apache.org/r/56852/diff/
Testing
-------
Thanks,
Qian Zhang