You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/02/07 22:26:45 UTC
Re: Review Request 56341: Updated AppC & Docker runtime isolators'
handling of Environment.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56341/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 2:26 p.m.)
Review request for mesos, Jie Yu and Kevin Klues.
Changes
-------
Oops, forgot to update the summary/description.
Summary (updated)
-----------------
Updated AppC & Docker runtime isolators' handling of Environment.
Bugs: MESOS-7027
https://issues.apache.org/jira/browse/MESOS-7027
Repository: mesos
Description (updated)
-------
This commit builds upon the command executor's new `--task_environment`
flag, which allows isolators to specify environment variables meant
for the task, without affecting the executor's environment.
This is important as the command executor is both an executor and
a task. Some environment variables from isolators are intended
for the executor, while others are intended for the task (such as
from the two runtime isolators).
For example, a container image may provide an environment variable
like `LD_LIBRARY_PATH=/image/specific/location`, whereas the default
executor expects to find libraries in the host's environment. If the
image's environment end up in the command executor at launch time,
the command executor may simply fail to launch.
Diffs
-----
src/slave/containerizer/mesos/isolators/appc/runtime.cpp 9bc3fd8309435846c17944e74f611212069dbd76
src/slave/containerizer/mesos/isolators/docker/runtime.cpp 2d816e512c95ed2922c9578ba796908c5ce23da4
Diff: https://reviews.apache.org/r/56341/diff/
Testing
-------
make check
sudo src/mesos-tests --gtest_filter="*ROOT*"
All the tests broken by https://reviews.apache.org/r/56339/ (earlier in the chain) are now passing.
Thanks,
Joseph Wu
Re: Review Request 56341: Updated AppC & Docker runtime isolators'
handling of Environment.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56341/#review164583
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 7, 2017, 10:26 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56341/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 10:26 p.m.)
>
>
> Review request for mesos, Jie Yu and Kevin Klues.
>
>
> Bugs: MESOS-7027
> https://issues.apache.org/jira/browse/MESOS-7027
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit builds upon the command executor's new `--task_environment`
> flag, which allows isolators to specify environment variables meant
> for the task, without affecting the executor's environment.
>
> This is important as the command executor is both an executor and
> a task. Some environment variables from isolators are intended
> for the executor, while others are intended for the task (such as
> from the two runtime isolators).
>
> For example, a container image may provide an environment variable
> like `LD_LIBRARY_PATH=/image/specific/location`, whereas the default
> executor expects to find libraries in the host's environment. If the
> image's environment end up in the command executor at launch time,
> the command executor may simply fail to launch.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/appc/runtime.cpp 9bc3fd8309435846c17944e74f611212069dbd76
> src/slave/containerizer/mesos/isolators/docker/runtime.cpp 2d816e512c95ed2922c9578ba796908c5ce23da4
>
> Diff: https://reviews.apache.org/r/56341/diff/
>
>
> Testing
> -------
>
> make check
>
> sudo src/mesos-tests --gtest_filter="*ROOT*"
>
> All the tests broken by https://reviews.apache.org/r/56339/ (earlier in the chain) are now passing.
>
>
> Thanks,
>
> Joseph Wu
>
>