You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/02/28 15:52:19 UTC
Re: Review Request 56210: Reused previous task status for health
updates in command executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56210/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 3:52 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Summary (updated)
-----------------
Reused previous task status for health updates in command executor.
Bugs: MESOS-6906
https://issues.apache.org/jira/browse/MESOS-6906
Repository: mesos
Description (updated)
-------
When a new health task status update is generated in the executor, we
have to make sure specific data is duplicated from the previous one to
avoid shadowing of those data during reconciliation.
Diffs (updated)
-----
src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378
Diff: https://reviews.apache.org/r/56210/diff/
Testing (updated)
-------
See https://reviews.apache.org/r/56213/
Thanks,
Alexander Rukletsov
Re: Review Request 56210: Reused previous task status for health
updates in command executor.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56210/#review167770
-----------------------------------------------------------
Fix it, then Ship it!
Looks much cleaner. Thanks for the cleanup!
src/launcher/executor.cpp
Line 744 (original), 769 (patched)
<https://reviews.apache.org/r/56210/#comment239735>
s/if you want status update to be create/ to create a status update/
- Vinod Kone
On Feb. 28, 2017, 3:52 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56210/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 3:52 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Bugs: MESOS-6906
> https://issues.apache.org/jira/browse/MESOS-6906
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When a new health task status update is generated in the executor, we
> have to make sure specific data is duplicated from the previous one to
> avoid shadowing of those data during reconciliation.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378
>
>
> Diff: https://reviews.apache.org/r/56210/diff/5/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/56213/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 56210: Reused previous task status for health
updates in command executor.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56210/
-----------------------------------------------------------
(Updated March 15, 2017, 12:47 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Changes
-------
Rebased. NNTR.
Bugs: MESOS-6906
https://issues.apache.org/jira/browse/MESOS-6906
Repository: mesos
Description
-------
When a new health task status update is generated in the executor, we
have to make sure specific data is duplicated from the previous one to
avoid shadowing of those data during reconciliation.
Diffs (updated)
-----
src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378
Diff: https://reviews.apache.org/r/56210/diff/8/
Changes: https://reviews.apache.org/r/56210/diff/7-8/
Testing
-------
See https://reviews.apache.org/r/56213/
Thanks,
Alexander Rukletsov
Re: Review Request 56210: Reused previous task status for health
updates in command executor.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56210/
-----------------------------------------------------------
(Updated March 14, 2017, 2:07 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Bugs: MESOS-6906
https://issues.apache.org/jira/browse/MESOS-6906
Repository: mesos
Description
-------
When a new health task status update is generated in the executor, we
have to make sure specific data is duplicated from the previous one to
avoid shadowing of those data during reconciliation.
Diffs (updated)
-----
src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378
Diff: https://reviews.apache.org/r/56210/diff/7/
Changes: https://reviews.apache.org/r/56210/diff/6-7/
Testing
-------
See https://reviews.apache.org/r/56213/
Thanks,
Alexander Rukletsov
Re: Review Request 56210: Reused previous task status for health
updates in command executor.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56210/
-----------------------------------------------------------
(Updated March 7, 2017, 8:39 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Bugs: MESOS-6906
https://issues.apache.org/jira/browse/MESOS-6906
Repository: mesos
Description
-------
When a new health task status update is generated in the executor, we
have to make sure specific data is duplicated from the previous one to
avoid shadowing of those data during reconciliation.
Diffs (updated)
-----
src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378
Diff: https://reviews.apache.org/r/56210/diff/6/
Changes: https://reviews.apache.org/r/56210/diff/5-6/
Testing
-------
See https://reviews.apache.org/r/56213/
Thanks,
Alexander Rukletsov