You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Tomasz Janiszewski <ja...@gmail.com> on 2017/02/26 05:12:30 UTC
Re: Review Request 48291: Use varint comparator in replica log.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48291/
-----------------------------------------------------------
(Updated Lut 26, 2017, 5:12 rano)
Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent huang.
Changes
-------
rebase
Bugs: MESOS-970
https://issues.apache.org/jira/browse/MESOS-970
Repository: mesos
Description
-------
Since bug discussed at
https://groups.google.com/forum/#!topic/leveldb/F-rDkWiQm6c
was fixed. After upgrading leveldb to 1.18 we could replace
default byte-wise comparator with varint comparator.
Diffs (updated)
-----
src/log/leveldb.cpp 5310a123b0fb25f240429722b676fe46174cb2ce
Diff: https://reviews.apache.org/r/48291/diff/
Testing
-------
`make check dist` on Ubuntu x64
Thanks,
Tomasz Janiszewski
Re: Review Request 48291: Use varint comparator in replica log.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48291/#review166836
-----------------------------------------------------------
Patch looks great!
Reviews applied: [51053, 48291]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 26, 2017, 5:12 a.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48291/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2017, 5:12 a.m.)
>
>
> Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent huang.
>
>
> Bugs: MESOS-970
> https://issues.apache.org/jira/browse/MESOS-970
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since bug discussed at
> https://groups.google.com/forum/#!topic/leveldb/F-rDkWiQm6c
> was fixed. After upgrading leveldb to 1.18 we could replace
> default byte-wise comparator with varint comparator.
>
>
> Diffs
> -----
>
> src/log/leveldb.cpp 5310a123b0fb25f240429722b676fe46174cb2ce
>
> Diff: https://reviews.apache.org/r/48291/diff/
>
>
> Testing
> -------
>
> `make check dist` on Ubuntu x64
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 48291: Use varint comparator in replica log.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48291/#review169227
-----------------------------------------------------------
I don't have a lot of context here but I tried to look through the code and offer some help.
I'm not sure I follow how this is a backwards compatible change as it appears to be changing the key encoding from being a string encoding (with minimum 10 digits) to being a varint encoding? If so, doesn't that pose a problem when trying to restore a DB where we used string encoding, and we start using varint encoded keys?
src/log/leveldb.cpp
Lines 88-104 (original), 99-107 (patched)
<https://reviews.apache.org/r/48291/#comment241567>
This appears to be changing the key encoding? Is this backwards compatible?
- Benjamin Mahler
On March 11, 2017, 10:17 a.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48291/
> -----------------------------------------------------------
>
> (Updated March 11, 2017, 10:17 a.m.)
>
>
> Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent huang.
>
>
> Bugs: MESOS-7233
> https://issues.apache.org/jira/browse/MESOS-7233
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since bug discussed at
> https://groups.google.com/forum/#!topic/leveldb/F-rDkWiQm6c
> was fixed. After upgrading leveldb to 1.18 we could replace
> default byte-wise comparator with varint comparator.
>
>
> Diffs
> -----
>
> src/log/leveldb.cpp 5310a123b0fb25f240429722b676fe46174cb2ce
>
>
> Diff: https://reviews.apache.org/r/48291/diff/3/
>
>
> Testing
> -------
>
> `make check dist` on Ubuntu x64
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 48291: Use varint comparator in replica log.
Posted by Tomasz Janiszewski <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48291/
-----------------------------------------------------------
(Updated Mar 11, 2017, 10:17 rano)
Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent huang.
Changes
-------
Update jira issue
Bugs: MESOS-7233
https://issues.apache.org/jira/browse/MESOS-7233
Repository: mesos
Description
-------
Since bug discussed at
https://groups.google.com/forum/#!topic/leveldb/F-rDkWiQm6c
was fixed. After upgrading leveldb to 1.18 we could replace
default byte-wise comparator with varint comparator.
Diffs
-----
src/log/leveldb.cpp 5310a123b0fb25f240429722b676fe46174cb2ce
Diff: https://reviews.apache.org/r/48291/diff/3/
Testing
-------
`make check dist` on Ubuntu x64
Thanks,
Tomasz Janiszewski