You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/02/27 20:18:10 UTC
Re: Review Request 53842: Add role specific metrics for sorting runs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53842/
-----------------------------------------------------------
(Updated Feb. 27, 2017, 8:18 p.m.)
Review request for mesos and Jiang Yan Xu.
Bugs: MESOS-6579
https://issues.apache.org/jira/browse/MESOS-6579
Repository: mesos
Description
-------
Added the following 2 metrics which is maintained on a role level
(as long as there is at least one framework of that role):
a) allocator/mesos/frameworks/role/<role>/sort_runs: Number of framework
level sorts (based on role) in DRF Sorter.
b) allocator/mesos/frameworks/role/<role>/sort_run: Latency in framework
level sorts (based on role) in DRF Sorter.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp eeb44fe89d4bfd26900b11833c1182157e5c7e5c
src/master/allocator/mesos/metrics.hpp ce486eb079dc44bf0bbfad8668426c7ae87c97b3
src/master/allocator/mesos/metrics.cpp ec987fe0ce8605bf9e7c0ccbe3ac384deaf53be1
src/tests/hierarchical_allocator_tests.cpp 5441fa9d1fad1ca7819038db49c6d88e40571e4a
Diff: https://reviews.apache.org/r/53842/diff/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 53842: Add role specific metrics for sorting runs.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53842/#review168241
-----------------------------------------------------------
Patch looks great!
Reviews applied: [53840, 53841, 53842]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 7, 2017, 11:41 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53842/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 11:41 p.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-6579
> https://issues.apache.org/jira/browse/MESOS-6579
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the following 2 metrics which is maintained on a role level
> (as long as there is at least one framework of that role):
> a) allocator/mesos/frameworks/role/<role>/sort_runs: Number of framework
> level sorts (based on role) in DRF Sorter.
> b) allocator/mesos/frameworks/role/<role>/sort_run: Latency in framework
> level sorts (based on role) in DRF Sorter.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 646f66e67d9c6b8c61fc6e6558a1db976a44c126
> src/master/allocator/mesos/hierarchical.cpp 0059ccead90f32491591990c791e7fa905a864b7
> src/tests/hierarchical_allocator_tests.cpp cdf1f15b7802439b28405ca8f6634ce83e886630
>
>
> Diff: https://reviews.apache.org/r/53842/diff/3/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 53842: Add role specific metrics for sorting runs.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53842/
-----------------------------------------------------------
(Updated March 7, 2017, 11:41 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Track latency of sort runs for all frameworks belonging to specific roles.
Bugs: MESOS-6579
https://issues.apache.org/jira/browse/MESOS-6579
Repository: mesos
Description
-------
Added the following 2 metrics which is maintained on a role level
(as long as there is at least one framework of that role):
a) allocator/mesos/frameworks/role/<role>/sort_runs: Number of framework
level sorts (based on role) in DRF Sorter.
b) allocator/mesos/frameworks/role/<role>/sort_run: Latency in framework
level sorts (based on role) in DRF Sorter.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 646f66e67d9c6b8c61fc6e6558a1db976a44c126
src/master/allocator/mesos/hierarchical.cpp 0059ccead90f32491591990c791e7fa905a864b7
src/tests/hierarchical_allocator_tests.cpp cdf1f15b7802439b28405ca8f6634ce83e886630
Diff: https://reviews.apache.org/r/53842/diff/3/
Changes: https://reviews.apache.org/r/53842/diff/2-3/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 53842: Add role specific metrics for sorting runs.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53842/#review166950
-----------------------------------------------------------
Patch looks great!
Reviews applied: [53839, 53840, 53841, 53842]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 27, 2017, 8:18 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53842/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2017, 8:18 p.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-6579
> https://issues.apache.org/jira/browse/MESOS-6579
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the following 2 metrics which is maintained on a role level
> (as long as there is at least one framework of that role):
> a) allocator/mesos/frameworks/role/<role>/sort_runs: Number of framework
> level sorts (based on role) in DRF Sorter.
> b) allocator/mesos/frameworks/role/<role>/sort_run: Latency in framework
> level sorts (based on role) in DRF Sorter.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp eeb44fe89d4bfd26900b11833c1182157e5c7e5c
> src/master/allocator/mesos/metrics.hpp ce486eb079dc44bf0bbfad8668426c7ae87c97b3
> src/master/allocator/mesos/metrics.cpp ec987fe0ce8605bf9e7c0ccbe3ac384deaf53be1
> src/tests/hierarchical_allocator_tests.cpp 5441fa9d1fad1ca7819038db49c6d88e40571e4a
>
> Diff: https://reviews.apache.org/r/53842/diff/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>