You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/02/08 02:54:30 UTC
Review Request 56424: Removed a stale TODO in the agent code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56424/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
This TODO was written before the code below it handled the
optionality of the state `info` fields.
Diffs
-----
src/slave/slave.cpp 92564ff8fff06d1cb17192d374d355b4bb7d39d8
Diff: https://reviews.apache.org/r/56424/diff/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 56424: Removed a stale TODO in the agent code.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56424/#review164661
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56421, 56422, 56423, 56424]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 8, 2017, 2:54 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56424/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 2:54 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This TODO was written before the code below it handled the
> optionality of the state `info` fields.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 92564ff8fff06d1cb17192d374d355b4bb7d39d8
>
> Diff: https://reviews.apache.org/r/56424/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 56424: Removed a stale TODO in the agent code.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56424/#review164805
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Feb. 7, 2017, 6:54 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56424/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 6:54 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This TODO was written before the code below it handled the
> optionality of the state `info` fields.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 92564ff8fff06d1cb17192d374d355b4bb7d39d8
>
> Diff: https://reviews.apache.org/r/56424/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>