You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/02/27 20:18:08 UTC

Re: Review Request 53841: Added metrics for sorting of the sorters in the allocator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53841/
-----------------------------------------------------------

(Updated Feb. 27, 2017, 8:18 p.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-6579
    https://issues.apache.org/jira/browse/MESOS-6579


Repository: mesos


Description
-------

Following metrics have been added:
a) allocator/mesos/roles/sort_runs: Number of role/quota level sorts
   in DRF Sorter.
b) allocator/mesos/roles/sort_run: Latency in role/quota level sorts
   in DRF Sorter.
c) allocator/mesos/frameworks/sort_runs: Number of framework level sorts
   (across all roles) in DRF Sorter.
d) allocator/mesos/frameworks/sort_run: Latency in framework level sorts
   (across all roles) in DRF Sorter.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.cpp eeb44fe89d4bfd26900b11833c1182157e5c7e5c 
  src/master/allocator/mesos/metrics.hpp ce486eb079dc44bf0bbfad8668426c7ae87c97b3 
  src/master/allocator/mesos/metrics.cpp ec987fe0ce8605bf9e7c0ccbe3ac384deaf53be1 
  src/tests/hierarchical_allocator_tests.cpp 5441fa9d1fad1ca7819038db49c6d88e40571e4a 

Diff: https://reviews.apache.org/r/53841/diff/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha


Re: Review Request 53841: Added metrics for sorting of the sorters in the allocator.

Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53841/
-----------------------------------------------------------

(Updated March 7, 2017, 11:41 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
-------

Track latency of sorts for role and quota sorters when the dirty bit is set only.


Bugs: MESOS-6579
    https://issues.apache.org/jira/browse/MESOS-6579


Repository: mesos


Description (updated)
-------

Following metrics have been added:
a) allocator/mesos/roles/sort_runs: Number of role level sorts.
b) allocator/mesos/roles/sort_run: Latency in role level sorts.
c) allocator/mesos/quotas/sort_runs: Number of quota level sorts.
d) allocator/mesos/quotas/sort_run: Latency in quota level sorts.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.hpp 646f66e67d9c6b8c61fc6e6558a1db976a44c126 
  src/master/allocator/sorter/drf/metrics.hpp 61568cb520826ab59d675824b212e0d3deb63764 
  src/master/allocator/sorter/drf/metrics.cpp 15aab32db5ca1a7a14080e9bbb7c65283be3ec20 
  src/master/allocator/sorter/drf/sorter.hpp 76329220e1115c1de7810fb69b943c78c078be59 
  src/master/allocator/sorter/drf/sorter.cpp ed54680cecb637931fc344fbcf8fd3b14cc24295 
  src/tests/hierarchical_allocator_tests.cpp cdf1f15b7802439b28405ca8f6634ce83e886630 


Diff: https://reviews.apache.org/r/53841/diff/3/

Changes: https://reviews.apache.org/r/53841/diff/2-3/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha