You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/02/18 03:02:32 UTC
Review Request 56812: Updated agent handlers to use
'AuthenticationContext'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/
-----------------------------------------------------------
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch updates the HTTP endpoint handlers in the
agent process to accept an `AuthenticationContext`
instead of an `Option<string>& principal`.
Diffs
-----
src/slave/http.cpp af70b6f294a04f23b04cd1d8c36c1c3e86d7d5e6
src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2
src/slave/slave.cpp 7564e8d39530794131dbbc928fcbc59fb65ef471
Diff: https://reviews.apache.org/r/56812/diff/
Testing
-------
Testing details can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56812: Updated agent handlers to use
'AuthenticationContext'.
Posted by Vinod Kone <vi...@gmail.com>.
> On Feb. 24, 2017, 2:07 a.m., Vinod Kone wrote:
> > src/slave/http.cpp, line 831
> > <https://reviews.apache.org/r/56812/diff/2/?file=1641768#file1641768line831>
> >
> > so previously we were sending an empty subject (`Subject()`) but now we are sending `Option::None()` to `getObjectApprover`? what's the difference? i wish this change was done in a separate review instead of mixing it here with the use of auth context.
>
> Greg Mann wrote:
> Yes, the existing code is buggy. If authorization is enabled, but authentication is disabled (so that `principal` is `NONE`), then we end up default-constructing the authorization `Subject` instead of using `None()`. This creates a `Subject` with an empty string for its value.
>
> This means that if authorization is enabled, authentication is disabled, and an ACL has been set allowing a user called "" to do things, then requests which do not specify any Authorization header will be granted access incorrectly. Clearly, this is an extreme corner case, but a bug nonetheless.
>
> I didn't notice the bug until the reviews were already in flight, so I applied the change in these patches. If you like, I can create a patch before this one which applies the changes to make use of `None()` correctly, and then rebase onto that.
Yea, lets separate the patch out into dependent review. Will enable us to cherry pick it into older releases if needed.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/#review166636
-----------------------------------------------------------
On Feb. 22, 2017, 1:18 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56812/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 1:18 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in the
> agent process to accept an `AuthenticationContext`
> instead of an `Option<string>& principal`.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 8a9fabf861369d3ae659dce21fa3932f6f7b9161
> src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2
> src/slave/slave.cpp 45905297836017e9031359894fc71e614c13cfcc
>
> Diff: https://reviews.apache.org/r/56812/diff/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56812: Updated agent handlers to use the
'Principal' type.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Feb. 24, 2017, 2:07 a.m., Vinod Kone wrote:
> > src/slave/http.cpp, line 836
> > <https://reviews.apache.org/r/56812/diff/2/?file=1641768#file1641768line836>
> >
> > not related to your change, but I'm curious why this method uses the object approver whereas the `Slave::Http::flags()` doesn't? cc @arojas
>
> Greg Mann wrote:
> I'm guessing it's just for historical reasons; the old handler probably was not updated when the newer one was added?
>
> Alexander Rojas wrote:
> As Greg says, it is mostly historical reasons. Once the objectApprover was introduced, it is consider a better option, but we haven't consolidate an effort to move everthing towards the object approver.
I created a ticket to track migrating to the newer interface: https://issues.apache.org/jira/browse/MESOS-7190
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/#review166636
-----------------------------------------------------------
On Feb. 28, 2017, 6:37 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56812/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 6:37 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in the
> agent process to accept the `Principal` type instead
> of an `Option<string>& principal`.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 94731ec883c309cefb811694dc4e39de12d1ac59
> src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2
> src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a
>
> Diff: https://reviews.apache.org/r/56812/diff/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56812: Updated agent handlers to use the
'Principal' type.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On Feb. 24, 2017, 3:07 a.m., Vinod Kone wrote:
> > src/slave/http.cpp, line 836
> > <https://reviews.apache.org/r/56812/diff/2/?file=1641768#file1641768line836>
> >
> > not related to your change, but I'm curious why this method uses the object approver whereas the `Slave::Http::flags()` doesn't? cc @arojas
>
> Greg Mann wrote:
> I'm guessing it's just for historical reasons; the old handler probably was not updated when the newer one was added?
As Greg says, it is mostly historical reasons. Once the objectApprover was introduced, it is consider a better option, but we haven't consolidate an effort to move everthing towards the object approver.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/#review166636
-----------------------------------------------------------
On Feb. 28, 2017, 7:37 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56812/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 7:37 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in the
> agent process to accept the `Principal` type instead
> of an `Option<string>& principal`.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 94731ec883c309cefb811694dc4e39de12d1ac59
> src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2
> src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a
>
> Diff: https://reviews.apache.org/r/56812/diff/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56812: Updated agent handlers to use
'AuthenticationContext'.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Feb. 24, 2017, 2:07 a.m., Vinod Kone wrote:
> > src/slave/http.cpp, line 831
> > <https://reviews.apache.org/r/56812/diff/2/?file=1641768#file1641768line831>
> >
> > so previously we were sending an empty subject (`Subject()`) but now we are sending `Option::None()` to `getObjectApprover`? what's the difference? i wish this change was done in a separate review instead of mixing it here with the use of auth context.
>
> Greg Mann wrote:
> Yes, the existing code is buggy. If authorization is enabled, but authentication is disabled (so that `principal` is `NONE`), then we end up default-constructing the authorization `Subject` instead of using `None()`. This creates a `Subject` with an empty string for its value.
>
> This means that if authorization is enabled, authentication is disabled, and an ACL has been set allowing a user called "" to do things, then requests which do not specify any Authorization header will be granted access incorrectly. Clearly, this is an extreme corner case, but a bug nonetheless.
>
> I didn't notice the bug until the reviews were already in flight, so I applied the change in these patches. If you like, I can create a patch before this one which applies the changes to make use of `None()` correctly, and then rebase onto that.
>
> Vinod Kone wrote:
> Yea, lets separate the patch out into dependent review. Will enable us to cherry pick it into older releases if needed.
New patch fixing the handlers can now be found earlier in this chain: https://reviews.apache.org/r/57054/
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/#review166636
-----------------------------------------------------------
On Feb. 24, 2017, 11:06 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56812/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 11:06 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in the
> agent process to accept an `AuthenticationContext`
> instead of an `Option<string>& principal`.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 94731ec883c309cefb811694dc4e39de12d1ac59
> src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2
> src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a
>
> Diff: https://reviews.apache.org/r/56812/diff/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56812: Updated agent handlers to use
'AuthenticationContext'.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Feb. 24, 2017, 2:07 a.m., Vinod Kone wrote:
> > src/slave/http.cpp, line 831
> > <https://reviews.apache.org/r/56812/diff/2/?file=1641768#file1641768line831>
> >
> > so previously we were sending an empty subject (`Subject()`) but now we are sending `Option::None()` to `getObjectApprover`? what's the difference? i wish this change was done in a separate review instead of mixing it here with the use of auth context.
Yes, the existing code is buggy. If authorization is enabled, but authentication is disabled (so that `principal` is `NONE`), then we end up default-constructing the authorization `Subject` instead of using `None()`. This creates a `Subject` with an empty string for its value.
This means that if authorization is enabled, authentication is disabled, and an ACL has been set allowing a user called "" to do things, then requests which do not specify any Authorization header will be granted access incorrectly. Clearly, this is an extreme corner case, but a bug nonetheless.
I didn't notice the bug until the reviews were already in flight, so I applied the change in these patches. If you like, I can create a patch before this one which applies the changes to make use of `None()` correctly, and then rebase onto that.
> On Feb. 24, 2017, 2:07 a.m., Vinod Kone wrote:
> > src/slave/http.cpp, line 836
> > <https://reviews.apache.org/r/56812/diff/2/?file=1641768#file1641768line836>
> >
> > not related to your change, but I'm curious why this method uses the object approver whereas the `Slave::Http::flags()` doesn't? cc @arojas
I'm guessing it's just for historical reasons; the old handler probably was not updated when the newer one was added?
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/#review166636
-----------------------------------------------------------
On Feb. 22, 2017, 1:18 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56812/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 1:18 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in the
> agent process to accept an `AuthenticationContext`
> instead of an `Option<string>& principal`.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 8a9fabf861369d3ae659dce21fa3932f6f7b9161
> src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2
> src/slave/slave.cpp 45905297836017e9031359894fc71e614c13cfcc
>
> Diff: https://reviews.apache.org/r/56812/diff/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56812: Updated agent handlers to use
'AuthenticationContext'.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/#review166636
-----------------------------------------------------------
src/slave/http.cpp (line 831)
<https://reviews.apache.org/r/56812/#comment238635>
so previously we were sending an empty subject (`Subject()`) but now we are sending `Option::None()` to `getObjectApprover`? what's the difference? i wish this change was done in a separate review instead of mixing it here with the use of auth context.
src/slave/http.cpp (line 833)
<https://reviews.apache.org/r/56812/#comment238638>
not related to your change, but I'm curious why this method uses the object approver whereas the `Slave::Http::flags()` doesn't? cc @arojas
src/slave/http.cpp (line 968)
<https://reviews.apache.org/r/56812/#comment238636>
ditto.
src/slave/http.cpp (line 1161)
<https://reviews.apache.org/r/56812/#comment238637>
ditto. here and everywhere else.
- Vinod Kone
On Feb. 22, 2017, 1:18 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56812/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 1:18 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in the
> agent process to accept an `AuthenticationContext`
> instead of an `Option<string>& principal`.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 8a9fabf861369d3ae659dce21fa3932f6f7b9161
> src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2
> src/slave/slave.cpp 45905297836017e9031359894fc71e614c13cfcc
>
> Diff: https://reviews.apache.org/r/56812/diff/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56812: Updated agent handlers to use the
'Principal' type.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/#review167902
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 3, 2017, 6:43 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56812/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 6:43 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in the
> agent process to accept the `Principal` type instead
> of an `Option<string>& principal`.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 94731ec883c309cefb811694dc4e39de12d1ac59
> src/slave/slave.hpp 449971b6b343c7714e1d1167a55bbdfe94d2cf83
> src/slave/slave.cpp 6ae9458cc81a7623a1837cd636156434a972004b
>
>
> Diff: https://reviews.apache.org/r/56812/diff/5/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56812: Updated agent handlers to use the
'Principal' type.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/
-----------------------------------------------------------
(Updated March 3, 2017, 6:43 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Changes
-------
Removed `createOptionalSubject()`.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch updates the HTTP endpoint handlers in the
agent process to accept the `Principal` type instead
of an `Option<string>& principal`.
Diffs (updated)
-----
src/slave/http.cpp 94731ec883c309cefb811694dc4e39de12d1ac59
src/slave/slave.hpp 449971b6b343c7714e1d1167a55bbdfe94d2cf83
src/slave/slave.cpp 6ae9458cc81a7623a1837cd636156434a972004b
Diff: https://reviews.apache.org/r/56812/diff/5/
Changes: https://reviews.apache.org/r/56812/diff/4-5/
Testing
-------
Testing details can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56812: Updated agent handlers to use the
'Principal' type.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/#review167058
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Feb. 28, 2017, 7:37 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56812/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 7:37 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in the
> agent process to accept the `Principal` type instead
> of an `Option<string>& principal`.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 94731ec883c309cefb811694dc4e39de12d1ac59
> src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2
> src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a
>
> Diff: https://reviews.apache.org/r/56812/diff/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56812: Updated agent handlers to use the
'Principal' type.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 6:37 a.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Changes
-------
Changed 'AuthenticationContext' to 'Principal'.
Summary (updated)
-----------------
Updated agent handlers to use the 'Principal' type.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description (updated)
-------
This patch updates the HTTP endpoint handlers in the
agent process to accept the `Principal` type instead
of an `Option<string>& principal`.
Diffs (updated)
-----
src/slave/http.cpp 94731ec883c309cefb811694dc4e39de12d1ac59
src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2
src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a
Diff: https://reviews.apache.org/r/56812/diff/
Testing
-------
Testing details can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56812: Updated agent handlers to use
'AuthenticationContext'.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/
-----------------------------------------------------------
(Updated Feb. 24, 2017, 11:06 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Changes
-------
Rebase.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch updates the HTTP endpoint handlers in the
agent process to accept an `AuthenticationContext`
instead of an `Option<string>& principal`.
Diffs (updated)
-----
src/slave/http.cpp 94731ec883c309cefb811694dc4e39de12d1ac59
src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2
src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a
Diff: https://reviews.apache.org/r/56812/diff/
Testing
-------
Testing details can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56812: Updated agent handlers to use
'AuthenticationContext'.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 1:18 a.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Changes
-------
Changed `context` to `authContext`.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch updates the HTTP endpoint handlers in the
agent process to accept an `AuthenticationContext`
instead of an `Option<string>& principal`.
Diffs (updated)
-----
src/slave/http.cpp 8a9fabf861369d3ae659dce21fa3932f6f7b9161
src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2
src/slave/slave.cpp 45905297836017e9031359894fc71e614c13cfcc
Diff: https://reviews.apache.org/r/56812/diff/
Testing
-------
Testing details can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56812: Updated agent handlers to use
'AuthenticationContext'.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56812/#review166123
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Feb. 17, 2017, 7:02 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56812/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2017, 7:02 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in the
> agent process to accept an `AuthenticationContext`
> instead of an `Option<string>& principal`.
>
>
> Diffs
> -----
>
> src/slave/http.cpp af70b6f294a04f23b04cd1d8c36c1c3e86d7d5e6
> src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2
> src/slave/slave.cpp 7564e8d39530794131dbbc928fcbc59fb65ef471
>
> Diff: https://reviews.apache.org/r/56812/diff/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>