You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/02/02 06:01:02 UTC
Re: Review Request 55973: Update the tests to handle MULTI_ROLE
support.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55973/#review163936
-----------------------------------------------------------
Ship it!
src/tests/hook_tests.cpp (line 1124)
<https://reviews.apache.org/r/55973/#comment235465>
```cpp
EXPECT_TRUE(resources.contains(
AllocatedResources(TEST_HOOK_ADDITIONAL_RESOURCES, allocationRole)));
```
src/tests/master_allocator_tests.cpp (lines 1727 - 1731)
<https://reviews.apache.org/r/55973/#comment235466>
It's not obvious to me that this is the same test.
I guess in this case it is, but perhaps consider preserving the test.
```cpp
auto unallocated = ...;
EXPECT_EQ(agentResources, unallocated(recoveredResources1.get()));
EXPECT_EQ(agentResources, unallocated(recoveredResources2.get()));
EXPECT_EQ(agentResources, unallocated(recoveredResources3.get()));
```
src/tests/resource_offers_tests.cpp (line 266)
<https://reviews.apache.org/r/55973/#comment235467>
Was this for debugging?
- Michael Park
On Jan. 26, 2017, 4:34 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55973/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 4:34 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A number of tests and example frameworks assume that allocated
> resources did not look different from unallocated resources.
> This updates the tests to reflect the presence of
> `Resource.AllocationInfo`.
>
>
> Diffs
> -----
>
> src/examples/disk_full_framework.cpp e13d4c8a427905793dda9bb01c52b6d372c19150
> src/examples/dynamic_reservation_framework.cpp 4d3db965e18d79ed3e1759bb5f6cb41104562f47
> src/examples/no_executor_framework.cpp e82ae9a9ea23c7d181b071f0e3f5071b3856d8a4
> src/examples/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a
> src/examples/test_framework.cpp 068b85d551012a390ba2a68bc88807103d3c31f3
> src/examples/test_http_framework.cpp 258cb512803d1ed07c7a5ce1465e5663e77b0977
> src/tests/api_tests.cpp 400ac6fcd420508509291249cad50679fbe9807d
> src/tests/containerizer/cgroups_isolator_tests.cpp ba268b6918be0e7226a975c38eff5620b076083f
> src/tests/hook_tests.cpp f4ef629768beabc014e14472c5818d117d51abe7
> src/tests/master_allocator_tests.cpp 996762f25453f7a8a5e0b7b97006ee2a603cf8c4
> src/tests/master_tests.cpp da7094dbbafbb0ab1153a0a4a6fcabd63888d67a
> src/tests/mesos.hpp 71e919702bccd31bf1e14205cd1e30d473883d48
> src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25
> src/tests/partition_tests.cpp f03c5bd96861b6643a4ecd9e37775447f86c3710
> src/tests/persistent_volume_endpoints_tests.cpp 695029fe0cb91d668d6a8495f3ccd0c69c883cd2
> src/tests/persistent_volume_tests.cpp 468a85b4a6ce09592341afd07ce12a03f5fc4f73
> src/tests/reservation_endpoints_tests.cpp 7bc59c2ded9f7e6f1ccaa37456f654d18efcb2e2
> src/tests/reservation_tests.cpp b7061de0dfcc79548d507c7d70376c82d5d647ec
> src/tests/resource_offers_tests.cpp 72ceb8696a7277f9add6d89adb55aa08665bdeb5
> src/tests/role_tests.cpp 0d0f1a94ff9aaec6ea04280282a52ac88dc6b273
> src/tests/slave_recovery_tests.cpp 9cf1d461cf5c6ac1f51ac963360a17e37f558505
>
> Diff: https://reviews.apache.org/r/55973/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 55973: Update the tests to handle MULTI_ROLE
support.
Posted by Benjamin Mahler <bm...@apache.org>.
> On Feb. 2, 2017, 6:01 a.m., Michael Park wrote:
> > src/tests/resource_offers_tests.cpp, line 266
> > <https://reviews.apache.org/r/55973/diff/1/?file=1617196#file1617196line266>
> >
> > Was this for debugging?
Yes, I had left it in since it seemed helpful for the next person.
> On Feb. 2, 2017, 6:01 a.m., Michael Park wrote:
> > src/tests/master_allocator_tests.cpp, lines 1733-1737
> > <https://reviews.apache.org/r/55973/diff/1/?file=1617187#file1617187line1733>
> >
> > It's not obvious to me that this is the same test.
> > I guess in this case it is, but perhaps consider preserving the test.
> >
> > ```cpp
> > auto unallocated = ...;
> >
> > EXPECT_EQ(agentResources, unallocated(recoveredResources1.get()));
> > EXPECT_EQ(agentResources, unallocated(recoveredResources2.get()));
> > EXPECT_EQ(agentResources, unallocated(recoveredResources3.get()));
> > ```
Will update it per your suggestion.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55973/#review163936
-----------------------------------------------------------
On Jan. 27, 2017, 12:34 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55973/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 12:34 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A number of tests and example frameworks assume that allocated
> resources did not look different from unallocated resources.
> This updates the tests to reflect the presence of
> `Resource.AllocationInfo`.
>
>
> Diffs
> -----
>
> src/examples/disk_full_framework.cpp e13d4c8a427905793dda9bb01c52b6d372c19150
> src/examples/dynamic_reservation_framework.cpp 4d3db965e18d79ed3e1759bb5f6cb41104562f47
> src/examples/no_executor_framework.cpp e82ae9a9ea23c7d181b071f0e3f5071b3856d8a4
> src/examples/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a
> src/examples/test_framework.cpp 068b85d551012a390ba2a68bc88807103d3c31f3
> src/examples/test_http_framework.cpp 258cb512803d1ed07c7a5ce1465e5663e77b0977
> src/tests/api_tests.cpp 400ac6fcd420508509291249cad50679fbe9807d
> src/tests/containerizer/cgroups_isolator_tests.cpp ba268b6918be0e7226a975c38eff5620b076083f
> src/tests/hook_tests.cpp f4ef629768beabc014e14472c5818d117d51abe7
> src/tests/master_allocator_tests.cpp 996762f25453f7a8a5e0b7b97006ee2a603cf8c4
> src/tests/master_tests.cpp da7094dbbafbb0ab1153a0a4a6fcabd63888d67a
> src/tests/mesos.hpp 71e919702bccd31bf1e14205cd1e30d473883d48
> src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25
> src/tests/partition_tests.cpp f03c5bd96861b6643a4ecd9e37775447f86c3710
> src/tests/persistent_volume_endpoints_tests.cpp 695029fe0cb91d668d6a8495f3ccd0c69c883cd2
> src/tests/persistent_volume_tests.cpp 468a85b4a6ce09592341afd07ce12a03f5fc4f73
> src/tests/reservation_endpoints_tests.cpp 7bc59c2ded9f7e6f1ccaa37456f654d18efcb2e2
> src/tests/reservation_tests.cpp b7061de0dfcc79548d507c7d70376c82d5d647ec
> src/tests/resource_offers_tests.cpp 72ceb8696a7277f9add6d89adb55aa08665bdeb5
> src/tests/role_tests.cpp 0d0f1a94ff9aaec6ea04280282a52ac88dc6b273
> src/tests/slave_recovery_tests.cpp 9cf1d461cf5c6ac1f51ac963360a17e37f558505
>
> Diff: https://reviews.apache.org/r/55973/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>