You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/02/06 23:17:53 UTC
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/
-----------------------------------------------------------
(Updated Feb. 6, 2017, 11:17 p.m.)
Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-6953
https://issues.apache.org/jira/browse/MESOS-6953
Repository: mesos
Description
-------
Test to ensure non-authorized users cannot launch tasks on agents.
Diffs (updated)
-----
src/tests/slave_tests.cpp 7f357a653335b559b5c78d4618926715dc4a63c7
Diff: https://reviews.apache.org/r/55888/diff/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Anindya Sinha <an...@apple.com>.
> On Feb. 21, 2017, 12:18 a.m., Jiang Yan Xu wrote:
> > Hey looks like slave_authorization_tests.cpp is more suitable place to put this test?
Fair enough. Moved the test to `slave_authorization_tests.cpp` in the latest update.
- Anindya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/#review166111
-----------------------------------------------------------
On Feb. 8, 2017, 3:54 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55888/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 3:54 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
>
>
> Bugs: MESOS-6953
> https://issues.apache.org/jira/browse/MESOS-6953
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test to ensure non-authorized users cannot launch tasks on agents.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 7f357a653335b559b5c78d4618926715dc4a63c7
>
> Diff: https://reviews.apache.org/r/55888/diff/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/#review166111
-----------------------------------------------------------
Hey looks like slave_authorization_tests.cpp is more suitable place to put this test?
- Jiang Yan Xu
On Feb. 7, 2017, 7:54 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55888/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 7:54 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
>
>
> Bugs: MESOS-6953
> https://issues.apache.org/jira/browse/MESOS-6953
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test to ensure non-authorized users cannot launch tasks on agents.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 7f357a653335b559b5c78d4618926715dc4a63c7
>
> Diff: https://reviews.apache.org/r/55888/diff/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Anindya Sinha <an...@apple.com>.
> On Feb. 20, 2017, 7:50 a.m., Jiang Yan Xu wrote:
> > src/tests/slave_tests.cpp, line 4965
> > <https://reviews.apache.org/r/55888/diff/3/?file=1627223#file1627223line4965>
> >
> > s/users/user/
`users` is fine since there are 2 users, i.e. `bar` and the current user.
- Anindya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/#review166035
-----------------------------------------------------------
On Feb. 8, 2017, 3:54 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55888/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 3:54 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
>
>
> Bugs: MESOS-6953
> https://issues.apache.org/jira/browse/MESOS-6953
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test to ensure non-authorized users cannot launch tasks on agents.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 7f357a653335b559b5c78d4618926715dc4a63c7
>
> Diff: https://reviews.apache.org/r/55888/diff/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/#review166035
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/slave_tests.cpp (lines 4952 - 4953)
<https://reviews.apache.org/r/55888/#comment237960>
"Authorize run task" is very broad. At least in the comment can we make clear that we are specifically testing using the RUN_TASK ACL to whitelist users?
src/tests/slave_tests.cpp (line 4958)
<https://reviews.apache.org/r/55888/#comment237934>
s/current/the current/
src/tests/slave_tests.cpp (line 4964)
<https://reviews.apache.org/r/55888/#comment237935>
s/current/the current/
src/tests/slave_tests.cpp (line 4965)
<https://reviews.apache.org/r/55888/#comment237936>
s/users/user/
src/tests/slave_tests.cpp (line 5040)
<https://reviews.apache.org/r/55888/#comment237937>
s/Status Updates/status updates/
src/tests/slave_tests.cpp (lines 5041 - 5054)
<https://reviews.apache.org/r/55888/#comment237941>
It feels that the following is more straightforward (which avoids the issue of ordering and looping/if conditions altogether).
```
hashmap<TaskID, TaskStatus> statues(
{{status1->task_id(), status1.get()},
{{status2->task_id(), status2.get()}}});
ASSERT_TRUE(statues.contains(task1.task_id());
EXPECT_EQ(TASK_ERROR, statues.at(task1.task_id()).state());
EXPECT_EQ(TaskStatus::SOURCE_SLAVE, statues.at(task1.task_id()).source());
EXPECT_EQ(TaskStatus::REASON_TASK_UNAUTHORIZED,
statues.at(task1.task_id()).reason());
ASSERT_TRUE(statues.contains(task2.task_id());
EXPECT_EQ(TASK_RUNNING, statues.at(task2.task_id()).state());
```
- Jiang Yan Xu
On Feb. 7, 2017, 7:54 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55888/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 7:54 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
>
>
> Bugs: MESOS-6953
> https://issues.apache.org/jira/browse/MESOS-6953
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test to ensure non-authorized users cannot launch tasks on agents.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 7f357a653335b559b5c78d4618926715dc4a63c7
>
> Diff: https://reviews.apache.org/r/55888/diff/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/#review167008
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55887, 55888]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 28, 2017, 1:18 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55888/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 1:18 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
>
>
> Bugs: MESOS-6953
> https://issues.apache.org/jira/browse/MESOS-6953
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test to ensure non-authorized users cannot launch tasks on agents.
>
>
> Diffs
> -----
>
> src/tests/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710
>
> Diff: https://reviews.apache.org/r/55888/diff/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/#review168433
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55887, 55888]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 9, 2017, 12:18 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55888/
> -----------------------------------------------------------
>
> (Updated March 9, 2017, 12:18 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
>
>
> Bugs: MESOS-6953
> https://issues.apache.org/jira/browse/MESOS-6953
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test to ensure non-authorized users cannot launch tasks on agents.
>
>
> Diffs
> -----
>
> src/tests/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710
>
>
> Diff: https://reviews.apache.org/r/55888/diff/9/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/#review168720
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55887, 55888]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 12, 2017, 8:05 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55888/
> -----------------------------------------------------------
>
> (Updated March 12, 2017, 8:05 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
>
>
> Bugs: MESOS-6953
> https://issues.apache.org/jira/browse/MESOS-6953
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test to ensure non-authorized users cannot launch tasks on agents.
>
>
> Diffs
> -----
>
> src/tests/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710
>
>
> Diff: https://reviews.apache.org/r/55888/diff/11/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/
-----------------------------------------------------------
(Updated March 12, 2017, 8:05 a.m.)
Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-6953
https://issues.apache.org/jira/browse/MESOS-6953
Repository: mesos
Description
-------
Test to ensure non-authorized users cannot launch tasks on agents.
Diffs (updated)
-----
src/tests/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710
Diff: https://reviews.apache.org/r/55888/diff/11/
Changes: https://reviews.apache.org/r/55888/diff/10-11/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/#review168704
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55887, 55888]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 10, 2017, 10:16 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55888/
> -----------------------------------------------------------
>
> (Updated March 10, 2017, 10:16 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
>
>
> Bugs: MESOS-6953
> https://issues.apache.org/jira/browse/MESOS-6953
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test to ensure non-authorized users cannot launch tasks on agents.
>
>
> Diffs
> -----
>
> src/tests/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710
>
>
> Diff: https://reviews.apache.org/r/55888/diff/10/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/
-----------------------------------------------------------
(Updated March 10, 2017, 10:16 p.m.)
Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-6953
https://issues.apache.org/jira/browse/MESOS-6953
Repository: mesos
Description
-------
Test to ensure non-authorized users cannot launch tasks on agents.
Diffs (updated)
-----
src/tests/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710
Diff: https://reviews.apache.org/r/55888/diff/10/
Changes: https://reviews.apache.org/r/55888/diff/9-10/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/
-----------------------------------------------------------
(Updated March 8, 2017, 11:18 p.m.)
Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
Bugs: MESOS-6953
https://issues.apache.org/jira/browse/MESOS-6953
Repository: mesos
Description
-------
Test to ensure non-authorized users cannot launch tasks on agents.
Diffs (updated)
-----
src/tests/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710
Diff: https://reviews.apache.org/r/55888/diff/9/
Changes: https://reviews.apache.org/r/55888/diff/8-9/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/
-----------------------------------------------------------
(Updated March 7, 2017, 11:19 p.m.)
Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-6953
https://issues.apache.org/jira/browse/MESOS-6953
Repository: mesos
Description
-------
Test to ensure non-authorized users cannot launch tasks on agents.
Diffs (updated)
-----
src/tests/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710
Diff: https://reviews.apache.org/r/55888/diff/8/
Changes: https://reviews.apache.org/r/55888/diff/7-8/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/#review167870
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55887, 55888]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 3, 2017, 8:09 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55888/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 8:09 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
>
>
> Bugs: MESOS-6953
> https://issues.apache.org/jira/browse/MESOS-6953
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test to ensure non-authorized users cannot launch tasks on agents.
>
>
> Diffs
> -----
>
> src/tests/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710
>
>
> Diff: https://reviews.apache.org/r/55888/diff/7/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/
-----------------------------------------------------------
(Updated March 3, 2017, 8:09 p.m.)
Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-6953
https://issues.apache.org/jira/browse/MESOS-6953
Repository: mesos
Description
-------
Test to ensure non-authorized users cannot launch tasks on agents.
Diffs (updated)
-----
src/tests/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710
Diff: https://reviews.apache.org/r/55888/diff/7/
Changes: https://reviews.apache.org/r/55888/diff/6-7/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/#review167592
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55887, 55888]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 1, 2017, 4:15 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55888/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 4:15 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
>
>
> Bugs: MESOS-6953
> https://issues.apache.org/jira/browse/MESOS-6953
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test to ensure non-authorized users cannot launch tasks on agents.
>
>
> Diffs
> -----
>
> src/tests/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710
>
>
> Diff: https://reviews.apache.org/r/55888/diff/6/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/
-----------------------------------------------------------
(Updated March 1, 2017, 4:15 p.m.)
Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
Changes
-------
Rebase.
Bugs: MESOS-6953
https://issues.apache.org/jira/browse/MESOS-6953
Repository: mesos
Description
-------
Test to ensure non-authorized users cannot launch tasks on agents.
Diffs (updated)
-----
src/tests/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710
Diff: https://reviews.apache.org/r/55888/diff/6/
Changes: https://reviews.apache.org/r/55888/diff/5-6/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 1:18 a.m.)
Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
Changes
-------
Changed status update from TASK_FAILED to TASK_ERROR.
Bugs: MESOS-6953
https://issues.apache.org/jira/browse/MESOS-6953
Repository: mesos
Description
-------
Test to ensure non-authorized users cannot launch tasks on agents.
Diffs (updated)
-----
src/tests/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710
Diff: https://reviews.apache.org/r/55888/diff/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/#review166133
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55887, 55888]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 21, 2017, 7:21 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55888/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 7:21 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
>
>
> Bugs: MESOS-6953
> https://issues.apache.org/jira/browse/MESOS-6953
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test to ensure non-authorized users cannot launch tasks on agents.
>
>
> Diffs
> -----
>
> src/tests/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710
>
> Diff: https://reviews.apache.org/r/55888/diff/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/
-----------------------------------------------------------
(Updated Feb. 21, 2017, 7:21 a.m.)
Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
Changes
-------
Addressed review comments.
Bugs: MESOS-6953
https://issues.apache.org/jira/browse/MESOS-6953
Repository: mesos
Description
-------
Test to ensure non-authorized users cannot launch tasks on agents.
Diffs (updated)
-----
src/tests/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710
Diff: https://reviews.apache.org/r/55888/diff/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/#review164686
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55887, 55888]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 8, 2017, 3:54 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55888/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 3:54 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
>
>
> Bugs: MESOS-6953
> https://issues.apache.org/jira/browse/MESOS-6953
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test to ensure non-authorized users cannot launch tasks on agents.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 7f357a653335b559b5c78d4618926715dc4a63c7
>
> Diff: https://reviews.apache.org/r/55888/diff/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 55888: Test to ensure non-authorized users cannot
launch tasks on agents.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55888/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 3:54 a.m.)
Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu.
Changes
-------
Used `os::user()` instead of `os::getenv("USER")` to get current user.
Bugs: MESOS-6953
https://issues.apache.org/jira/browse/MESOS-6953
Repository: mesos
Description
-------
Test to ensure non-authorized users cannot launch tasks on agents.
Diffs (updated)
-----
src/tests/slave_tests.cpp 7f357a653335b559b5c78d4618926715dc4a63c7
Diff: https://reviews.apache.org/r/55888/diff/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha