You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/02/07 22:18:45 UTC
Review Request 56410: Increased granularity of environment handling in
command executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56410/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Kevin Klues.
Bugs: MESOS-7027
https://issues.apache.org/jira/browse/MESOS-7027
Repository: mesos
Description
-------
This adds a new flag to the command executor `--task_environment`
which allows isolators to specify additionaly environment the task
should be given. This flag is subject to the same priority as other
environment. User-specified environment is first, isolator's second,
and agent environment last (i.e. `os::environment` from the executor's
context).
This also changes how the task itself receives these environment
variables. The task is now given the environment explicitly, rather
than inheriting the executor's environment. This will help prevent
isolators from accidently breaking the command executor or health
checks with task-specific environment variables.
Diffs
-----
src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9
src/launcher/posix/executor.hpp d057ff6211a77e681ee80599d2ec5851a2fa6785
src/launcher/posix/executor.cpp 4bc0b0f1a09bf1579ff9612f812f09a3061883ce
Diff: https://reviews.apache.org/r/56410/diff/
Testing
-------
Testing later in the chain.
Thanks,
Joseph Wu
Re: Review Request 56410: Increased granularity of environment
handling in command executor.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56410/#review169300
-----------------------------------------------------------
src/launcher/executor.cpp
Lines 396-397 (patched)
<https://reviews.apache.org/r/56410/#comment241651>
This comment is misleading as the below "MergeFrom" does actually concatenate and in no way hash.
- Till Toenshoff
On Feb. 8, 2017, 12:58 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56410/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 12:58 a.m.)
>
>
> Review request for mesos, Jie Yu and Kevin Klues.
>
>
> Bugs: MESOS-7027
> https://issues.apache.org/jira/browse/MESOS-7027
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new flag to the command executor `--task_environment`
> which allows isolators to specify additionaly environment the task
> should be given. This flag is subject to the same priority as other
> environment. User-specified environment is first, isolator's second,
> and agent environment last (i.e. `os::environment` from the executor's
> context).
>
> This also changes how the task itself receives these environment
> variables. The task is now given the environment explicitly, rather
> than inheriting the executor's environment. This will help prevent
> isolators from accidently breaking the command executor or health
> checks with task-specific environment variables.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9
> src/launcher/posix/executor.hpp d057ff6211a77e681ee80599d2ec5851a2fa6785
> src/launcher/posix/executor.cpp 4bc0b0f1a09bf1579ff9612f812f09a3061883ce
>
>
> Diff: https://reviews.apache.org/r/56410/diff/2/
>
>
> Testing
> -------
>
> Testing later in the chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 56410: Increased granularity of environment
handling in command executor.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56410/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 4:58 p.m.)
Review request for mesos, Jie Yu and Kevin Klues.
Changes
-------
Added a TODO for Windows.
Bugs: MESOS-7027
https://issues.apache.org/jira/browse/MESOS-7027
Repository: mesos
Description
-------
This adds a new flag to the command executor `--task_environment`
which allows isolators to specify additionaly environment the task
should be given. This flag is subject to the same priority as other
environment. User-specified environment is first, isolator's second,
and agent environment last (i.e. `os::environment` from the executor's
context).
This also changes how the task itself receives these environment
variables. The task is now given the environment explicitly, rather
than inheriting the executor's environment. This will help prevent
isolators from accidently breaking the command executor or health
checks with task-specific environment variables.
Diffs (updated)
-----
src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9
src/launcher/posix/executor.hpp d057ff6211a77e681ee80599d2ec5851a2fa6785
src/launcher/posix/executor.cpp 4bc0b0f1a09bf1579ff9612f812f09a3061883ce
Diff: https://reviews.apache.org/r/56410/diff/
Testing
-------
Testing later in the chain.
Thanks,
Joseph Wu
Re: Review Request 56410: Increased granularity of environment
handling in command executor.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Feb. 7, 2017, 3:56 p.m., Jie Yu wrote:
> > Ship It!
Adding a TODO for the Windows portion before I commit (as we discussed offline).
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56410/#review164590
-----------------------------------------------------------
On Feb. 7, 2017, 2:18 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56410/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 2:18 p.m.)
>
>
> Review request for mesos, Jie Yu and Kevin Klues.
>
>
> Bugs: MESOS-7027
> https://issues.apache.org/jira/browse/MESOS-7027
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new flag to the command executor `--task_environment`
> which allows isolators to specify additionaly environment the task
> should be given. This flag is subject to the same priority as other
> environment. User-specified environment is first, isolator's second,
> and agent environment last (i.e. `os::environment` from the executor's
> context).
>
> This also changes how the task itself receives these environment
> variables. The task is now given the environment explicitly, rather
> than inheriting the executor's environment. This will help prevent
> isolators from accidently breaking the command executor or health
> checks with task-specific environment variables.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9
> src/launcher/posix/executor.hpp d057ff6211a77e681ee80599d2ec5851a2fa6785
> src/launcher/posix/executor.cpp 4bc0b0f1a09bf1579ff9612f812f09a3061883ce
>
> Diff: https://reviews.apache.org/r/56410/diff/
>
>
> Testing
> -------
>
> Testing later in the chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 56410: Increased granularity of environment
handling in command executor.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56410/#review164590
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 7, 2017, 10:18 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56410/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 10:18 p.m.)
>
>
> Review request for mesos, Jie Yu and Kevin Klues.
>
>
> Bugs: MESOS-7027
> https://issues.apache.org/jira/browse/MESOS-7027
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a new flag to the command executor `--task_environment`
> which allows isolators to specify additionaly environment the task
> should be given. This flag is subject to the same priority as other
> environment. User-specified environment is first, isolator's second,
> and agent environment last (i.e. `os::environment` from the executor's
> context).
>
> This also changes how the task itself receives these environment
> variables. The task is now given the environment explicitly, rather
> than inheriting the executor's environment. This will help prevent
> isolators from accidently breaking the command executor or health
> checks with task-specific environment variables.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9
> src/launcher/posix/executor.hpp d057ff6211a77e681ee80599d2ec5851a2fa6785
> src/launcher/posix/executor.cpp 4bc0b0f1a09bf1579ff9612f812f09a3061883ce
>
> Diff: https://reviews.apache.org/r/56410/diff/
>
>
> Testing
> -------
>
> Testing later in the chain.
>
>
> Thanks,
>
> Joseph Wu
>
>