You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/02/28 18:28:48 UTC
Re: Review Request 56623: Implemented the 'Principal' type in
libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56623/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 6:28 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Changes
-------
Addressed comments.
Summary (updated)
-----------------
Implemented the 'Principal' type in libprocess.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch adds a new struct, `Principal`, to libprocess
to represent an authenticated entity in the system.
The new type contains a string `value` and a map containing
arbitrary key-value pairs.
Diffs (updated)
-----
3rdparty/libprocess/include/process/authenticator.hpp e5489c6cb4adc8a822e7dd4515542618c36136f9
3rdparty/libprocess/include/process/http.hpp eb2c87dee2a911085592e0e14a7499d526ad0bfc
3rdparty/libprocess/include/process/process.hpp ceedbe86ccba5c24bf1e9e7f032d7dbcf6acb0f3
3rdparty/libprocess/src/authenticator.cpp cfedb6f7674e0f6690e77a633cdd1bd494c7d2c7
3rdparty/libprocess/src/authenticator_manager.cpp a22acd026a001788dc39b8005a56577e33c6800b
3rdparty/libprocess/src/process.cpp 3ad485f9136cd9edf0a6db76ff1f475039236391
Diff: https://reviews.apache.org/r/56623/diff/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56623: Implemented the 'Principal' type in
libprocess.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56623/#review167805
-----------------------------------------------------------
LGTM
3rdparty/libprocess/include/process/http.hpp
Line 106 (original), 108 (patched)
<https://reviews.apache.org/r/56623/#comment239791>
"authentication principal"?
- Adam B
On Feb. 28, 2017, 10:28 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56623/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 10:28 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new struct, `Principal`, to libprocess
> to represent an authenticated entity in the system.
> The new type contains a string `value` and a map containing
> arbitrary key-value pairs.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/authenticator.hpp e5489c6cb4adc8a822e7dd4515542618c36136f9
> 3rdparty/libprocess/include/process/http.hpp eb2c87dee2a911085592e0e14a7499d526ad0bfc
> 3rdparty/libprocess/include/process/process.hpp ceedbe86ccba5c24bf1e9e7f032d7dbcf6acb0f3
> 3rdparty/libprocess/src/authenticator.cpp cfedb6f7674e0f6690e77a633cdd1bd494c7d2c7
> 3rdparty/libprocess/src/authenticator_manager.cpp a22acd026a001788dc39b8005a56577e33c6800b
> 3rdparty/libprocess/src/process.cpp 3ad485f9136cd9edf0a6db76ff1f475039236391
>
>
> Diff: https://reviews.apache.org/r/56623/diff/9/
>
>
> Testing
> -------
>
> Testing information can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56623: Implemented the 'Principal' type in
libprocess.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56623/#review167889
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/src/authenticator.cpp
Lines 53-55 (patched)
<https://reviews.apache.org/r/56623/#comment239866>
I think you can combine these 2 statements
```
return stream << principal.value.get();
```
3rdparty/libprocess/src/authenticator.cpp
Lines 58-60 (patched)
<https://reviews.apache.org/r/56623/#comment239867>
ditto.
3rdparty/libprocess/src/authenticator_manager.cpp
Lines 111 (patched)
<https://reviews.apache.org/r/56623/#comment239868>
space before "of" ?
- Vinod Kone
On March 3, 2017, 6:36 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56623/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 6:36 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new struct, `Principal`, to libprocess
> to represent an authenticated entity in the system.
> The new type contains a string `value` and a map containing
> arbitrary key-value pairs.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/authenticator.hpp e5489c6cb4adc8a822e7dd4515542618c36136f9
> 3rdparty/libprocess/include/process/http.hpp eb2c87dee2a911085592e0e14a7499d526ad0bfc
> 3rdparty/libprocess/include/process/process.hpp ceedbe86ccba5c24bf1e9e7f032d7dbcf6acb0f3
> 3rdparty/libprocess/src/authenticator.cpp cfedb6f7674e0f6690e77a633cdd1bd494c7d2c7
> 3rdparty/libprocess/src/authenticator_manager.cpp a22acd026a001788dc39b8005a56577e33c6800b
> 3rdparty/libprocess/src/process.cpp 3ad485f9136cd9edf0a6db76ff1f475039236391
>
>
> Diff: https://reviews.apache.org/r/56623/diff/10/
>
>
> Testing
> -------
>
> Testing information can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56623: Implemented the 'Principal' type in
libprocess.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56623/
-----------------------------------------------------------
(Updated March 4, 2017, 1:37 a.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Changes
-------
Deleted the default constructor for `Principal`.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch adds a new struct, `Principal`, to libprocess
to represent an authenticated entity in the system.
The new type contains a string `value` and a map containing
arbitrary key-value pairs.
Diffs (updated)
-----
3rdparty/libprocess/include/process/authenticator.hpp e5489c6cb4adc8a822e7dd4515542618c36136f9
3rdparty/libprocess/include/process/http.hpp eb2c87dee2a911085592e0e14a7499d526ad0bfc
3rdparty/libprocess/include/process/process.hpp ceedbe86ccba5c24bf1e9e7f032d7dbcf6acb0f3
3rdparty/libprocess/src/authenticator.cpp cfedb6f7674e0f6690e77a633cdd1bd494c7d2c7
3rdparty/libprocess/src/authenticator_manager.cpp a22acd026a001788dc39b8005a56577e33c6800b
3rdparty/libprocess/src/process.cpp 3ad485f9136cd9edf0a6db76ff1f475039236391
Diff: https://reviews.apache.org/r/56623/diff/12/
Changes: https://reviews.apache.org/r/56623/diff/11-12/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56623: Implemented the 'Principal' type in
libprocess.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56623/
-----------------------------------------------------------
(Updated March 3, 2017, 11:39 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch adds a new struct, `Principal`, to libprocess
to represent an authenticated entity in the system.
The new type contains a string `value` and a map containing
arbitrary key-value pairs.
Diffs (updated)
-----
3rdparty/libprocess/include/process/authenticator.hpp e5489c6cb4adc8a822e7dd4515542618c36136f9
3rdparty/libprocess/include/process/http.hpp eb2c87dee2a911085592e0e14a7499d526ad0bfc
3rdparty/libprocess/include/process/process.hpp ceedbe86ccba5c24bf1e9e7f032d7dbcf6acb0f3
3rdparty/libprocess/src/authenticator.cpp cfedb6f7674e0f6690e77a633cdd1bd494c7d2c7
3rdparty/libprocess/src/authenticator_manager.cpp a22acd026a001788dc39b8005a56577e33c6800b
3rdparty/libprocess/src/process.cpp 3ad485f9136cd9edf0a6db76ff1f475039236391
Diff: https://reviews.apache.org/r/56623/diff/11/
Changes: https://reviews.apache.org/r/56623/diff/10-11/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56623: Implemented the 'Principal' type in
libprocess.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56623/
-----------------------------------------------------------
(Updated March 3, 2017, 6:36 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Changes
-------
Updated `operator<<`, added more principal validation.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch adds a new struct, `Principal`, to libprocess
to represent an authenticated entity in the system.
The new type contains a string `value` and a map containing
arbitrary key-value pairs.
Diffs (updated)
-----
3rdparty/libprocess/include/process/authenticator.hpp e5489c6cb4adc8a822e7dd4515542618c36136f9
3rdparty/libprocess/include/process/http.hpp eb2c87dee2a911085592e0e14a7499d526ad0bfc
3rdparty/libprocess/include/process/process.hpp ceedbe86ccba5c24bf1e9e7f032d7dbcf6acb0f3
3rdparty/libprocess/src/authenticator.cpp cfedb6f7674e0f6690e77a633cdd1bd494c7d2c7
3rdparty/libprocess/src/authenticator_manager.cpp a22acd026a001788dc39b8005a56577e33c6800b
3rdparty/libprocess/src/process.cpp 3ad485f9136cd9edf0a6db76ff1f475039236391
Diff: https://reviews.apache.org/r/56623/diff/10/
Changes: https://reviews.apache.org/r/56623/diff/9-10/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann