You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.com> on 2017/02/03 19:50:51 UTC
Review Request 56288: Improved the wording of what's logged on command
health check timeouts.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56288/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.
Bugs: MESOS-6280
https://issues.apache.org/jira/browse/MESOS-6280
Repository: mesos
Description
-------
Improved the wording of what's logged on command health check timeouts.
Diffs
-----
src/checks/health_checker.cpp 58380dc18896f659aa9c4fb4bb567a55bba97f6b
Diff: https://reviews.apache.org/r/56288/diff/
Testing
-------
None, not a functional change.
Thanks,
Gast�n Kleiman
Re: Review Request 56288: Improved the wording of what's logged on
command health check timeouts.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56288/
-----------------------------------------------------------
(Updated March 15, 2017, 4:22 p.m.)
Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.
Bugs: MESOS-6280
https://issues.apache.org/jira/browse/MESOS-6280
Repository: mesos
Description (updated)
-------
Improved the wording of what's logged on command health check timeouts.
Diffs (updated)
-----
src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1
Diff: https://reviews.apache.org/r/56288/diff/5/
Changes: https://reviews.apache.org/r/56288/diff/4-5/
Testing
-------
None, not a functional change.
Thanks,
Gast�n Kleiman
Re: Review Request 56288: Improved the wording of what's logged on
command health check timeouts.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56288/
-----------------------------------------------------------
(Updated March 15, 2017, 2:58 p.m.)
Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.
Changes
-------
Rebase.
Bugs: MESOS-6280
https://issues.apache.org/jira/browse/MESOS-6280
Repository: mesos
Description (updated)
-------
See the summary.
Diffs (updated)
-----
src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1
Diff: https://reviews.apache.org/r/56288/diff/4/
Changes: https://reviews.apache.org/r/56288/diff/3-4/
Testing
-------
None, not a functional change.
Thanks,
Gast�n Kleiman
Re: Review Request 56288: Improved the wording of what's logged on
command health check timeouts.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56288/
-----------------------------------------------------------
(Updated Feb. 16, 2017, 2:58 p.m.)
Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-6280
https://issues.apache.org/jira/browse/MESOS-6280
Repository: mesos
Description
-------
Improved the wording of what's logged on command health check timeouts.
Diffs (updated)
-----
src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1
Diff: https://reviews.apache.org/r/56288/diff/
Testing
-------
None, not a functional change.
Thanks,
Gast�n Kleiman
Re: Review Request 56288: Improved the wording of what's logged on
command health check timeouts.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56288/#review165624
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 10, 2017, 11:17 a.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56288/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 11:17 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-6280
> https://issues.apache.org/jira/browse/MESOS-6280
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved the wording of what's logged on command health check timeouts.
>
>
> Diffs
> -----
>
> src/checks/health_checker.cpp a5225ff1f4b071ed4182d41fa8ecc705fa4dbe00
>
> Diff: https://reviews.apache.org/r/56288/diff/
>
>
> Testing
> -------
>
> None, not a functional change.
>
>
> Thanks,
>
> Gast�n Kleiman
>
>
Re: Review Request 56288: Improved the wording of what's logged on
command health check timeouts.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56288/
-----------------------------------------------------------
(Updated Feb. 10, 2017, 11:17 a.m.)
Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.
Changes
-------
Updated another logging message.
Bugs: MESOS-6280
https://issues.apache.org/jira/browse/MESOS-6280
Repository: mesos
Description
-------
Improved the wording of what's logged on command health check timeouts.
Diffs (updated)
-----
src/checks/health_checker.cpp a5225ff1f4b071ed4182d41fa8ecc705fa4dbe00
Diff: https://reviews.apache.org/r/56288/diff/
Testing
-------
None, not a functional change.
Thanks,
Gast�n Kleiman
Re: Review Request 56288: Improved the wording of what's logged on
command health check timeouts.
Posted by haosdent huang <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56288/#review164314
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Feb. 3, 2017, 7:50 p.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56288/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2017, 7:50 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-6280
> https://issues.apache.org/jira/browse/MESOS-6280
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved the wording of what's logged on command health check timeouts.
>
>
> Diffs
> -----
>
> src/checks/health_checker.cpp 58380dc18896f659aa9c4fb4bb567a55bba97f6b
>
> Diff: https://reviews.apache.org/r/56288/diff/
>
>
> Testing
> -------
>
> None, not a functional change.
>
>
> Thanks,
>
> Gast�n Kleiman
>
>
Re: Review Request 56288: Improved the wording of what's logged on
command health check timeouts.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56288/#review164689
-----------------------------------------------------------
src/checks/health_checker.cpp (lines 401 - 403)
<https://reviews.apache.org/r/56288/#comment236457>
What about this one?
- Alexander Rukletsov
On Feb. 3, 2017, 7:50 p.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56288/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2017, 7:50 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-6280
> https://issues.apache.org/jira/browse/MESOS-6280
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved the wording of what's logged on command health check timeouts.
>
>
> Diffs
> -----
>
> src/checks/health_checker.cpp 58380dc18896f659aa9c4fb4bb567a55bba97f6b
>
> Diff: https://reviews.apache.org/r/56288/diff/
>
>
> Testing
> -------
>
> None, not a functional change.
>
>
> Thanks,
>
> Gast�n Kleiman
>
>