You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2017/02/15 13:01:15 UTC
Re: Review Request 54783: Adds authorization tests of launching
container sessions API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54783/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 2:01 p.m.)
Review request for mesos and Adam B.
Summary (updated)
-----------------
Adds authorization tests of launching container sessions API.
Bugs: MESOS-6886
https://issues.apache.org/jira/browse/MESOS-6886
Repository: mesos
Description (updated)
-------
Introduces a test which ensures that unauthorized users are unable to
launch nested container sessions.
Diffs (updated)
-----
src/tests/api_tests.cpp aa7d89a710400d1460bc9139ea563cfdd45bd58f
Diff: https://reviews.apache.org/r/54783/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 54783: Adds authorization tests of launching
container sessions API.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54783/#review166120
-----------------------------------------------------------
Ship it!
Looks like a fine test of unauthorized access. Authorized access is tested by `AgentAPITest.LaunchNestedContainerSession`
- Adam B
On Feb. 15, 2017, 6:30 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54783/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 6:30 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-6886
> https://issues.apache.org/jira/browse/MESOS-6886
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduces a test which ensures that unauthorized users are unable to
> launch nested container sessions.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp aa7d89a710400d1460bc9139ea563cfdd45bd58f
>
> Diff: https://reviews.apache.org/r/54783/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 54783: Adds authorization tests of launching
container sessions API.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54783/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 3:30 p.m.)
Review request for mesos and Adam B.
Changes
-------
Test doesn't need to be disabled by default (unless required).
Bugs: MESOS-6886
https://issues.apache.org/jira/browse/MESOS-6886
Repository: mesos
Description
-------
Introduces a test which ensures that unauthorized users are unable to
launch nested container sessions.
Diffs (updated)
-----
src/tests/api_tests.cpp aa7d89a710400d1460bc9139ea563cfdd45bd58f
Diff: https://reviews.apache.org/r/54783/diff/
Testing
-------
make check
Thanks,
Alexander Rojas