You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Will Rouesnel <w....@gmail.com> on 2017/02/13 22:42:18 UTC
Re: Review Request 51258: Add documentation for the
ExternalContainerLogger module.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51258/
-----------------------------------------------------------
(Updated Feb. 13, 2017, 10:42 p.m.)
Review request for mesos and Joseph Wu.
Changes
-------
Update documentation to include the MESOS_LOG_USER setting.
Repository: mesos
Description
-------
Add documentation for the ExternalContainerLogger module.
Diffs (updated)
-----
docs/logging.md 75c438570694c974c077296d925059469b4d344c
Diff: https://reviews.apache.org/r/51258/diff/
Testing
-------
Markdown is valid and parses correctly.
Thanks,
Will Rouesnel
Re: Review Request 51258: Add documentation for the
ExternalContainerLogger module.
Posted by Srdjan Grubor <sg...@sgnn7.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51258/#review173118
-----------------------------------------------------------
This didn't build on master since the new objects use ContainerIO instead of SubprocessInfo - I have a fixup patch though that you can apply at https://github.com/endlessm/mesos/commit/46370660a2ef6fea2caf926d822e0e76aaac2917.patch
- Srdjan Grubor
On Feb. 13, 2017, 10:42 p.m., Will Rouesnel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51258/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 10:42 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add documentation for the ExternalContainerLogger module.
>
>
> Diffs
> -----
>
> docs/logging.md 75c438570694c974c077296d925059469b4d344c
>
>
> Diff: https://reviews.apache.org/r/51258/diff/6/
>
>
> Testing
> -------
>
> Markdown is valid and parses correctly.
>
>
> Thanks,
>
> Will Rouesnel
>
>
Re: Review Request 51258: Add documentation for the
ExternalContainerLogger module.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51258/#review165407
-----------------------------------------------------------
Patch looks great!
Reviews applied: [51257, 51258]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 13, 2017, 10:42 p.m., Will Rouesnel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51258/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 10:42 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add documentation for the ExternalContainerLogger module.
>
>
> Diffs
> -----
>
> docs/logging.md 75c438570694c974c077296d925059469b4d344c
>
> Diff: https://reviews.apache.org/r/51258/diff/
>
>
> Testing
> -------
>
> Markdown is valid and parses correctly.
>
>
> Thanks,
>
> Will Rouesnel
>
>