You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Tomasz Janiszewski <ja...@gmail.com> on 2017/02/20 11:00:26 UTC
Review Request 56847: Remove unecessary leveldb build rule.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56847/
-----------------------------------------------------------
Review request for mesos and haosdent huang.
Repository: mesos
Description
-------
Remove unecessary leveldb build rule.
Diffs
-----
3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9
Diff: https://reviews.apache.org/r/56847/diff/
Testing
-------
Thanks,
Tomasz Janiszewski
Re: Review Request 56847: Removed unnecessary leveldb build rules.
Posted by haosdent huang <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56847/#review166098
-----------------------------------------------------------
Ship it!
I adjust to only build `libleveldb.a`
```
-all: $(SHARED_LIBS) $(SHARED_PROGRAMS) $(STATIC_OUTDIR)/libleveldb.a $(STATIC_OUTDIR)/libmemenv.a $(STATIC_PROGRAMS)
+all: $(STATIC_OUTDIR)/libleveldb.a
``
- haosdent huang
On Feb. 20, 2017, 4:45 p.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56847/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2017, 4:45 p.m.)
>
>
> Review request for mesos and haosdent huang.
>
>
> Bugs: MESOS-7146
> https://issues.apache.org/jira/browse/MESOS-7146
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After upgraded to leveldb 1.19, the default CXXFLAGS of Mesos conflict
> with the require flags when building `db/c_test.c` with clang in macOS.
> This patch disables unnecessary rules in leveldb and bypass build
> failures in macOS.
>
>
> Diffs
> -----
>
> 3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9
>
> Diff: https://reviews.apache.org/r/56847/diff/
>
>
> Testing
> -------
>
> `make -j8` in macOS.
> `make -j24 GTEST_FILTER="*"` in CentOS 7.
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 56847: Removed unnecessary leveldb build rules.
Posted by Tomasz Janiszewski <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56847/
-----------------------------------------------------------
(Updated Feb. 20, 2017, 4:45 p.m.)
Review request for mesos and haosdent huang.
Bugs: MESOS-7146
https://issues.apache.org/jira/browse/MESOS-7146
Repository: mesos
Description (updated)
-------
After upgraded to leveldb 1.19, the default CXXFLAGS of Mesos conflict
with the require flags when building `db/c_test.c` with clang in macOS.
This patch disables unnecessary rules in leveldb and bypass build
failures in macOS.
Diffs (updated)
-----
3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9
Diff: https://reviews.apache.org/r/56847/diff/
Testing (updated)
-------
`make -j8` in macOS.
`make -j24 GTEST_FILTER="*"` in CentOS 7.
Thanks,
Tomasz Janiszewski
Re: Review Request 56847: Removed unnecessary leveldb build rules.
Posted by Tomasz Janiszewski <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56847/
-----------------------------------------------------------
(Updated Feb. 20, 2017, 4:35 p.m.)
Review request for mesos and haosdent huang.
Bugs: MESOS-7146
https://issues.apache.org/jira/browse/MESOS-7146
Repository: mesos
Description
-------
After upgraded to leveldb 1.19, the default CXXFLAGS of Mesos conflict
with the require flags when building `db/c_test.c` with clang in macOS.
This patch disables unnecessary rules in leveldb and bypass build
failures in macOS.
Diffs
-----
3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9
Diff: https://reviews.apache.org/r/56847/diff/
Testing
-------
Thanks,
Tomasz Janiszewski
Re: Review Request 56847: Removed unnecessary leveldb build rules.
Posted by Tomasz Janiszewski <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56847/
-----------------------------------------------------------
(Updated Feb. 20, 2017, 4:33 p.m.)
Review request for mesos and haosdent huang.
Summary (updated)
-----------------
Removed unnecessary leveldb build rules.
Repository: mesos
Description (updated)
-------
After upgraded to leveldb 1.19, the default CXXFLAGS of Mesos conflict
with the require flags when building `db/c_test.c` with clang in macOS.
This patch disables unnecessary rules in leveldb and bypass build
failures in macOS.
Diffs
-----
3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9
Diff: https://reviews.apache.org/r/56847/diff/
Testing
-------
Thanks,
Tomasz Janiszewski
Re: Review Request 56847: Remove unecessary leveldb build rule.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56847/#review166091
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56847]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 20, 2017, 11:52 a.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56847/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2017, 11:52 a.m.)
>
>
> Review request for mesos and haosdent huang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove unecessary leveldb build rule.
>
>
> Diffs
> -----
>
> 3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9
>
> Diff: https://reviews.apache.org/r/56847/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 56847: Remove unecessary leveldb build rule.
Posted by haosdent huang <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56847/#review166096
-----------------------------------------------------------
According to my test, apply this change should be enough.
```
-all: $(SHARED_LIBS) $(SHARED_PROGRAMS) $(STATIC_OUTDIR)/libleveldb.a $(STATIC_OUTDIR)/libmemenv.a $(STATIC_PROGRAMS)
+all: $(STATIC_OUTDIR)/libleveldb.a
```
- haosdent huang
On Feb. 20, 2017, 11:52 a.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56847/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2017, 11:52 a.m.)
>
>
> Review request for mesos and haosdent huang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove unecessary leveldb build rule.
>
>
> Diffs
> -----
>
> 3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9
>
> Diff: https://reviews.apache.org/r/56847/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 56847: Remove unecessary leveldb build rule.
Posted by Tomasz Janiszewski <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56847/
-----------------------------------------------------------
(Updated Feb. 20, 2017, 11:52 a.m.)
Review request for mesos and haosdent huang.
Repository: mesos
Description
-------
Remove unecessary leveldb build rule.
Diffs (updated)
-----
3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9
Diff: https://reviews.apache.org/r/56847/diff/
Testing
-------
Thanks,
Tomasz Janiszewski