You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/02/24 01:27:08 UTC

Review Request 57013: Expose offer allocation info within the master /state endpoint.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57013/
-----------------------------------------------------------

Review request for mesos, Jay Guo and Michael Park.


Repository: mesos


Description
-------

Expose offer allocation info within the master /state endpoint.


Diffs
-----

  src/master/http.cpp 6e5178eeea6cc6b90ae253840da22be13444b088 
  src/tests/master_tests.cpp 357a9a47ef87be6cbc4256d8afabe63cd41b1ea1 

Diff: https://reviews.apache.org/r/57013/diff/


Testing
-------

Updated an existing test.


Thanks,

Benjamin Mahler


Re: Review Request 57013: Expose offer allocation info within the master /state endpoint.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57013/#review166645
-----------------------------------------------------------



Patch looks great!

Reviews applied: [57013]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 24, 2017, 1:27 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57013/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2017, 1:27 a.m.)
> 
> 
> Review request for mesos, Jay Guo and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Expose offer allocation info within the master /state endpoint.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 6e5178eeea6cc6b90ae253840da22be13444b088 
>   src/tests/master_tests.cpp 357a9a47ef87be6cbc4256d8afabe63cd41b1ea1 
> 
> Diff: https://reviews.apache.org/r/57013/diff/
> 
> 
> Testing
> -------
> 
> Updated an existing test.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Re: Review Request 57013: Expose offer allocation info within the master /state endpoint.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57013/#review167578
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Feb. 23, 2017, 5:27 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57013/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2017, 5:27 p.m.)
> 
> 
> Review request for mesos, Jay Guo and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Expose offer allocation info within the master /state endpoint.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 6e5178eeea6cc6b90ae253840da22be13444b088 
>   src/tests/master_tests.cpp 357a9a47ef87be6cbc4256d8afabe63cd41b1ea1 
> 
> 
> Diff: https://reviews.apache.org/r/57013/diff/1/
> 
> 
> Testing
> -------
> 
> Updated an existing test.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>