You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/02/17 08:12:13 UTC
Review Request 56781: Fixed compilation on VS 2017.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56781/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Alex Clemmer, and Joseph Wu.
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/include/process/future.hpp 819ee5ceb8f2900087c2a06d5b1df0a1aeb413f6
Diff: https://reviews.apache.org/r/56781/diff/
Testing
-------
Tested on VS 2015 and 2017.
Thanks,
Michael Park
Re: Review Request 56781: Fixed compilation on VS 2017.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56781/#review165916
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56781]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 17, 2017, 8:12 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56781/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2017, 8:12 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Alex Clemmer, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp 819ee5ceb8f2900087c2a06d5b1df0a1aeb413f6
>
> Diff: https://reviews.apache.org/r/56781/diff/
>
>
> Testing
> -------
>
> Tested on VS 2015 and 2017.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 56781: Fixed compilation on VS 2017.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56781/#review165913
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/include/process/future.hpp (line 412)
<https://reviews.apache.org/r/56781/#comment237757>
Should this be `#endif // __WINDOWS__`?
- Alex Clemmer
On Feb. 17, 2017, 8:12 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56781/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2017, 8:12 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Alex Clemmer, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp 819ee5ceb8f2900087c2a06d5b1df0a1aeb413f6
>
> Diff: https://reviews.apache.org/r/56781/diff/
>
>
> Testing
> -------
>
> Tested on VS 2015 and 2017.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 56781: Fixed compilation on VS 2017.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56781/
-----------------------------------------------------------
(Updated Feb. 17, 2017, 12:07 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Alex Clemmer, and Joseph Wu.
Changes
-------
Addressed Alex's comment.
Repository: mesos
Description (updated)
-------
Fixed compilation on VS 2017.
Diffs (updated)
-----
3rdparty/libprocess/include/process/future.hpp 819ee5ceb8f2900087c2a06d5b1df0a1aeb413f6
Diff: https://reviews.apache.org/r/56781/diff/
Testing
-------
Tested on VS 2015 and 2017.
Thanks,
Michael Park