You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/02/03 23:05:53 UTC
Review Request 56293: Added '--runtime_dir' flag to the agent
configuration docs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56293/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jie Yu.
Repository: mesos
Description
-------
This patch adds the `--runtime_dir` flag to the agent
configuration documentation.
Diffs
-----
docs/configuration.md 6a30471d325f35e171e81a687c23fd69e9ec97ee
Diff: https://reviews.apache.org/r/56293/diff/
Testing
-------
Built the website in the repo's Docker container and viewed config docs in Chrome.
Thanks,
Greg Mann
Re: Review Request 56293: Added '--runtime_dir' flag to the agent
configuration docs.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56293/#review164191
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Feb. 3, 2017, 3:05 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56293/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2017, 3:05 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds the `--runtime_dir` flag to the agent
> configuration documentation.
>
>
> Diffs
> -----
>
> docs/configuration.md 6a30471d325f35e171e81a687c23fd69e9ec97ee
>
> Diff: https://reviews.apache.org/r/56293/diff/
>
>
> Testing
> -------
>
> Built the website in the repo's Docker container and viewed config docs in Chrome.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56293: Added '--runtime_dir' flag to the agent
configuration docs.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56293/#review164258
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56293]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 3, 2017, 11:05 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56293/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2017, 11:05 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds the `--runtime_dir` flag to the agent
> configuration documentation.
>
>
> Diffs
> -----
>
> docs/configuration.md 6a30471d325f35e171e81a687c23fd69e9ec97ee
>
> Diff: https://reviews.apache.org/r/56293/diff/
>
>
> Testing
> -------
>
> Built the website in the repo's Docker container and viewed config docs in Chrome.
>
>
> Thanks,
>
> Greg Mann
>
>