You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/02/10 07:26:59 UTC

Review Request 56533: Fix the shell script to not use deprecated [..] in increment operation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56533/
-----------------------------------------------------------

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-7101
    https://issues.apache.org/jira/browse/MESOS-7101


Repository: mesos


Description
-------

Fix the shell script to not use deprecated [..] in increment operation.


Diffs
-----

  src/examples/persistent_volume_framework.cpp 702dba3e025923819874a6f6b082e5c78289fb0e 

Diff: https://reviews.apache.org/r/56533/diff/


Testing
-------

Tests passed.


Thanks,

Anindya Sinha


Re: Review Request 56533: Fix the shell script to not use deprecated [..] in increment operation.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56533/#review165129
-----------------------------------------------------------



Patch looks great!

Reviews applied: [56533]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 10, 2017, 7:26 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56533/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2017, 7:26 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7101
>     https://issues.apache.org/jira/browse/MESOS-7101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix the shell script to not use deprecated [..] in increment operation.
> 
> 
> Diffs
> -----
> 
>   src/examples/persistent_volume_framework.cpp 702dba3e025923819874a6f6b082e5c78289fb0e 
> 
> Diff: https://reviews.apache.org/r/56533/diff/
> 
> 
> Testing
> -------
> 
> Tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Re: Review Request 56533: Fix the shell script to not use deprecated [..] in increment operation.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56533/#review165137
-----------------------------------------------------------


Ship it!




Ship It!

- Jiang Yan Xu


On Feb. 9, 2017, 11:26 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56533/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 11:26 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7101
>     https://issues.apache.org/jira/browse/MESOS-7101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix the shell script to not use deprecated [..] in increment operation.
> 
> 
> Diffs
> -----
> 
>   src/examples/persistent_volume_framework.cpp 702dba3e025923819874a6f6b082e5c78289fb0e 
> 
> Diff: https://reviews.apache.org/r/56533/diff/
> 
> 
> Testing
> -------
> 
> Tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>