You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/02/10 01:36:30 UTC
Review Request 56525: Fixed a crash on the agent when handling the
SIGUSR1 signal.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56525/
-----------------------------------------------------------
Review request for mesos and Joseph Wu.
Bugs: MESOS-7102
https://issues.apache.org/jira/browse/MESOS-7102
Repository: mesos
Description
-------
There were some actors that were not being destructed when
`finalize()` was being invoked. Also fixed the order of the
destruction of objects i.e., in the reverse order of their
creation.
Diffs
-----
src/slave/main.cpp b9f9748d98775b2a511ded35bbf72099bfeeba64
Diff: https://reviews.apache.org/r/56525/diff/
Testing
-------
make check, manually tested to ensure we don't crash on a `SIGUSR1` signal.
Thanks,
Anand Mazumdar
Re: Review Request 56525: Fixed a crash on the agent when handling the
SIGUSR1 signal.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56525/#review165060
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56525]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 10, 2017, 1:36 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56525/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 1:36 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-7102
> https://issues.apache.org/jira/browse/MESOS-7102
>
>
> Repository: mesos
>
>
> Description
> -------
>
> There were some actors that were not being destructed when
> `finalize()` was being invoked. Also fixed the order of the
> destruction of objects i.e., in the reverse order of their
> creation.
>
>
> Diffs
> -----
>
> src/slave/main.cpp b9f9748d98775b2a511ded35bbf72099bfeeba64
>
> Diff: https://reviews.apache.org/r/56525/diff/
>
>
> Testing
> -------
>
> make check, manually tested to ensure we don't crash on a `SIGUSR1` signal.
>
>
> Thanks,
>
> Anand Mazumdar
>
>