You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2017/02/13 23:04:20 UTC

Re: Review Request 55030: CMake: Added source groups for libprocess build.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55030/
-----------------------------------------------------------

(Updated Feb. 13, 2017, 11:04 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.


Changes
-------

Rebase to account for changes in `master`.


Bugs: MESOS-3542
    https://issues.apache.org/jira/browse/MESOS-3542


Repository: mesos


Description
-------

Currently in IDEs such as XCode and Visual Studio, all mesos source
files are grouped into one huge folder, with no attempt made to reflect
the hierarchy of folders that exist on disk.

This commit groups libprocess files into relevant source groups so that
they appear in a sensible directory structure in these IDEs.

In addition to beginning to directly address MESOS-3542, this is also
(indirectly) the first step towards addressing the problem of breaking
libmesos up into smaller binaries (MESOS-3542).


Diffs (updated)
-----

  3rdparty/libprocess/src/CMakeLists.txt ab362aa476e528deef691239a70f0be9d864e6c0 
  3rdparty/libprocess/src/tests/CMakeLists.txt c65c7f5a97817f4a790136e97eb9f02c0bf810b9 

Diff: https://reviews.apache.org/r/55030/diff/


Testing
-------


Thanks,

Alex Clemmer