You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/02/06 23:22:40 UTC
Review Request 56354: Fixed incorrect `CHECK_EQ`s in `WindowsFD`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56354/
-----------------------------------------------------------
Review request for mesos and Alex Clemmer.
Repository: mesos
Description
-------
We store both the `CRT` and `HANDLE` in `WindowsFD` whether we construct
from `CRT` or `HANDLE` by using `_get_osfhandle` and `_open_osfhandle`.
Thus, accessing the `CRT` via `crt()` does not require that it be in the
`CRT` state, but rather `CRT` or `HANDLE`, for example.
Diffs
-----
3rdparty/stout/include/stout/os/windows/fd.hpp 24d3661aad72817d8b9e3cd88fe6178ab60832bd
Diff: https://reviews.apache.org/r/56354/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 56354: Fixed incorrect `CHECK_EQ`s in `WindowsFD`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56354/#review164427
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Feb. 6, 2017, 3:23 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56354/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 3:23 p.m.)
>
>
> Review request for mesos and Alex Clemmer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We store both the `CRT` and `HANDLE` in `WindowsFD` whether we construct
> from `CRT` or `HANDLE` by using `_get_osfhandle` and `_open_osfhandle`.
>
> Thus, accessing the `CRT` via `crt()` does not require that it be in the
> `CRT` state, but rather `CRT` or `HANDLE`, for example.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/fd.hpp 24d3661aad72817d8b9e3cd88fe6178ab60832bd
>
> Diff: https://reviews.apache.org/r/56354/diff/
>
>
> Testing
> -------
>
> Ran `.\support\windows-build.bat` on a Windows VM.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 56354: Fixed incorrect `CHECK_EQ`s in `WindowsFD`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56354/#review164430
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On Feb. 6, 2017, 11:23 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56354/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 11:23 p.m.)
>
>
> Review request for mesos and Alex Clemmer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We store both the `CRT` and `HANDLE` in `WindowsFD` whether we construct
> from `CRT` or `HANDLE` by using `_get_osfhandle` and `_open_osfhandle`.
>
> Thus, accessing the `CRT` via `crt()` does not require that it be in the
> `CRT` state, but rather `CRT` or `HANDLE`, for example.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/fd.hpp 24d3661aad72817d8b9e3cd88fe6178ab60832bd
>
> Diff: https://reviews.apache.org/r/56354/diff/
>
>
> Testing
> -------
>
> Ran `.\support\windows-build.bat` on a Windows VM.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 56354: Fixed incorrect `CHECK_EQ`s in `WindowsFD`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56354/#review164425
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Clemmer
On Feb. 6, 2017, 11:23 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56354/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 11:23 p.m.)
>
>
> Review request for mesos and Alex Clemmer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We store both the `CRT` and `HANDLE` in `WindowsFD` whether we construct
> from `CRT` or `HANDLE` by using `_get_osfhandle` and `_open_osfhandle`.
>
> Thus, accessing the `CRT` via `crt()` does not require that it be in the
> `CRT` state, but rather `CRT` or `HANDLE`, for example.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/fd.hpp 24d3661aad72817d8b9e3cd88fe6178ab60832bd
>
> Diff: https://reviews.apache.org/r/56354/diff/
>
>
> Testing
> -------
>
> Ran `.\support\windows-build.bat` on a Windows VM.
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 56354: Fixed incorrect `CHECK_EQ`s in `WindowsFD`.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56354/
-----------------------------------------------------------
(Updated Feb. 6, 2017, 3:23 p.m.)
Review request for mesos and Alex Clemmer.
Repository: mesos
Description
-------
We store both the `CRT` and `HANDLE` in `WindowsFD` whether we construct
from `CRT` or `HANDLE` by using `_get_osfhandle` and `_open_osfhandle`.
Thus, accessing the `CRT` via `crt()` does not require that it be in the
`CRT` state, but rather `CRT` or `HANDLE`, for example.
Diffs
-----
3rdparty/stout/include/stout/os/windows/fd.hpp 24d3661aad72817d8b9e3cd88fe6178ab60832bd
Diff: https://reviews.apache.org/r/56354/diff/
Testing (updated)
-------
Ran `.\support\windows-build.bat` on a Windows VM.
Thanks,
Michael Park