You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/02/20 05:00:55 UTC
Review Request 56832: Added output operator for `OnTerminationPolicy`
enum.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56832/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
Added output operator for `OnTerminationPolicy` enum.
Diffs
-----
include/mesos/type_utils.hpp c7f86ac3a8c166512410d89678a4dd2622771bf0
src/common/type_utils.cpp d86d56d4e1d353d6e82ccff89357bf2abec6eded
Diff: https://reviews.apache.org/r/56832/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 56832: Added output operator for
`OnTerminationPolicy` enum.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56832/#review166221
-----------------------------------------------------------
src/common/type_utils.cpp (line 580)
<https://reviews.apache.org/r/56832/#comment238116>
Looks like it is only stringifying `type`. Should we have this operator just take `type` as argument instead of the whole policy?
- Vinod Kone
On Feb. 20, 2017, 5 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56832/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2017, 5 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added output operator for `OnTerminationPolicy` enum.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp c7f86ac3a8c166512410d89678a4dd2622771bf0
> src/common/type_utils.cpp d86d56d4e1d353d6e82ccff89357bf2abec6eded
>
> Diff: https://reviews.apache.org/r/56832/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 56832: Added output operator for
`TerminationPolicy::Type` enum.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56832/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 6:17 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comments
Summary (updated)
-----------------
Added output operator for `TerminationPolicy::Type` enum.
Repository: mesos
Description (updated)
-------
Added output operator for `TerminationPolicy::Type` enum.
Diffs (updated)
-----
include/mesos/type_utils.hpp c7f86ac3a8c166512410d89678a4dd2622771bf0
src/common/type_utils.cpp d86d56d4e1d353d6e82ccff89357bf2abec6eded
Diff: https://reviews.apache.org/r/56832/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar