You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/02/20 05:01:23 UTC
Review Request 56834: Send a TASK_ERROR update if a task specifies
`OnTerminationPolicy`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56834/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
The docker/command executor currently do not support it yet.
Diffs
-----
src/docker/executor.cpp 6c11320fc40ba1eebdbdf95f0a52ac383646d9f8
src/launcher/executor.cpp d9417ce1d5b108f5292a66010eab80f11552a969
Diff: https://reviews.apache.org/r/56834/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 56834: Send a TASK_ERROR update if a task specifies
`TerminationPolicy`.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56834/#review166420
-----------------------------------------------------------
src/docker/executor.cpp (line 136)
<https://reviews.apache.org/r/56834/#comment238354>
TASK_ERROR?
- Vinod Kone
On Feb. 22, 2017, 6:17 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56834/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 6:17 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The docker/command executor currently do not support it yet.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 6c11320fc40ba1eebdbdf95f0a52ac383646d9f8
> src/launcher/executor.cpp d9417ce1d5b108f5292a66010eab80f11552a969
>
> Diff: https://reviews.apache.org/r/56834/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 56834: Send a TASK_ERROR update if a task specifies
`TerminationPolicy`.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56834/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 6:17 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Rebased.
Summary (updated)
-----------------
Send a TASK_ERROR update if a task specifies `TerminationPolicy`.
Repository: mesos
Description
-------
The docker/command executor currently do not support it yet.
Diffs (updated)
-----
src/docker/executor.cpp 6c11320fc40ba1eebdbdf95f0a52ac383646d9f8
src/launcher/executor.cpp d9417ce1d5b108f5292a66010eab80f11552a969
Diff: https://reviews.apache.org/r/56834/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 56834: Send a TASK_ERROR update if a task specifies
`OnTerminationPolicy`.
Posted by Anand Mazumdar <an...@apache.org>.
> On Feb. 21, 2017, 9:58 p.m., Vinod Kone wrote:
> > src/docker/executor.cpp, line 133
> > <https://reviews.apache.org/r/56834/diff/1/?file=1640435#file1640435line133>
> >
> > If termination policy is only valid for task group tasks and not normal tasks, we can do that validation in validation.cpp instead of here.
hmm, a termination policy can be specified for a task too by a custom executor. Also, as per our offline discussion, we need to do the validation here on the executor rather than on the master/agent.
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56834/#review166237
-----------------------------------------------------------
On Feb. 20, 2017, 5:01 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56834/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2017, 5:01 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The docker/command executor currently do not support it yet.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 6c11320fc40ba1eebdbdf95f0a52ac383646d9f8
> src/launcher/executor.cpp d9417ce1d5b108f5292a66010eab80f11552a969
>
> Diff: https://reviews.apache.org/r/56834/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 56834: Send a TASK_ERROR update if a task specifies
`OnTerminationPolicy`.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56834/#review166237
-----------------------------------------------------------
src/docker/executor.cpp (line 133)
<https://reviews.apache.org/r/56834/#comment238141>
If termination policy is only valid for task group tasks and not normal tasks, we can do that validation in validation.cpp instead of here.
- Vinod Kone
On Feb. 20, 2017, 5:01 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56834/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2017, 5:01 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The docker/command executor currently do not support it yet.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 6c11320fc40ba1eebdbdf95f0a52ac383646d9f8
> src/launcher/executor.cpp d9417ce1d5b108f5292a66010eab80f11552a969
>
> Diff: https://reviews.apache.org/r/56834/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>