You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/02/24 10:53:40 UTC
Review Request 57032: Added allocation role validation for Create
operation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57032/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-6636
https://issues.apache.org/jira/browse/MESOS-6636
Repository: mesos
Description
-------
With support for multi-role frameworks, we need to make sure that
individual create operation cannot mix allocation roles.
Diffs
-----
src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f
src/tests/master_validation_tests.cpp 45254739e2a62fed7008ceada7a8f64bb9ee4e31
Diff: https://reviews.apache.org/r/57032/diff/
Testing
-------
make check
Thanks,
Jay Guo
Re: Review Request 57032: Added allocation role validation for Create
operation.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57032/#review166766
-----------------------------------------------------------
Fix it, then Ship it!
src/master/validation.cpp (lines 1797 - 1801)
<https://reviews.apache.org/r/57032/#comment238848>
Let's check this only if there is a framework info.
Also, as a follow up we could introduce the allocation info checking much like we did for the reserve operation. That is, ensure it's unallocated if there is no framework info.
src/master/validation.cpp (line 1800)
<https://reviews.apache.org/r/57032/#comment238849>
No need for putting this on a new line?
src/tests/master_validation_tests.cpp (line 883)
<https://reviews.apache.org/r/57032/#comment238850>
Should pass in the frameworkInfo here?
- Benjamin Mahler
On Feb. 24, 2017, 11:05 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57032/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 11:05 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6636
> https://issues.apache.org/jira/browse/MESOS-6636
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With support for multi-role frameworks, we need to make sure that
> individual create operation cannot mix allocation roles.
>
>
> Diffs
> -----
>
> src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f
> src/tests/master_validation_tests.cpp 45254739e2a62fed7008ceada7a8f64bb9ee4e31
>
> Diff: https://reviews.apache.org/r/57032/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 57032: Added allocation role validation for Create
operation.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57032/#review166689
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56938, 56939, 57030, 57031, 57032]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 24, 2017, 11:05 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57032/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 11:05 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6636
> https://issues.apache.org/jira/browse/MESOS-6636
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With support for multi-role frameworks, we need to make sure that
> individual create operation cannot mix allocation roles.
>
>
> Diffs
> -----
>
> src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f
> src/tests/master_validation_tests.cpp 45254739e2a62fed7008ceada7a8f64bb9ee4e31
>
> Diff: https://reviews.apache.org/r/57032/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 57032: Added allocation role validation for Create
operation.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57032/
-----------------------------------------------------------
(Updated Feb. 24, 2017, 7:05 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-6636
https://issues.apache.org/jira/browse/MESOS-6636
Repository: mesos
Description
-------
With support for multi-role frameworks, we need to make sure that
individual create operation cannot mix allocation roles.
Diffs (updated)
-----
src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f
src/tests/master_validation_tests.cpp 45254739e2a62fed7008ceada7a8f64bb9ee4e31
Diff: https://reviews.apache.org/r/57032/diff/
Testing
-------
make check
Thanks,
Jay Guo