You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/02/21 23:28:54 UTC
Review Request 56904: Documented provisioner auto backend semantic.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56904/
-----------------------------------------------------------
Review request for mesos, Adam B, Avinash sridharan, Jie Yu, and Neil Conway.
Bugs: MESOS-7154
https://issues.apache.org/jira/browse/MESOS-7154
Repository: mesos
Description
-------
Documented provisioner auto backend semantic.
Diffs
-----
docs/container-image.md 6740ce154e832647f80e91042e335aad08200e64
Diff: https://reviews.apache.org/r/56904/diff/
Testing
-------
github gist
Thanks,
Gilbert Song
Re: Review Request 56904: Documented provisioner auto backend
semantic.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56904/#review166323
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56904]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 21, 2017, 11:28 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56904/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 11:28 p.m.)
>
>
> Review request for mesos, Adam B, Avinash sridharan, Jie Yu, and Neil Conway.
>
>
> Bugs: MESOS-7154
> https://issues.apache.org/jira/browse/MESOS-7154
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documented provisioner auto backend semantic.
>
>
> Diffs
> -----
>
> docs/container-image.md 6740ce154e832647f80e91042e335aad08200e64
>
> Diff: https://reviews.apache.org/r/56904/diff/
>
>
> Testing
> -------
>
> github gist
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 56904: Documented provisioner auto backend
semantic.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56904/#review166630
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 22, 2017, 7:04 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56904/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 7:04 a.m.)
>
>
> Review request for mesos, Adam B, Avinash sridharan, Jie Yu, and Neil Conway.
>
>
> Bugs: MESOS-7154
> https://issues.apache.org/jira/browse/MESOS-7154
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documented provisioner auto backend semantic.
>
>
> Diffs
> -----
>
> docs/container-image.md 6740ce154e832647f80e91042e335aad08200e64
>
> Diff: https://reviews.apache.org/r/56904/diff/
>
>
> Testing
> -------
>
> github gist
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 56904: Documented provisioner auto backend
semantic.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56904/#review166349
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56904]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 22, 2017, 7:04 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56904/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 7:04 a.m.)
>
>
> Review request for mesos, Adam B, Avinash sridharan, Jie Yu, and Neil Conway.
>
>
> Bugs: MESOS-7154
> https://issues.apache.org/jira/browse/MESOS-7154
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documented provisioner auto backend semantic.
>
>
> Diffs
> -----
>
> docs/container-image.md 6740ce154e832647f80e91042e335aad08200e64
>
> Diff: https://reviews.apache.org/r/56904/diff/
>
>
> Testing
> -------
>
> github gist
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 56904: Documented provisioner auto backend
semantic.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56904/
-----------------------------------------------------------
(Updated Feb. 21, 2017, 11:04 p.m.)
Review request for mesos, Adam B, Avinash sridharan, Jie Yu, and Neil Conway.
Bugs: MESOS-7154
https://issues.apache.org/jira/browse/MESOS-7154
Repository: mesos
Description
-------
Documented provisioner auto backend semantic.
Diffs (updated)
-----
docs/container-image.md 6740ce154e832647f80e91042e335aad08200e64
Diff: https://reviews.apache.org/r/56904/diff/
Testing
-------
github gist
Thanks,
Gilbert Song
Re: Review Request 56904: Documented provisioner auto backend
semantic.
Posted by Gilbert Song <so...@gmail.com>.
> On Feb. 21, 2017, 4:05 p.m., Qian Zhang wrote:
> > docs/container-image.md, line 308
> > <https://reviews.apache.org/r/56904/diff/1/?file=1641714#file1641714line308>
> >
> > Duplicated `the`.
Fixed. Thanks, Qian! :)
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56904/#review166273
-----------------------------------------------------------
On Feb. 21, 2017, 11:04 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56904/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 11:04 p.m.)
>
>
> Review request for mesos, Adam B, Avinash sridharan, Jie Yu, and Neil Conway.
>
>
> Bugs: MESOS-7154
> https://issues.apache.org/jira/browse/MESOS-7154
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documented provisioner auto backend semantic.
>
>
> Diffs
> -----
>
> docs/container-image.md 6740ce154e832647f80e91042e335aad08200e64
>
> Diff: https://reviews.apache.org/r/56904/diff/
>
>
> Testing
> -------
>
> github gist
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 56904: Documented provisioner auto backend
semantic.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56904/#review166273
-----------------------------------------------------------
docs/container-image.md (line 308)
<https://reviews.apache.org/r/56904/#comment238188>
Duplicated `the`.
- Qian Zhang
On Feb. 22, 2017, 7:28 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56904/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 7:28 a.m.)
>
>
> Review request for mesos, Adam B, Avinash sridharan, Jie Yu, and Neil Conway.
>
>
> Bugs: MESOS-7154
> https://issues.apache.org/jira/browse/MESOS-7154
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documented provisioner auto backend semantic.
>
>
> Diffs
> -----
>
> docs/container-image.md 6740ce154e832647f80e91042e335aad08200e64
>
> Diff: https://reviews.apache.org/r/56904/diff/
>
>
> Testing
> -------
>
> github gist
>
>
> Thanks,
>
> Gilbert Song
>
>