You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/02/03 04:45:58 UTC
Review Request 56270: Made the default executor launch multiple task
groups.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56270/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-6296
https://issues.apache.org/jira/browse/MESOS-6296
Repository: mesos
Description
-------
If a task fails or is explicitly killed by the scheduler, the
default on termination policy kills the particular task group.
The executor commits suicide when there are no active tasks.
Diffs
-----
src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
src/tests/default_executor_tests.cpp e8e0aa2f0d2508de6db03685c70d1ed9c1da3659
Diff: https://reviews.apache.org/r/56270/diff/
Testing
-------
make check. Also, modified an existing test to launch/kill multiple task groups.
Thanks,
Anand Mazumdar
Re: Review Request 56270: Made the default executor launch multiple
task groups.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56270/#review164094
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56267, 56268, 56269, 56270]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 3, 2017, 4:45 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56270/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2017, 4:45 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6296
> https://issues.apache.org/jira/browse/MESOS-6296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If a task fails or is explicitly killed by the scheduler, the
> default on termination policy kills the particular task group.
> The executor commits suicide when there are no active tasks.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
> src/tests/default_executor_tests.cpp e8e0aa2f0d2508de6db03685c70d1ed9c1da3659
>
> Diff: https://reviews.apache.org/r/56270/diff/
>
>
> Testing
> -------
>
> make check. Also, modified an existing test to launch/kill multiple task groups.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 56270: Made the default executor launch multiple
task groups.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56270/#review164183
-----------------------------------------------------------
src/launcher/default_executor.cpp (line 472)
<https://reviews.apache.org/r/56270/#comment235810>
s/pending/containerIds/
src/launcher/default_executor.cpp (line 493)
<https://reviews.apache.org/r/56270/#comment235812>
s/pending/containerIds/
src/launcher/default_executor.cpp (lines 686 - 725)
<https://reviews.apache.org/r/56270/#comment235815>
I'm wondering if it would be easier to grok if we locally generate a UUID for a task group and use that in the executor code.
also, do we really need `killTaskGroups`? looks like we could just look in `killed/killing` to avoid killing a task multiple times?
src/launcher/default_executor.cpp (line 1033)
<https://reviews.apache.org/r/56270/#comment235809>
you wouldn't need this if you key it on TaskID per my comment in the previous review.
src/tests/default_executor_tests.cpp (lines 333 - 334)
<https://reviews.apache.org/r/56270/#comment235820>
move this to #391.
src/tests/default_executor_tests.cpp (lines 340 - 341)
<https://reviews.apache.org/r/56270/#comment235823>
move this to #391.
src/tests/default_executor_tests.cpp
<https://reviews.apache.org/r/56270/#comment235824>
i would keep the expectation here and ensure it is still pending after the first kill.
- Vinod Kone
On Feb. 3, 2017, 4:45 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56270/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2017, 4:45 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6296
> https://issues.apache.org/jira/browse/MESOS-6296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If a task fails or is explicitly killed by the scheduler, the
> default on termination policy kills the particular task group.
> The executor commits suicide when there are no active tasks.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
> src/tests/default_executor_tests.cpp e8e0aa2f0d2508de6db03685c70d1ed9c1da3659
>
> Diff: https://reviews.apache.org/r/56270/diff/
>
>
> Testing
> -------
>
> make check. Also, modified an existing test to launch/kill multiple task groups.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 56270: Made the default executor launch multiple
task groups.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56270/#review164268
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56267, 56308, 56269, 56268, 56270]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 4, 2017, 5:53 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56270/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2017, 5:53 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6296
> https://issues.apache.org/jira/browse/MESOS-6296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If a task fails or is explicitly killed by the scheduler, the
> default on termination policy kills the particular task group.
> The executor commits suicide when there are no active tasks.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
> src/tests/default_executor_tests.cpp e8e0aa2f0d2508de6db03685c70d1ed9c1da3659
>
> Diff: https://reviews.apache.org/r/56270/diff/
>
>
> Testing
> -------
>
> make check. Also, modified an existing test to launch/kill multiple task groups.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 56270: Made the default executor launch multiple
task groups.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56270/#review164422
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 4, 2017, 5:53 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56270/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2017, 5:53 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6296
> https://issues.apache.org/jira/browse/MESOS-6296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If a task fails or is explicitly killed by the scheduler, the
> default on termination policy kills the particular task group.
> The executor commits suicide when there are no active tasks.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
> src/tests/default_executor_tests.cpp e8e0aa2f0d2508de6db03685c70d1ed9c1da3659
>
> Diff: https://reviews.apache.org/r/56270/diff/
>
>
> Testing
> -------
>
> make check. Also, modified an existing test to launch/kill multiple task groups.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 56270: Made the default executor launch multiple
task groups.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56270/
-----------------------------------------------------------
(Updated Feb. 4, 2017, 5:53 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comments.
Bugs: MESOS-6296
https://issues.apache.org/jira/browse/MESOS-6296
Repository: mesos
Description
-------
If a task fails or is explicitly killed by the scheduler, the
default on termination policy kills the particular task group.
The executor commits suicide when there are no active tasks.
Diffs (updated)
-----
src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
src/tests/default_executor_tests.cpp e8e0aa2f0d2508de6db03685c70d1ed9c1da3659
Diff: https://reviews.apache.org/r/56270/diff/
Testing
-------
make check. Also, modified an existing test to launch/kill multiple task groups.
Thanks,
Anand Mazumdar