You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/02/20 05:01:10 UTC
Review Request 56833: Added validation for on termination policy to
the master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56833/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
Added validation for on termination policy to the master.
Diffs
-----
src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f
Diff: https://reviews.apache.org/r/56833/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 56833: Added validation for termination policy to
the master.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56833/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 6:17 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comments
Summary (updated)
-----------------
Added validation for termination policy to the master.
Repository: mesos
Description (updated)
-------
Added validation for termination policy to the master.
Diffs (updated)
-----
src/master/validation.hpp f03b3280704083be1ca074ca07c69edbb49dae19
src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f
src/tests/master_validation_tests.cpp 53771f6b5492009fe75cbbfc03a2b542856c1070
Diff: https://reviews.apache.org/r/56833/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 56833: Added validation for on termination policy
to the master.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56833/#review166235
-----------------------------------------------------------
Can you add unit tests for the validation?
src/master/validation.cpp (line 883)
<https://reviews.apache.org/r/56833/#comment238139>
don't you want to return error here?
- Vinod Kone
On Feb. 20, 2017, 5:01 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56833/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2017, 5:01 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation for on termination policy to the master.
>
>
> Diffs
> -----
>
> src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f
>
> Diff: https://reviews.apache.org/r/56833/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>