You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2017/02/28 05:09:45 UTC

Review Request 57122: Added STDIN IO to 'ContainerLogger::ContainerIO' class.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57122/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Joseph Wu.


Bugs: MESOS-7050
    https://issues.apache.org/jira/browse/MESOS-7050


Repository: mesos


Description
-------

Added STDIN IO to 'ContainerLogger::ContainerIO' class.


Diffs
-----

  include/mesos/slave/container_logger.hpp a3f619b79ca0188df9e231c600dfa396f39ab29a 

Diff: https://reviews.apache.org/r/57122/diff/


Testing
-------


Thanks,

Kevin Klues


Re: Review Request 57122: Added STDIN IO to 'ContainerLogger::ContainerIO' class.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57122/
-----------------------------------------------------------

(Updated March 1, 2017, 1:42 a.m.)


Review request for mesos, Jie Yu and Joseph Wu.


Changes
-------

Updated to reflect @jie's comments from 57121


Bugs: MESOS-7050
    https://issues.apache.org/jira/browse/MESOS-7050


Repository: mesos


Description
-------

Added STDIN IO to 'ContainerLogger::ContainerIO' class.


Diffs (updated)
-----

  include/mesos/slave/container_logger.hpp a3f619b79ca0188df9e231c600dfa396f39ab29a 

Diff: https://reviews.apache.org/r/57122/diff/


Testing
-------


Thanks,

Kevin Klues


Re: Review Request 57122: Added STDIN IO to 'ContainerLogger::ContainerIO' class.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57122/#review167158
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Feb. 28, 2017, 5:09 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57122/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 5:09 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Bugs: MESOS-7050
>     https://issues.apache.org/jira/browse/MESOS-7050
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added STDIN IO to 'ContainerLogger::ContainerIO' class.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/container_logger.hpp a3f619b79ca0188df9e231c600dfa396f39ab29a 
> 
> Diff: https://reviews.apache.org/r/57122/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>