You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@apache.org> on 2017/02/07 10:10:20 UTC
Review Request 56374: Enabled revive offer per role.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56374/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Jay Guo.
Bugs: MESOS-6638
https://issues.apache.org/jira/browse/MESOS-6638
Repository: mesos
Description
-------
Enabled revive offer per role.
Diffs
-----
include/mesos/allocator/allocator.hpp 71a40537b673e44ecdd5327d9a9f083faa7fc13a
src/master/allocator/mesos/allocator.hpp e3c86181677302dbfc3b213715196122f96e312c
src/master/allocator/mesos/hierarchical.hpp 896abcdf0727f986eef3a1a9304a0e4847094057
src/master/allocator/mesos/hierarchical.cpp 56d6791baa64189523df668749f4a7ab67d6b363
src/master/master.cpp 98c39b279e7b9830d02efc8ec6a4469afc15d62a
src/tests/allocator.hpp 32c291213d18d1c8fe5d9e8194b92c10716b9961
src/tests/hierarchical_allocator_tests.cpp c681d03c3f94f7d071143366a5aad0421108ebec
Diff: https://reviews.apache.org/r/56374/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 56374: Enabled revive offer per role.
Posted by Guangya Liu <gy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56374/
-----------------------------------------------------------
(Updated \u4e8c\u6708 9, 2017, 6:36 a.m.)
Review request for mesos, Benjamin Mahler and Jay Guo.
Bugs: MESOS-6638
https://issues.apache.org/jira/browse/MESOS-6638
Repository: mesos
Description
-------
Enabled revive offer per role.
Diffs (updated)
-----
include/mesos/allocator/allocator.hpp 71a40537b673e44ecdd5327d9a9f083faa7fc13a
src/master/allocator/mesos/allocator.hpp e3c86181677302dbfc3b213715196122f96e312c
src/master/allocator/mesos/hierarchical.hpp 896abcdf0727f986eef3a1a9304a0e4847094057
src/master/allocator/mesos/hierarchical.cpp 017253cc8f5fbcccd9d4057c5b189f352779513c
src/master/master.cpp 0b65345d48192a1536d43973cf782ade3c1c8163
src/tests/allocator.hpp 32c291213d18d1c8fe5d9e8194b92c10716b9961
src/tests/hierarchical_allocator_tests.cpp c681d03c3f94f7d071143366a5aad0421108ebec
Diff: https://reviews.apache.org/r/56374/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 56374: Enabled revive offer per role.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56374/#review164783
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/allocator/allocator.hpp (lines 359 - 365)
<https://reviews.apache.org/r/56374/#comment236550>
```
/**
* Revives offers to this framework for the specified role. This is
* invoked by a framework when it wishes to receive filtered resources
* immediately or get itself out of a suppressed state.
*
* @param role The optional role parameter allows frameworks with multiple
* roles to do fine-grained revival.
*/
```
src/master/allocator/mesos/hierarchical.cpp (line 1220)
<https://reviews.apache.org/r/56374/#comment236558>
Do we do this parenthetical pluratity often? I don't think we should bother since it gets complicated with some english words where the plural form doesn't just add an 's'.
This seem fine to me:
```
Revived offers for roles {foo}
```
src/master/master.cpp (lines 4850 - 4870)
<https://reviews.apache.org/r/56374/#comment236553>
Ditto my comments on the supression patch, no need to validate the role here. Also the two follow up patches for a `drop()` overload and `framework->roles`.
- Benjamin Mahler
On Feb. 7, 2017, 10:10 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56374/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 10:10 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jay Guo.
>
>
> Bugs: MESOS-6638
> https://issues.apache.org/jira/browse/MESOS-6638
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled revive offer per role.
>
>
> Diffs
> -----
>
> include/mesos/allocator/allocator.hpp 71a40537b673e44ecdd5327d9a9f083faa7fc13a
> src/master/allocator/mesos/allocator.hpp e3c86181677302dbfc3b213715196122f96e312c
> src/master/allocator/mesos/hierarchical.hpp 896abcdf0727f986eef3a1a9304a0e4847094057
> src/master/allocator/mesos/hierarchical.cpp 56d6791baa64189523df668749f4a7ab67d6b363
> src/master/master.cpp 98c39b279e7b9830d02efc8ec6a4469afc15d62a
> src/tests/allocator.hpp 32c291213d18d1c8fe5d9e8194b92c10716b9961
> src/tests/hierarchical_allocator_tests.cpp c681d03c3f94f7d071143366a5aad0421108ebec
>
> Diff: https://reviews.apache.org/r/56374/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>